From 08514cbd2e26852cf4f800f4d9bc7b88e419fb80 Mon Sep 17 00:00:00 2001 From: Yair Morgenstern Date: Sun, 17 Dec 2023 22:33:05 +0200 Subject: [PATCH] 4.9.10 --- changelog.md | 20 +++++++++---------- .../ruleset/validation/UniqueValidator.kt | 4 +++- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/changelog.md b/changelog.md index 716a8f3ca2..ce174327b1 100644 --- a/changelog.md +++ b/changelog.md @@ -1,24 +1,22 @@ ## 4.9.10 -Add the remove unit promotion unique - By PLynx01 +Add remove unit promotion unique - By PLynx01 -Fix key bindings all reset to unbound on entering options and leaving without looking at the keys page - By SomeTroglodyte +Fix key bindings in edge case - By SomeTroglodyte By remdu: -- Coast spread algorithm -- avoid initializing with terrain that shouldn't be naturally generated +- Coast spread algorithm +- don'y initialize with non naturally generated terrain -Stop on Path Blocked - By itanasi +Stop movement on Path Blocked - By itanasi -Units that can't build roads should not have connect roads automation. - By willjallen +Only units that build roads have connect roads automation. - By willjallen By SeventhM: -- Fix Great Scientist science calculation -- Show stat percent differences in replacement building differences +- Fix Great Scientist calculation +- Show stat percent differences in replacement building -By dHannasch: -- Add BaseUnit.automaticallyUpgradedInProductionToUnitByTech() -- Don't list Unique requiring a tech in the Civilopedia for that tech +Don't list Unique requiring a tech in the Civilopedia for that tech - By dHannasch ## 4.9.9 diff --git a/core/src/com/unciv/models/ruleset/validation/UniqueValidator.kt b/core/src/com/unciv/models/ruleset/validation/UniqueValidator.kt index 562026e1c5..f0d61d4f04 100644 --- a/core/src/com/unciv/models/ruleset/validation/UniqueValidator.kt +++ b/core/src/com/unciv/models/ruleset/validation/UniqueValidator.kt @@ -85,8 +85,10 @@ class UniqueValidator(val ruleset: Ruleset) { } if (unique.conditionals.any() && unique.type in MapUnitCache.UnitMovementUniques) + // Not necessarily even a problem, but yes something mod maker should be aware of rulesetErrors.add("$prefix unique \"${unique.text}\" contains a conditional on a unit movement unique. " + - "Due to performance considerations, this conditional may not always apply.", RulesetErrorSeverity.WarningOptionsOnly) + "Due to performance considerations, this unique is cached on the unit," + + " and the conditional may not always limit the unique correctly.", RulesetErrorSeverity.OK) if (reportRulesetSpecificErrors) // If we don't filter these messages will be listed twice as this function is called twice on most objects