From 0ce033b3a93eff04a2f82e1e9e353c848b07dd7f Mon Sep 17 00:00:00 2001 From: Arthur van der Staaij <32672293+avdstaaij@users.noreply.github.com> Date: Tue, 17 Aug 2021 08:10:21 +0200 Subject: [PATCH] Disabled pillaging your own tiles (#4882) --- core/src/com/unciv/logic/automation/UnitAutomation.kt | 1 - core/src/com/unciv/ui/worldscreen/unit/UnitActions.kt | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/core/src/com/unciv/logic/automation/UnitAutomation.kt b/core/src/com/unciv/logic/automation/UnitAutomation.kt index 4134228131..e5af5cdda2 100644 --- a/core/src/com/unciv/logic/automation/UnitAutomation.kt +++ b/core/src/com/unciv/logic/automation/UnitAutomation.kt @@ -232,7 +232,6 @@ object UnitAutomation { val tilesThatCanWalkToAndThenPillage = unitDistanceToTiles .filter { it.value.totalDistance < unit.currentMovement }.keys .filter { unit.movement.canMoveTo(it) && UnitActions.canPillage(unit, it) } - .filter { it.getOwner() != unit.civInfo } if (tilesThatCanWalkToAndThenPillage.isEmpty()) return false val tileToPillage = tilesThatCanWalkToAndThenPillage.maxByOrNull { it: TileInfo -> it.getDefensiveBonus() }!! diff --git a/core/src/com/unciv/ui/worldscreen/unit/UnitActions.kt b/core/src/com/unciv/ui/worldscreen/unit/UnitActions.kt index 5172cc9610..c2b6fe8268 100644 --- a/core/src/com/unciv/ui/worldscreen/unit/UnitActions.kt +++ b/core/src/com/unciv/ui/worldscreen/unit/UnitActions.kt @@ -265,7 +265,7 @@ object UnitActions { fun getPillageAction(unit: MapUnit): UnitAction? { val tile = unit.currentTile - if (unit.isCivilian() || tile.improvement == null) return null + if (unit.isCivilian() || tile.improvement == null || tile.getOwner() == unit.civInfo) return null return UnitAction(UnitActionType.Pillage, action = { @@ -632,7 +632,7 @@ object UnitActions { if (tileImprovement == null || tileImprovement.hasUnique("Unpillagable")) return false val tileOwner = tile.getOwner() // Can't pillage friendly tiles, just like you can't attack them - it's an 'act of war' thing - return tileOwner == null || tileOwner == unit.civInfo || unit.civInfo.isAtWarWith(tileOwner) + return tileOwner == null || unit.civInfo.isAtWarWith(tileOwner) } private fun addGiftAction(unit: MapUnit, actionList: ArrayList, tile: TileInfo) {