mirrors/Unciv
1
0
Fork 0
mirror of https://github.com/yairm210/Unciv.git synced 2025-01-05 21:11:35 +07:00
Code Issues Packages Projects Releases Wiki Activity

Safeguard against errors in establishing the URL connection to Github

Browse Source
This commit is contained in:
Yair Morgenstern 2023-08-11 11:52:33 +03:00
parent 34fbe9e9a2
commit 42a5440a76
1 changed files with 18 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
core/src/com/unciv/ui/screens/pickerscreens/GitHub.kt
View File

@ -46,18 +46,25 @@ object Github {
* @return The [InputStream] if successful, `null` otherwise.
*/
fun download(url: String, action: (HttpURLConnection) -> Unit = {}): InputStream? {
with(URL(url).openConnection() as HttpURLConnection)
{
action(this)
return try {
inputStream
} catch (ex: Exception) {
Log.error("Exception during GitHub download", ex)
val reader = BufferedReader(InputStreamReader(errorStream))
Log.error("Message from GitHub: %s", reader.readText())
null
try {
// Problem type 1 - opening the URL connection
with(URL(url).openConnection() as HttpURLConnection)
{
action(this)
// Problem type 2 - getting the information
try {
return inputStream
} catch (ex: Exception) {
// No error handling, just log the message.
// NOTE that this 'read error stream' CAN ALSO fail, but will be caught by the big try/catch
val reader = BufferedReader(InputStreamReader(errorStream))
Log.error("Message from GitHub: %s", reader.readText())
throw ex
}
}
} catch (ex: Exception) {
Log.error("Exception during GitHub download", ex)
return null
}
}