mirrors/Unciv
1
0
Fork 0
mirror of https://github.com/yairm210/Unciv.git synced 2025-07-22 13:49:54 +07:00
Code Issues Packages Projects Releases Wiki Activity

Fixed preferred victory type ruleset validation - should NOT be invariant! (#11640)

Browse Source
This commit is contained in:
Yair Morgenstern
2024-05-23 06:59:15 +03:00
committed by GitHub
parent 4bbeece29e
commit 479bc3ec85
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/src/com/unciv/models/ruleset/validation/RulesetValidator.kt
View File

@ -270,6 +270,8 @@ class RulesetValidator(val ruleset: Ruleset) {
uniqueValidator.checkUniques(nation, lines, true, tryFixUnknownUniques)
if (nation.preferredVictoryType != Constants.neutralVictoryType && nation.preferredVictoryType !in ruleset.victories)
lines.add("${nation.name}'s preferredVictoryType is ${nation.preferredVictoryType} which does not exist!", sourceObject = nation)
if (nation.cityStateType != null && nation.cityStateType !in ruleset.cityStateTypes)
lines.add("${nation.name} is of city-state type ${nation.cityStateType} which does not exist!", sourceObject = nation)
if (nation.favoredReligion != null && nation.favoredReligion !in ruleset.religions)
@ -577,9 +579,6 @@ class RulesetValidator(val ruleset: Ruleset) {
lines.add("${nation.name} can settle cities, but has no city names!", sourceObject = nation)
}
if (nation.preferredVictoryType != Constants.neutralVictoryType && nation.preferredVictoryType !in ruleset.victories)
lines.add("${nation.name}'s preferredVictoryType is ${nation.preferredVictoryType} which does not exist!", sourceObject = nation)
// https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast
val constrastRatio = nation.getContrastRatio()
if (constrastRatio < 3) {