From 54df4ba0c071f2b01334c3fc4aba3406b38b2fbf Mon Sep 17 00:00:00 2001 From: Xander Lenstra <71121390+xlenstra@users.noreply.github.com> Date: Wed, 21 Jul 2021 23:37:54 +0200 Subject: [PATCH] Fixed a crash in badly defined mods (#4598) --- core/src/com/unciv/logic/civilization/CivilizationInfo.kt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/core/src/com/unciv/logic/civilization/CivilizationInfo.kt b/core/src/com/unciv/logic/civilization/CivilizationInfo.kt index 945ccbbcec..a042bac3e5 100644 --- a/core/src/com/unciv/logic/civilization/CivilizationInfo.kt +++ b/core/src/com/unciv/logic/civilization/CivilizationInfo.kt @@ -779,6 +779,8 @@ class CivilizationInfo { val givingCityState = getKnownCivs().filter { it.isCityState() && it.getAllyCiv() == civName}.random() var giftableUnits = gameInfo.ruleSet.units.values.filter { it.isGreatPerson() } if (!gameInfo.hasReligionEnabled()) giftableUnits = giftableUnits.filterNot { it.uniques.contains("Great Person - [Faith]")} + if (giftableUnits.isEmpty()) // For badly defined mods that don't have great people but do have the policy that makes city states grant them + return val giftedUnit = giftableUnits.random() val cities = NextTurnAutomation.getClosestCities(this, givingCityState) val placedUnit = placeUnitNearTile(cities.city1.location, giftedUnit.name)