mirrors/Unciv
1
0
Fork 0
mirror of https://github.com/yairm210/Unciv.git synced 2025-07-10 07:48:31 +07:00
Code Issues Packages Projects Releases Wiki Activity

Fix not translated notifications (#2715)

Browse Source 
* Translate notification strings before they are shown. Fixes #2703

* Respect translations from active mods for placeholder translations

* Revert translation call to avoid issues in multiplayer. Still works without it.
This commit is contained in:
Daniel Bälz
2020-06-24 22:58:16 +02:00
committed by GitHub
parent de03a727f6
commit 5753115c30
2 changed files with 29 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/src/com/unciv/testing/TranslationTests.kt
View File

@ -78,7 +78,7 @@ class TranslationTests {
val placeholders = placeholderPattern.findAll(translationEntry).map { it.value }.toList()
for (language in languages) {
for (placeholder in placeholders) {
val output = translations.get(translationEntry, language)
val output = translations.getText(translationEntry, language)
if (!output.contains(placeholder)) {
allTranslationsHaveCorrectPlaceholders = false
println("Placeholder `$placeholder` not found in `$language` for entry `$translationEntry`")