From 933e769d8ea900eaaf515bc58e8dbd8a40ee3768 Mon Sep 17 00:00:00 2001 From: Xander Lenstra <71121390+xlenstra@users.noreply.github.com> Date: Wed, 27 Apr 2022 08:15:33 +0200 Subject: [PATCH] Changed milestone build globally text to make it more understandable (#6613) * Changed milestone build globally text to make it more understandable * Actually this is probably just as clear, gramatically more correct and more imperative like the other milestones * Fixed tests * Reworded again --- android/assets/jsons/Civ V - Gods & Kings/VictoryTypes.json | 4 ++-- android/assets/jsons/Civ V - Vanilla/VictoryTypes.json | 4 ++-- core/src/com/unciv/models/ruleset/Victory.kt | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/android/assets/jsons/Civ V - Gods & Kings/VictoryTypes.json b/android/assets/jsons/Civ V - Gods & Kings/VictoryTypes.json index 454d7caf32..8897b4adee 100644 --- a/android/assets/jsons/Civ V - Gods & Kings/VictoryTypes.json +++ b/android/assets/jsons/Civ V - Gods & Kings/VictoryTypes.json @@ -27,8 +27,8 @@ }, { "name": "Diplomatic", - "hiddenInVictoryScreen": true, - "milestones": ["[United Nations] build globally", "Win diplomatic vote"], + "hiddenInVictoryScreen": false, + "milestones": ["Anyone should build [United Nations]", "Win diplomatic vote"], "victoryString": "You have triumphed over your foes through the art of diplomacy! Your cunning and wisdom have earned you great friends - and divided and sown confusion among your enemies! Forever will you be remembered as the leader who brought peace to this weary world!", "defeatString": "You have been defeated. Your civilization has been overwhelmed by its many foes. But your people do not despair, for they know that one day you shall return - and lead them forward to victory!" }, diff --git a/android/assets/jsons/Civ V - Vanilla/VictoryTypes.json b/android/assets/jsons/Civ V - Vanilla/VictoryTypes.json index 454d7caf32..8897b4adee 100644 --- a/android/assets/jsons/Civ V - Vanilla/VictoryTypes.json +++ b/android/assets/jsons/Civ V - Vanilla/VictoryTypes.json @@ -27,8 +27,8 @@ }, { "name": "Diplomatic", - "hiddenInVictoryScreen": true, - "milestones": ["[United Nations] build globally", "Win diplomatic vote"], + "hiddenInVictoryScreen": false, + "milestones": ["Anyone should build [United Nations]", "Win diplomatic vote"], "victoryString": "You have triumphed over your foes through the art of diplomacy! Your cunning and wisdom have earned you great friends - and divided and sown confusion among your enemies! Forever will you be remembered as the leader who brought peace to this weary world!", "defeatString": "You have been defeated. Your civilization has been overwhelmed by its many foes. But your people do not despair, for they know that one day you shall return - and lead them forward to victory!" }, diff --git a/core/src/com/unciv/models/ruleset/Victory.kt b/core/src/com/unciv/models/ruleset/Victory.kt index a12a98a4cb..379fee7161 100644 --- a/core/src/com/unciv/models/ruleset/Victory.kt +++ b/core/src/com/unciv/models/ruleset/Victory.kt @@ -13,7 +13,7 @@ import com.unciv.ui.utils.toTextButton enum class MilestoneType(val text: String) { BuiltBuilding("Build [building]"), - BuildingBuiltGlobally("[building] build globally"), + BuildingBuiltGlobally("Anyone should build [building]"), AddedSSPartsInCapital("Add all [comment] in capital"), DestroyAllPlayers("Destroy all players"), CaptureAllCapitals("Capture all capitals"),