mirror of
https://github.com/yairm210/Unciv.git
synced 2025-07-09 07:18:57 +07:00
Speedup of canPassThrough() method (#2394)
* Unit tests for "canPathThrough" * Refactoring of canEnterTiles() and isAtWarWith() * Do not check isEmpty() twice * Using of the cached MapUnit uniques
This commit is contained in:
Jack Rainy
238
tests/src/com/unciv/logic/map/UnitMovementAlgorithmsTests.kt
Normal file
238
tests/src/com/unciv/logic/map/UnitMovementAlgorithmsTests.kt
Normal file
@ -0,0 +1,238 @@
|
||||
// Taken from https://github.com/TomGrill/gdx-testing
|
||||
package com.unciv.logic.map
|
||||
|
||||
import com.unciv.Constants
|
||||
import com.unciv.logic.city.CityInfo
|
||||
import com.unciv.logic.civilization.CivilizationInfo
|
||||
import com.unciv.logic.civilization.diplomacy.DiplomacyManager
|
||||
import com.unciv.logic.civilization.diplomacy.DiplomaticStatus
|
||||
import com.unciv.models.ruleset.Nation
|
||||
import com.unciv.models.ruleset.Ruleset
|
||||
import com.unciv.models.ruleset.RulesetCache
|
||||
import com.unciv.models.ruleset.unit.BaseUnit
|
||||
import com.unciv.models.ruleset.unit.UnitType
|
||||
import com.unciv.testing.GdxTestRunner
|
||||
import org.junit.Assert
|
||||
import org.junit.Before
|
||||
import org.junit.Test
|
||||
import org.junit.runner.RunWith
|
||||
|
||||
@RunWith(GdxTestRunner::class)
|
||||
class UnitMovementAlgorithmsTests {
|
||||
|
||||
private var tile = TileInfo()
|
||||
private var civInfo = CivilizationInfo()
|
||||
private var ruleSet = Ruleset()
|
||||
private var unit = MapUnit()
|
||||
|
||||
@Before
|
||||
fun initTheWorld() {
|
||||
RulesetCache.loadRulesets()
|
||||
ruleSet = RulesetCache.getBaseRuleset()
|
||||
tile.ruleset = ruleSet
|
||||
civInfo.tech.techsResearched.addAll(ruleSet.technologies.keys)
|
||||
civInfo.tech.embarkedUnitsCanEnterOcean = true
|
||||
civInfo.tech.unitsCanEmbark = true
|
||||
civInfo.nation = Nation().apply {
|
||||
name = "My nation"
|
||||
cities = arrayListOf("The Capital")
|
||||
}
|
||||
unit.civInfo = civInfo
|
||||
}
|
||||
|
||||
@Test
|
||||
fun canPassThroughPassableTerrains() {
|
||||
for (terrain in ruleSet.terrains.values) {
|
||||
tile.baseTerrain = terrain.name
|
||||
tile.setTransients()
|
||||
|
||||
unit.baseUnit = BaseUnit().apply { unitType = UnitType.Melee }
|
||||
|
||||
Assert.assertTrue(terrain.name, terrain.impassable != unit.movement.canPassThrough(tile))
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun unitCanEnterTheCity() {
|
||||
val map = TileMap()
|
||||
tile.baseTerrain = Constants.hill
|
||||
tile.tileMap = map
|
||||
tile.setTransients()
|
||||
|
||||
val otherTile = tile.clone()
|
||||
otherTile.baseTerrain = Constants.coast
|
||||
otherTile.position.y = 1f
|
||||
|
||||
map.tileMatrix.add(arrayListOf(tile, otherTile))
|
||||
|
||||
val city = CityInfo()
|
||||
city.location = tile.position
|
||||
city.civInfo = civInfo
|
||||
tile.owningCity = city
|
||||
|
||||
for (type in UnitType.values())
|
||||
{
|
||||
unit.owner = civInfo.civName
|
||||
unit.baseUnit = BaseUnit().apply { unitType = type }
|
||||
Assert.assertTrue(type.name, unit.movement.canPassThrough(tile))
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun waterUnitCanNOTEnterLand() {
|
||||
for (terrain in ruleSet.terrains.values) {
|
||||
if (terrain.impassable) continue
|
||||
tile.baseTerrain = terrain.name
|
||||
tile.setTransients()
|
||||
|
||||
for (type in UnitType.values()) {
|
||||
if (type == UnitType.City) continue
|
||||
unit.baseUnit = BaseUnit().apply { unitType = type }
|
||||
Assert.assertTrue("%s cannot be at %s".format(type, terrain.name),
|
||||
(type.isWaterUnit() && tile.isLand) != unit.movement.canPassThrough(tile))
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun canNOTEnterIce() {
|
||||
tile.baseTerrain = Constants.ocean
|
||||
tile.terrainFeature = Constants.ice
|
||||
tile.setTransients()
|
||||
|
||||
for (type in UnitType.values()) {
|
||||
unit.baseUnit = BaseUnit().apply { unitType = type }
|
||||
|
||||
if (type == UnitType.WaterSubmarine) {
|
||||
unit.baseUnit.uniques.add("Can enter ice tiles")
|
||||
}
|
||||
unit.updateUniques()
|
||||
|
||||
Assert.assertTrue("$type cannot be in Ice",
|
||||
(type == UnitType.WaterSubmarine) == unit.movement.canPassThrough(tile))
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun canNOTEnterNaturalWonder() {
|
||||
tile.baseTerrain = Constants.plains
|
||||
tile.naturalWonder = "Wonder Thunder"
|
||||
tile.setTransients()
|
||||
|
||||
for (type in UnitType.values()) {
|
||||
unit.baseUnit = BaseUnit().apply { unitType = type }
|
||||
|
||||
Assert.assertFalse("$type must not enter Wonder tile", unit.movement.canPassThrough(tile))
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun canNOTEnterCoastUntilProperTechIsResearched() {
|
||||
|
||||
civInfo.tech.unitsCanEmbark = false
|
||||
|
||||
tile.baseTerrain = Constants.coast
|
||||
tile.setTransients()
|
||||
|
||||
for (type in UnitType.values()) {
|
||||
unit.baseUnit = BaseUnit().apply { unitType = type }
|
||||
|
||||
Assert.assertTrue("$type cannot be in Coast",
|
||||
unit.type.isLandUnit() != unit.movement.canPassThrough(tile))
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun canNOTEnterOceanUntilProperTechIsResearched() {
|
||||
|
||||
civInfo.tech.embarkedUnitsCanEnterOcean = false
|
||||
|
||||
tile.baseTerrain = Constants.ocean
|
||||
tile.setTransients()
|
||||
|
||||
for (type in UnitType.values()) {
|
||||
unit.baseUnit = BaseUnit().apply { unitType = type }
|
||||
|
||||
Assert.assertTrue("$type cannot be in Ocean",
|
||||
unit.type.isLandUnit() != unit.movement.canPassThrough(tile))
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun canNOTEnterOceanWithLimitations() {
|
||||
|
||||
tile.baseTerrain = Constants.ocean
|
||||
tile.setTransients()
|
||||
|
||||
for (type in UnitType.values()) {
|
||||
unit.baseUnit = BaseUnit().apply {
|
||||
unitType = type
|
||||
if (type == UnitType.Melee)
|
||||
uniques.add("Cannot enter ocean tiles")
|
||||
if (type == UnitType.Ranged)
|
||||
uniques.add("Cannot enter ocean tiles until Astronomy")
|
||||
}
|
||||
unit.updateUniques()
|
||||
|
||||
Assert.assertTrue("$type cannot be in Ocean",
|
||||
(type == UnitType.Melee) != unit.movement.canPassThrough(tile))
|
||||
|
||||
civInfo.tech.techsResearched.remove("Astronomy")
|
||||
|
||||
Assert.assertTrue("$type cannot be in Ocean until Astronomy",
|
||||
(type == UnitType.Melee ||
|
||||
type == UnitType.Ranged) != unit.movement.canPassThrough(tile))
|
||||
|
||||
civInfo.tech.techsResearched.add("Astronomy")
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun canNOTPassThroughTileWithEnemyUnits() {
|
||||
tile.baseTerrain = Constants.grassland
|
||||
tile.setTransients()
|
||||
|
||||
val otherCiv = CivilizationInfo()
|
||||
otherCiv.civName = "Barbarians" // they are always enemies
|
||||
otherCiv.nation = Nation().apply { name = "Barbarians" }
|
||||
val otherUnit = MapUnit()
|
||||
otherUnit.civInfo = otherCiv
|
||||
tile.militaryUnit = otherUnit
|
||||
|
||||
for (type in UnitType.values()) {
|
||||
unit.baseUnit = BaseUnit().apply { unitType = type }
|
||||
|
||||
Assert.assertFalse("$type must not enter occupied tile", unit.movement.canPassThrough(tile))
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
fun canNOTPassForeignTiles() {
|
||||
tile.baseTerrain = Constants.desert
|
||||
tile.setTransients()
|
||||
|
||||
val otherCiv = CivilizationInfo()
|
||||
otherCiv.civName = "Other civ"
|
||||
otherCiv.nation = Nation().apply { name = "Other nation" }
|
||||
|
||||
val city = CityInfo()
|
||||
city.location = tile.position.cpy().add(1f,1f)
|
||||
city.civInfo = otherCiv
|
||||
tile.owningCity = city
|
||||
|
||||
unit.baseUnit = BaseUnit().apply { unitType = UnitType.Melee }
|
||||
unit.owner = civInfo.civName
|
||||
|
||||
Assert.assertFalse("Unit must not enter other civ tile", unit.movement.canPassThrough(tile))
|
||||
|
||||
city.location = tile.position
|
||||
|
||||
Assert.assertFalse("Unit must not enter other civ city", unit.movement.canPassThrough(tile))
|
||||
|
||||
city.hasJustBeenConquered = true
|
||||
civInfo.diplomacy["Other civ"] = DiplomacyManager(otherCiv, "Other civ")
|
||||
civInfo.getDiplomacyManager(otherCiv).diplomaticStatus = DiplomaticStatus.War
|
||||
|
||||
Assert.assertTrue("Unit can capture other civ city", unit.movement.canPassThrough(tile))
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user