From f78fbfd22d422b251dcd737faeb11e34e7158a2f Mon Sep 17 00:00:00 2001 From: yairm210 Date: Mon, 16 Sep 2024 04:10:31 +0300 Subject: [PATCH] perf: minor speedup in distance to tiles --- core/src/com/unciv/logic/map/mapunit/movement/UnitMovement.kt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/src/com/unciv/logic/map/mapunit/movement/UnitMovement.kt b/core/src/com/unciv/logic/map/mapunit/movement/UnitMovement.kt index 26808a0f43..fc5cb73b00 100644 --- a/core/src/com/unciv/logic/map/mapunit/movement/UnitMovement.kt +++ b/core/src/com/unciv/logic/map/mapunit/movement/UnitMovement.kt @@ -69,7 +69,8 @@ class UnitMovement(val unit: MapUnit) { } } - if (!distanceToTiles.containsKey(neighbor) || distanceToTiles[neighbor]!!.totalDistance > totalDistanceToTile) { // this is the new best path + val currentBestPath = distanceToTiles[neighbor] + if (currentBestPath == null || currentBestPath.totalDistance > totalDistanceToTile) { // this is the new best path val usableMovement = if (includeOtherEscortUnit && unit.isEscorting()) minOf(unitMovement, unit.getOtherEscortUnit()!!.currentMovement) else unitMovement