mirrors/Unciv
1
0
Fork 0
mirror of https://github.com/yairm210/Unciv.git synced 2025-03-03 22:22:51 +07:00
Code Issues Packages Projects Releases Wiki Activity

Fixed the display of political relations (#8613)

Browse Source 
* Fixed the display of political relations

* Fixed remaining knows() calls
This commit is contained in:
Gualdimar 2023-02-07 21:56:34 +02:00 committed by GitHub
parent 138d61face
commit fab3da36e9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/com/unciv/logic/civilization/Civilization.kt
View File

@ -317,7 +317,7 @@ class Civilization : IsPartOfGameInfoSerialization {
/** Returns only undefeated civs, aka the ones we care about */
fun getKnownCivs() = diplomacy.values.map { it.otherCiv() }.filter { !it.isDefeated() }
fun knows(otherCivName: String) = diplomacy.containsKey(otherCivName)
fun knows(otherCivName: String) = (civName == otherCivName || diplomacy.containsKey(otherCivName))
fun knows(otherCiv: Civilization) = knows(otherCiv.civName)
fun getCapital() = cities.firstOrNull { it.isCapital() }

4
core/src/com/unciv/ui/overviewscreen/GlobalPoliticsOverviewTable.kt
View File

@ -168,7 +168,7 @@ class GlobalPoliticsOverviewTable (
}
private fun getCivName(otherciv: Civilization): String {
if (viewingPlayer.knows(otherciv) || otherciv.civName != viewingPlayer.civName) {
if (viewingPlayer.knows(otherciv)){
return otherciv.civName
}
return "an unknown civilization"
@ -179,7 +179,7 @@ class GlobalPoliticsOverviewTable (
// wars
for (otherCiv in civ.getKnownCivs()) {
if (!viewingPlayer.knows(otherCiv))
if (!viewingPlayer.knows(civ))
continue
if(civ.isAtWarWith(otherCiv)) {

4
core/src/com/unciv/ui/overviewscreen/ReligionOverviewTable.kt
View File

@ -89,7 +89,7 @@ class ReligionOverviewTab(
val existingReligions: List<Religion> = gameInfo.civilizations.mapNotNull { it.religionManager.religion }
for (religion in existingReligions) {
val image = if (religion.isPantheon()) {
if (viewingPlayer.knows(religion.foundingCivName) || viewingPlayer.civName == religion.foundingCivName)
if (viewingPlayer.knows(religion.foundingCivName))
ImageGetter.getNationPortrait(religion.getFounder().nation, 60f)
else
ImageGetter.getRandomNationPortrait(60f)
@ -136,7 +136,7 @@ class ReligionOverviewTab(
statsTable.add(religion.getReligionDisplayName().toLabel()).right().row()
statsTable.add("Founding Civ:".toLabel())
val foundingCivName =
if (viewingPlayer.knows(religion.foundingCivName) || viewingPlayer.civName == religion.foundingCivName)
if (viewingPlayer.knows(religion.foundingCivName))
religion.foundingCivName
else Constants.unknownNationName
statsTable.add(foundingCivName.toLabel()).right().row()

2
core/src/com/unciv/ui/trade/DiplomacyScreen.kt
View File

@ -217,7 +217,7 @@ class DiplomacyScreen(
var ally = otherCiv.getAllyCiv()
if (ally != null) {
val allyInfluence = otherCiv.getDiplomacyManager(ally).getInfluence().toInt()
if (!viewingCiv.knows(ally) && ally != viewingCiv.civName)
if (!viewingCiv.knows(ally))
ally = "Unknown civilization"
diplomacyTable
.add("Ally: [$ally] with [$allyInfluence] Influence".toLabel())