From fed54a4b0bf632beedf6ad8dced53f5f329be22f Mon Sep 17 00:00:00 2001 From: yairm210 Date: Wed, 14 Aug 2024 10:40:00 +0300 Subject: [PATCH] Object.entries() apparently had a breaking change Also updated setup-node to v4, latest --- .github/workflows/incrementVersionAndChangelog.mjs | 2 +- .github/workflows/uncivbot.yml | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/incrementVersionAndChangelog.mjs b/.github/workflows/incrementVersionAndChangelog.mjs index 27d9f3c818..0257200233 100644 --- a/.github/workflows/incrementVersionAndChangelog.mjs +++ b/.github/workflows/incrementVersionAndChangelog.mjs @@ -66,7 +66,7 @@ async function parseCommits() { } ); - Object.entries(ownerToCommits).forEach((author,commits) => { + Object.entries(ownerToCommits).forEach((author,index, commits) => { if (commits.length === 1) { commitSummary += "\n\n" + commits[0] + " - By " + author; } else { diff --git a/.github/workflows/uncivbot.yml b/.github/workflows/uncivbot.yml index dac6fee7dc..3773233331 100644 --- a/.github/workflows/uncivbot.yml +++ b/.github/workflows/uncivbot.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v4 - name: Generate new buildConfig.kt and changelog.md files run: | npm i @octokit/rest @@ -40,7 +40,7 @@ jobs: steps: - name: Merge Pull Request - uses: "actions/github-script@v5" + uses: actions/github-script@v5 with: github-token: ${{ secrets.ACTIONS_ACCESS_TOKEN }} # Required because default workflow token can't merge PRs script: | @@ -58,7 +58,7 @@ jobs: token: ${{ secrets.ACTIONS_ACCESS_TOKEN }} ref: master # By default will checkout *the version at time of trigger* which does *not* contain the PR we just merged! - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v4 - name: Increment version and release run: | @@ -76,7 +76,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v4 - name: Add translation PRs to the new branch, and PR the new branch to master # SO, the story is that when using the default access token you CANNOT merge PRs from forks.