Commit Graph

4029 Commits

Author SHA1 Message Date
b2557de5d0 Fixed a bug where every improvement pretended to be a citadel (#5563) 2021-10-26 08:31:39 +03:00
cbfbec166b Fixed a bug where great prophets gained through non-conventional means did not receive bonus spreads provided by wonders (#5558)
* Fixed a bug where great prophets gained through non-conventional means did not receive bonus spreads provided by wonders

* Fixed overextended indentation
2021-10-25 23:56:48 +03:00
5d9c1266d7 Fixed ruins having two faith bonuses that could apply at the same time (#5545)
* Fixed ruins having two faith bonuses that could apply at the same time

* Added turn restrictions on ruins
2021-10-25 19:09:39 +03:00
4c19347a89 Provide more information to waiting players in multiplayer (#5508)
* Add some very small Quality-of-Life improvements for multiplayer games

- GameInfo.kt
 - Add timestamp for the start of the last turn to save info, hopefully
   this will enable a multiplayer turn timer in the near future

- MultiplayerScreen.kt
 - Current turn indicator for multiplayer games now shows for how long it
   has been the current player's turn.

- WorldScreen.kt
 - Next Turn Action will display which player we are waiting for rather
   than the generic "Waiting for other players..."

* Update text for translations and add better elapsed times

template.properties
- Add translation templates for waiting turn information

German.properties
- Provide German translation for waiting turn info

Japanese.properties
- Provide Japanese translation for waiting turn info

MultiplayerScreen.kt
- Add translation brackets for waiting turn info
- Add a function which determines whether to represent
  elapsed time in Minutes, Hours, or Days (and does so)

WorldScreen.kt
- Add translation brackets for waiting turn info

* Fix line translated endings as per request

MultiplayerScreen.kt
- Translation for the "Last refresh:/Current Turn:" display no longer
  includes line endings
- "Last refresh:/Current Turn:" display now uses LF line endings only

* Show generic "Waiting for" message in single player

WorldScreen.kt
- Place an additional condition for getNextTurnAction which selects the
  generic "Waiting for" message in single player and the civ-specific
  one in multiplayer

Co-authored-by: Colin S. Vanden Heuvel <colin.vandenheuvel@wisc.edu>
2021-10-25 19:09:03 +03:00
6fdbc8a8da fix bug with contest quests (#5554) 2021-10-25 19:08:43 +03:00
741f2522b9 3.17.11 2021-10-24 20:54:39 +03:00
3681b45592 Fixed Siam's unique applying multiple times (#5547) 2021-10-24 20:48:14 +03:00
f474cf1516 Added missing unit type filter (#5548) 2021-10-24 20:47:47 +03:00
b66443574e Enumified all remaining resource & improvement uniques (#5523)
* Added conditionals & enumified improvement stat uniques

* Enumified all the other uniques

* Fixed bug where improvemen stat icons didn't show up in tech tree & reviews
2021-10-24 20:47:29 +03:00
e9d36ea0ce Fixed a bug where AI would not found religions (#5544) 2021-10-24 20:44:54 +03:00
074676c342 Fixed a bug where buying units with faith would not increase in cost (#5546) 2021-10-24 20:44:03 +03:00
6ac3547b8e City construction speedup with caching stats from tiles (#5536)
* City construction speedup with caching stats from tiles

* Reduced cityStats.update to only one cityConstructions.getStats() call, improving performance by another 30% approx
2021-10-24 09:05:05 +03:00
9a7ea263d6 Resolved #5530 - fixed "[stats] from all [stat] buildings" check for stat relatedness 2021-10-22 00:02:14 +03:00
9b798b3588 Inner Sea map type (#5535)
* Inner Sea map type

* space in templates
2021-10-21 23:51:24 +03:00
cb4aef7b35 Fixed tests 2 2021-10-20 23:26:01 +03:00
24f3e784fa Fixed tests 2021-10-20 23:18:03 +03:00
60f0724b42 Hardcore typing for uniques in how to improve city UI performance 2021-10-20 22:11:31 +03:00
dda2f6a37c Deprecation of old uniques 2021-10-20 21:35:13 +03:00
50225101ea Resolved #5494 using new overloads 2021-10-20 21:28:02 +03:00
13859e78c1 Unified and enumified production percentage bonus uniques (#5521) 2021-10-20 16:57:55 +03:00
ae8c72adbc Improvements fog of war (#5504)
* fog of war for improvements

* fix spectator mode

* unnecessary imports

* getShownImprovement
2021-10-20 16:42:15 +03:00
61085a515a Resolved #5473 - global uniques from buildings register correctly for units 2021-10-19 23:38:37 +03:00
960b2c2f1e WELP 2021-10-19 23:06:44 +03:00
b0b9ef04fd Resolved #5495 - Removed "matches" function with runtime-compliance checks entirely
All unique checks should be on load
2021-10-19 22:59:53 +03:00
96c69cf1e9 Made resource object lazy - this should speed up all sorts, especially tile stats checking 2021-10-19 22:08:35 +03:00
21925b920b Merge remote-tracking branch 'origin/master' 2021-10-19 21:25:57 +03:00
c708ebd7f0 Solved edge case where automated prophet couldn't head towards the city 2021-10-19 21:25:43 +03:00
0309e51afd Solved movement bug where extra tiles you could move through, but not *to*, would end up *adding* movememnt.
Movement bugs are hard. So hard, in fact, that most of this commit is just adding the "amount of movement left after attacking" so I could ensure that there wasn't a problem in the "calculating attackable tiles" part. The actual fix is in UnitMovementAlgorithms.
2021-10-19 21:16:16 +03:00
55bed3bf30 Merge remote-tracking branch 'origin/master' 2021-10-19 20:26:54 +03:00
61b6e40cdc Resolved #5520 - no tech icon errors from techs with era errors 2021-10-19 20:26:45 +03:00
8cd89deb71 Added information about technology required for improving resource to tile info. (#5509)
* Added information about technology required for improving resource to tile info.

* Tile improvement required tech info updated.
2021-10-19 19:47:35 +03:00
086867731d Enumified all terrain uniques in terrains.json (#5513)
* Enumified all terrain uniques in the json

* it

* Fixed unit tests
2021-10-19 08:27:46 +03:00
524dfa5364 Band-aided a bug with building unique application (#5512)
Building uniques applying to all cities, such as Temple of Artemis and Sistene Chapel would apply their bonus twice to the city they were build in.
This was a result of it both being found as a non-local unique due to it having an effect outside the city and thus being classified as wonder,
and as a building, as it was built in the city and had an effect on it.
This patch is _untested_ and only a band-aid.
The real solution would be to start using the sources of uniques saved in the uniques themselves to classify were uniques are received from.
Implementing this is somewhere on my todo-list, but due to uni won't happen anytime soon.
2021-10-18 16:37:18 +03:00
1b1a910eef Can now raze cities Austria has married (#5506) 2021-10-18 00:05:17 +03:00
4efc8b3195 Unbuildable works for units as well, as Deciv was quick to remind me 2021-10-17 23:55:47 +03:00
ca706db753 More typings for building specific uniques 2021-10-17 23:50:42 +03:00
d4205cb405 Typed "Unbuildable" 2021-10-17 23:42:09 +03:00
8b2bb8e59b Typed deprecated uniques so modders have warnings 2021-10-17 22:15:46 +03:00
1a1194236b Added overload to MapUnit.getMatchingUniques to get uniques from civ as well - see #5494 2021-10-17 21:16:14 +03:00
5c80e8ee9b Fixed bug where denmark's pillaging unique doesn't work (#5500) 2021-10-17 08:39:44 +03:00
ac422d25cb City State Barbarian Invasion and War with Major pseudo-quests (#5454)
* barbarian invasion event

* war with major pseudo-quest

* include latecomers

* diplomacy screen

* more notifications

* fixes

* reviews
2021-10-16 20:34:47 +03:00
551e6e1d54 Implemented holy warriors follower belief (#5411)
* Implemented holy warriors follower belief

* Minor fixes

* Likely fixed the tests

* Made someTroglodyte happy :)

* Removed stray println's

* Implemented requested changes
2021-10-16 20:25:38 +03:00
de0c1161f6 Music pause on "leave game" question, not world screen menu (#5491)
* Music pause on leave game question, not worldscreen menu

* Music pause on leave game question, not worldscreen menu - log back off
2021-10-16 20:06:25 +03:00
3c71fe41dc Fixes bug where culture gain from killing units no longer works (#5489) 2021-10-16 20:05:30 +03:00
24545a92dd Choose a better visible color for the religious symbol on the city button (#5485) 2021-10-14 23:38:35 +03:00
f1f2c1e932 3.17.8 2021-10-13 23:27:39 +03:00
67650fec00 Fixed a bug where "[+amount] population [in this city]" did not work (#5476) 2021-10-13 23:16:38 +03:00
ff67e66348 Free buildings part 2 - works for Carthage too (#5471)
* free buildings works for Carthage too
unify "provides a free [] []" and "gain a free [] []"

* re-check at start of turn

* reviews
2021-10-13 19:21:27 +03:00
734fba8f30 Fixed bugs with diplomatic victory (#5474) 2021-10-13 12:03:34 +03:00
56222a0ea7 Resolved #5453 - strength bonuses apply from civ bonuses as well 2021-10-12 19:49:12 +03:00