From bf02b8d171917229535a15c4251a07485b75c911 Mon Sep 17 00:00:00 2001
From: Vincent Pochet <vincent@getlago.com>
Date: Fri, 6 Sep 2024 11:19:39 +0200
Subject: [PATCH] fix: missing NANGO_SECRET_KEY warning (#398)

---
 docker-compose.dev.yml | 16 ++++++++--------
 docker-compose.yml     | 12 ++++++------
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/docker-compose.dev.yml b/docker-compose.dev.yml
index 65f1327..b821f94 100644
--- a/docker-compose.dev.yml
+++ b/docker-compose.dev.yml
@@ -70,7 +70,7 @@ services:
       - APP_DOMAIN=https://app.lago.dev
       - CODEGEN_API=https://api.lago.dev:3000
       - LAGO_DISABLE_SIGNUP=${LAGO_DISABLE_SIGNUP:-}
-      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY}
+      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY:-}
     labels:
       - "traefik.enable=true"
       - "traefik.http.routers.app.rule=Host(`app.lago.dev`)"
@@ -118,9 +118,9 @@ services:
       - LAGO_KAFKA_RAW_EVENTS_TOPIC=events-raw
       - LAGO_KAFKA_ENRICHED_EVENTS_TOPIC=events_enriched
       - LAGO_KAFKA_CLICKHOUSE_CONSUMER_GROUP=clickhouse
-      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY}
       - GOOGLE_AUTH_CLIENT_ID=${GOOGLE_AUTH_CLIENT_ID:-}
       - GOOGLE_AUTH_CLIENT_SECRET=${GOOGLE_AUTH_CLIENT_SECRET:-}
+      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY:-}
     labels:
       - "traefik.enable=true"
       - "traefik.http.routers.api_http.rule=Host(`api.lago.dev`)"
@@ -170,7 +170,7 @@ services:
       - LAGO_KAFKA_RAW_EVENTS_TOPIC=events-raw
       - LAGO_KAFKA_ENRICHED_EVENTS_TOPIC=events_enriched
       - LAGO_KAFKA_CLICKHOUSE_CONSUMER_GROUP=clickhouse
-      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY}
+      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY:-}
       - LAGO_LICENSE=${LAGO_LICENSE:-}
 
   api-events-worker:
@@ -209,7 +209,7 @@ services:
       - LAGO_KAFKA_RAW_EVENTS_TOPIC=events-raw
       - LAGO_KAFKA_ENRICHED_EVENTS_TOPIC=events_enriched
       - LAGO_KAFKA_CLICKHOUSE_CONSUMER_GROUP=clickhouse
-      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY}
+      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY:-}
       - LAGO_LICENSE=${LAGO_LICENSE:-}
 
   api-pdfs-worker:
@@ -218,7 +218,7 @@ services:
     depends_on:
       - api
     restart: unless-stopped
-    command: [ "./scripts/start.pdfs.worker.dev.sh" ]
+    command: ["./scripts/start.pdfs.worker.dev.sh"]
     build:
       context: ./api
       dockerfile: $LAGO_PATH/api/Dockerfile.dev
@@ -248,7 +248,7 @@ services:
       - LAGO_KAFKA_RAW_EVENTS_TOPIC=events-raw
       - LAGO_KAFKA_ENRICHED_EVENTS_TOPIC=events_enriched
       - LAGO_KAFKA_CLICKHOUSE_CONSUMER_GROUP=clickhouse
-      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY}
+      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY:-}
       - LAGO_LICENSE=${LAGO_LICENSE:-}
 
   api-clock:
@@ -280,7 +280,7 @@ services:
       - LAGO_KAFKA_RAW_EVENTS_TOPIC=events-raw
       - LAGO_KAFKA_ENRICHED_EVENTS_TOPIC=events_enriched
       - LAGO_KAFKA_CLICKHOUSE_CONSUMER_GROUP=clickhouse
-      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY}
+      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY:-}
       - LAGO_LICENSE=${LAGO_LICENSE:-}
 
   pdf:
@@ -364,7 +364,7 @@ services:
     container_name: lago_clickhouse_dev
     restart: unless-stopped
     hostname: clickhouse
-    user: '101:101'
+    user: "101:101"
     depends_on:
       - db
       - redpanda
diff --git a/docker-compose.yml b/docker-compose.yml
index 2c7acd6..bc9b220 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -77,9 +77,9 @@ services:
       - LAGO_DISABLE_WALLET_REFRESH=${LAGO_DISABLE_WALLET_REFRESH}
       - LAGO_OAUTH_PROXY_URL=https://proxy.getlago.com
       - LAGO_LICENSE=${LAGO_LICENSE:-}
-      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY}
       - GOOGLE_AUTH_CLIENT_ID=${GOOGLE_AUTH_CLIENT_ID:-}
       - GOOGLE_AUTH_CLIENT_SECRET=${GOOGLE_AUTH_CLIENT_SECRET:-}
+      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY:-}
       # - SIDEKIQ_EVENTS=true
       # - SIDEKIQ_PDFS=true
     volumes:
@@ -105,7 +105,7 @@ services:
       - LAGO_DISABLE_SIGNUP=${LAGO_DISABLE_SIGNUP:-false}
       - LAGO_OAUTH_PROXY_URL=https://proxy.getlago.com
       - SENTRY_DSN=${SENTRY_DSN_FRONT}
-      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY}
+      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY:-}
     ports:
       - ${FRONT_PORT:-80}:80
     #  - 443:443
@@ -168,7 +168,7 @@ services:
       - LAGO_REDIS_CACHE_PASSWORD=${LAGO_REDIS_CACHE_PASSWORD}
       - LAGO_DISABLE_SEGMENT=${LAGO_DISABLE_SEGMENT}
       - LAGO_DISABLE_WALLET_REFRESH=${LAGO_DISABLE_WALLET_REFRESH}
-      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY}
+      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY:-}
       - LAGO_LICENSE=${LAGO_LICENSE:-}
       # - SIDEKIQ_EVENTS=true
       # - SIDEKIQ_PDFS=true
@@ -214,7 +214,7 @@ services:
   #    - LAGO_REDIS_CACHE_PASSWORD=${LAGO_REDIS_CACHE_PASSWORD}
   #    - LAGO_DISABLE_SEGMENT=${LAGO_DISABLE_SEGMENT}
   #    - LAGO_DISABLE_WALLET_REFRESH=${LAGO_DISABLE_WALLET_REFRESH}
-  #    - NANGO_SECRET_KEY=${NANGO_SECRET_KEY}
+  #    - NANGO_SECRET_KEY=${NANGO_SECRET_KEY:-}
   #    - SIDEKIQ_EVENTS=true
   #    - LAGO_LICENSE=${LAGO_LICENSE:-}
 
@@ -257,7 +257,7 @@ services:
   #    - LAGO_REDIS_CACHE_PASSWORD=${LAGO_REDIS_CACHE_PASSWORD}
   #    - LAGO_DISABLE_SEGMENT=${LAGO_DISABLE_SEGMENT}
   #    - LAGO_DISABLE_WALLET_REFRESH=${LAGO_DISABLE_WALLET_REFRESH}
-  #    - NANGO_SECRET_KEY=${NANGO_SECRET_KEY}
+  #    - NANGO_SECRET_KEY=${NANGO_SECRET_KEY:-}
   #    - SIDEKIQ_PDFS=true
   #    - LAGO_LICENSE=${LAGO_LICENSE:-}
 
@@ -285,7 +285,7 @@ services:
       - ENCRYPTION_PRIMARY_KEY=${LAGO_ENCRYPTION_PRIMARY_KEY:-your-encryption-primary-key}
       - ENCRYPTION_DETERMINISTIC_KEY=${LAGO_ENCRYPTION_DETERMINISTIC_KEY:-your-encryption-deterministic-key}
       - ENCRYPTION_KEY_DERIVATION_SALT=${LAGO_ENCRYPTION_KEY_DERIVATION_SALT:-your-encryption-derivation-salt}
-      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY}
+      - NANGO_SECRET_KEY=${NANGO_SECRET_KEY:-}
       - LAGO_LICENSE=${LAGO_LICENSE:-}
 
   pdf: