mirrors/riiablo
1
0
Fork 0
mirror of https://github.com/collinsmith/riiablo.git synced 2025-07-08 14:57:30 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improved API

Browse Source 
writing 0 bits with _writeUnsigned is a no-op
write unsigned methods changed from byte and short to int types
added writeString(CharSequence,int,boolean) to write an optional null char
This commit is contained in:
Collin Smith
2020-08-14 00:08:07 -07:00
parent fda76aad7a
commit 886c24cdfd
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
core/src/com/riiablo/io/BitOutput.java
View File

@ -91,7 +91,7 @@ public class BitOutput {
void _writeUnsigned(long value, int bits) { void _writeUnsigned(long value, int bits) {
assert bits >= 0 : "bits(" + bits + ") < " + 0; assert bits >= 0 : "bits(" + bits + ") < " + 0;
assert bits < Long.SIZE : "bits(" + bits + ") > " + (Long.SIZE - 1); assert bits < Long.SIZE : "bits(" + bits + ") > " + (Long.SIZE - 1);
assert (value & ~MASKS[bits]) == 0 : "value(" + value + ") is larger than bits(" + bits + ")"; assert bits == 0 || (value & ~MASKS[bits]) == 0 : "value(" + value + ") is larger than bits(" + bits + ")";
_writeRaw(value, bits); _writeRaw(value, bits);
} }
@ -139,13 +139,13 @@ public class BitOutput {
return this; return this;
} }
public BitOutput write7u(byte value, int bits) { public BitOutput write7u(int value, int bits) {
BitConstraints.validate7u(bits); BitConstraints.validate7u(bits);
_writeUnsigned(value, bits); _writeUnsigned(value, bits);
return this; return this;
} }
public BitOutput write15u(short value, int bits) { public BitOutput write15u(int value, int bits) {
BitConstraints.validate15u(bits); BitConstraints.validate15u(bits);
_writeUnsigned(value, bits); _writeUnsigned(value, bits);
return this; return this;
@ -217,6 +217,10 @@ public class BitOutput {
} }
public BitOutput writeString(CharSequence chars, int bits) { public BitOutput writeString(CharSequence chars, int bits) {
return writeString(chars, bits, false);
}
public BitOutput writeString(CharSequence chars, int bits, boolean nullTerminated) {
BitConstraints.validateAscii(bits); BitConstraints.validateAscii(bits);
final int length = chars.length(); final int length = chars.length();
@ -226,6 +230,7 @@ public class BitOutput {
_writeRaw(c, bits); _writeRaw(c, bits);
} }
if (nullTerminated) _writeRaw('\0', bits);
return this; return this;
} }
} }