From 9d03f869ce9c7d33866b53050fa9c1ca8f0e1fbb Mon Sep 17 00:00:00 2001 From: Collin Smith Date: Thu, 17 Aug 2023 23:10:30 -0700 Subject: [PATCH] Added a couple documentation notes for plausible memory leak if asset manager does not work correctly --- core/src/main/java/com/riiablo/file/Dc6.java | 2 ++ core/src/main/java/com/riiablo/file/Dcc.java | 1 + 2 files changed, 3 insertions(+) diff --git a/core/src/main/java/com/riiablo/file/Dc6.java b/core/src/main/java/com/riiablo/file/Dc6.java index b4842203..d5c47bb1 100644 --- a/core/src/main/java/com/riiablo/file/Dc6.java +++ b/core/src/main/java/com/riiablo/file/Dc6.java @@ -123,6 +123,7 @@ public class Dc6 extends Dc { final Texture[] texture = direction.texture; if (combineFrames == 0 || (combineFrames == -1 && frame[0].width < Dc6.PAGE_SIZE)) { for (int f = 0; f < numFrames; f++) { + // FIXME: memory leak if called multiple times, asserted asset manger works correctly Texture t = texture[f] = new Texture(pixmap[f]); frame[f].texture.setRegion(t); pixmap[f].dispose(); @@ -145,6 +146,7 @@ public class Dc6 extends Dc { numPages = numFrames / (rows * columns); for (int p = 0, s = numPages, f = 0; p < s; p++) { int x = 0, y = 0; + // FIXME: memory leak if called multiple times, asserted asset manger works correctly Texture t = texture[p] = new Texture(width, height, INDEXED); frame[p].texture.setRegion(t); for (int r = 0; r < rows; r++, x = 0) { diff --git a/core/src/main/java/com/riiablo/file/Dcc.java b/core/src/main/java/com/riiablo/file/Dcc.java index 714f5707..e9bb9bf4 100644 --- a/core/src/main/java/com/riiablo/file/Dcc.java +++ b/core/src/main/java/com/riiablo/file/Dcc.java @@ -120,6 +120,7 @@ public final class Dcc extends Dc { final Pixmap[] pixmap = direction.pixmap; final Texture[] texture = direction.texture; for (int f = 0; f < numFrames; f++) { + // FIXME: memory leak if called multiple times, asserted asset manger works correctly Texture t = texture[f] = new Texture(pixmap[f]); frame[f].texture.setRegion(t); pixmap[f].dispose();