Yair Morgenstern
8d631254aa
Unified many implementations of common interfaces into abstract classes ( #5312 )
...
* Unified many implementations of common interfaces into abstract classes
* RulesetObject interface
2021-09-24 17:48:06 +03:00
yairm210
ed47f16c6e
Added modder warning for deprecated fields
2021-09-24 16:35:22 +03:00
SomeTroglodyte
c05bf0a2a6
Fix a Nation Picker crash ( #5311 )
2021-09-24 15:49:56 +03:00
Yair Morgenstern
12302deef6
Precursor to mod target check - ( #5303 )
...
* Precursor to mod target check -
Define acceptable targets for each unique holder
* Warn for bad unique targets, and divide between different types of beliefs
* Moved the belief type logic into the class, rather than being external
* Added comment that getUniqueTarget is currently unneeded, but planned for future use
2021-09-24 15:02:41 +03:00
SimonCeder
fa813f8f5e
Quests fixes and additions ( #5301 )
...
* enable all quests
* implement more quests
* weighting for quests
* global quests
* fixes
* fixes
* Update template.properties
* general string
* reviews
2021-09-24 10:05:30 +03:00
SomeTroglodyte
e9e0f2c55f
World and Natural Wonders Overview ( #5297 )
...
* World and Natural Wonders Overview
* World and Natural Wonders Overview - icon
* World and Natural Wonders Overview - groups and tuning
* World and Natural Wonders Overview - atlas
* World and Natural Wonders Overview - lint
2021-09-24 10:04:30 +03:00
SomeTroglodyte
8ef84d785e
Music controller - Fix pause ( #5307 )
2021-09-24 10:00:46 +03:00
yairm210
bae8bd2468
Mod error detection improvements!
...
Separated Warning vs Error, show "options only" warning in options only, color warnings by severity
2021-09-23 12:04:16 +03:00
SimonCeder
2e8934af17
Newly Allied city states declare war on your enemies, even unmet ones ( #5298 )
...
* new allies dow, unmet civs meet first and then dow
* no gifts for bad people
2021-09-23 11:31:36 +03:00
SomeTroglodyte
4a83bed4ba
Nation Picker visual help where to click ( #5287 )
...
* Nation Picker visual help where to click
* Nation Picker visual help where to click - circles
2021-09-23 11:23:40 +03:00
SomeTroglodyte
a5a8ea1338
Natural Wonders un-hardcoded ( #5279 )
...
* Natural Wonders un-hardcoded
* Natural Wonders un-hardcoded - oops testing change revert
* Natural Wonders un-hardcoded - tests OK
* Natural Wonders un-hardcoded - requests
* Natural Wonders un-hardcoded - hide from pedia
* Natural Wonders un-hardcoded - readable unique
2021-09-23 11:21:08 +03:00
SomeTroglodyte
8161da26de
Texture pack/load for mods also distributes by Images.*X* ( #5296 )
2021-09-22 22:11:39 +03:00
yairm210
66b0ddb25a
Mod error detection improvements!
...
Separated Warning vs Error, show "options only" warning in options only, color warnings by severity
2021-09-22 21:28:19 +03:00
SimonCeder
0bb565fdc6
Can't trade resources from other trades or city-states ( #5252 )
...
* can't trade resources from city-states
* display untradeable sources in trade screen
* Update template.properties
template string
* Update Swedish.properties
* Spelling, better buttons
2021-09-22 20:21:41 +03:00
yairm210
98f14523ed
Add all cityFilter strings from the 'source of truth', since many were missing from translation file
2021-09-22 19:47:31 +03:00
SomeTroglodyte
d1005327e7
Lint a few warnings and typos ( #5293 )
2021-09-22 19:32:25 +03:00
yairm210
5d6765a879
Resolved crash in unit civilopedia lines that depended on unitType being initialized
2021-09-22 18:32:16 +03:00
SomeTroglodyte
5e4aff90e9
Music controller with fade-over and mod capabilities. ( #5273 )
...
* Music controller with fade-over and mod capabilities.
- Preparation for music following game situations
- Minimal in-game hooks for now
- Already allows mods providing music, will play randomly
* Music controller - template
2021-09-22 09:35:33 +03:00
Xander Lenstra
b7467d3467
Added support for conditionals to some more uniques ( #5280 )
...
* Added support for conditionals to some more uniques
* Implemented a new conditional
* Added the new conditional to the translations file
* Fixed tests
* Implemented requested changes
2021-09-22 09:24:16 +03:00
Xander Lenstra
4343137b82
Save the sources of uniques with the uniques themselves ( #5281 )
2021-09-21 20:26:14 +03:00
Yair Morgenstern
05394f627d
Using reflection to find and report deprecated uniques ( #5276 )
...
* Using reflection to find and report deprecated uniques
* No kotlin reflection needed thank you very much
2021-09-21 20:26:05 +03:00
Xander Lenstra
7a59cbcbe8
Fixed bug where a unit auto-exploring ancient ruins would in some cases disappear after upgrading ( #5285 )
2021-09-21 20:18:02 +03:00
yairm210
eedfbe0235
Specify acceptable uses of this unique
...
Later we'll be able to check this in checkRuleset to warn against incorrect usages
2021-09-20 16:26:36 +03:00
Xander Lenstra
ce5a82c763
Fix translation tests and wrongly translated conditionals ( #5272 )
2021-09-20 16:04:51 +03:00
yairm210
bd7824cdb9
More UniqueType-ing, discovering an overlap this time
2021-09-19 21:33:26 +03:00
yairm210
5fc7d1ce46
Gain free building uniqueType'D
2021-09-19 21:18:56 +03:00
yairm210
bdefb7894c
cityInfo.getMAtchingUniques accepts uniqueType
2021-09-19 21:15:26 +03:00
yairm210
aee087ec01
tileResource unique fully replaceable by uniques
2021-09-19 20:58:17 +03:00
Xander Lenstra
f47f427b05
Adds conditionals to most of the uniques currently in the enum ( #5270 )
...
* Moved uniques to their own folder
* Added support for conditionals to most of the uniques in the current enum
* Deprecation > removal, of course
* Fixed tests & added `.removeConditionals` before checking for placeholders
2021-09-19 18:43:32 +03:00
Xander Lenstra
62e3dbe014
Moved uniques to their own folder ( #5269 )
2021-09-19 18:03:41 +03:00
Xander Lenstra
cb4feb29ed
Fixed a few bugs relating to earning great prophets ( #5267 )
...
* Fixed bug where great prophets gifted by city-states wouldn't have a religion
* Fixed bug where earning/buying great prophets whithout having founded a religion would result in great prophets of your pantheon, regardless of the religious state of the city
2021-09-19 17:56:38 +03:00
SimonCeder
027057874d
Update and generalize Siam UP ( #5237 )
...
* refactor and generalize Siam UP, display correct values in diplo screen
* enable preferred diplomatic victory
* allow compatibility mode
* revisions, restore timesInPlace
* don't change game.png
* don't change game.png
* objectify and enum city state bonuses
* objectify and enum city state bonuses
* template.properties
* refactored city state bonuses into Unique
* further enumization, fix toStringWithDecimals
* reviews
2021-09-19 06:28:10 +03:00
Xander Lenstra
ba679191f8
Fixed intercept chance being invertes ( #5259 )
...
Edit made on mobile and as such untested
2021-09-18 23:42:10 +03:00
SomeTroglodyte
ec0801ccef
Nation picker portraits ( #5250 )
...
* New game nation picker spruce-up
* New game nation picker spruce-up - Ctext icon control
2021-09-18 23:31:03 +03:00
Xander Lenstra
01bfd17594
Implementation of conditionals, but better than before ( #5187 )
...
* Implementation of conditionals, but better than before
* Updated the unique while I was at it
* Fixed bug where conditionals would never apply
* Capitalization
* Minor code cleaning
* Better documentation & variable names
* Changed translation strategy
* Added missing import?
2021-09-18 23:07:53 +03:00
SomeTroglodyte
8cff3fda49
Start preference Avoid shown with red X ( #5253 )
2021-09-18 23:05:14 +03:00
yairm210
81a12920df
Merge branch 'temp'
2021-09-18 23:03:00 +03:00
SimonCeder
803575665d
fix bug on capturing capital ( #5263 )
...
(cherry picked from commit 47d1a5c009
)
2021-09-18 23:02:04 +03:00
SimonCeder
8eb24ac273
Carthage civ ( #5224 )
...
* Add Carthage
* Implement uniques
* performance improvement, better elephant
* AI avoids taking too much damage from mountains
* more performance
* better AI
* can't settle cities on mountains
* AI improvement
* AI improvement
* revisions, damagePerTurn in Terrains.json
* terrain damage stored as unique in json, damage also works for terrain features
* don't change game.png
2021-09-18 20:28:12 +03:00
yairm210
7e05a56e37
Tile resource uniques now work to provide stat bonuses
2021-09-17 16:05:21 +03:00
yairm210
54ea0c89a8
Ruleset check finds errors in uniques of all kinds!
2021-09-17 14:47:03 +03:00
yairm210
fa462d830f
Use enum to generate parameter names when translating - more accurate than auto-detect by parameter name!
2021-09-17 14:10:40 +03:00
SimonCeder
c2fa1366bb
Add a fixed base strength to motivationToAttack ( #5248 )
2021-09-17 13:23:03 +03:00
yairm210
38231bf937
More reorg, first unique with cityFilter
2021-09-17 10:53:03 +03:00
yairm210
55a77096c1
Added city filter as parameter type, some reorg
2021-09-17 10:48:16 +03:00
yairm210
2f8de2d196
Added Stats as unique parameter type
2021-09-17 10:43:03 +03:00
yairm210
af9e691102
Ease of deprecation, brought to you by unique types!
...
*Visible*, locatable deprecated uniques!
Stated replacement uniques!
2021-09-17 10:33:53 +03:00
yairm210
1f05239275
Unit filtering actually comes in 2 flavors - one for "unit templates", BaseUnit, and one for "actual units in the field", MapUnit. This should be reflected in the parameter names.
2021-09-17 10:14:05 +03:00
yairm210
fa939e15d9
getMatchingUnique for UniqueType - will allow us to convert most of the uniques painlessly
2021-09-17 09:55:57 +03:00
Yair Morgenstern
34cb48aa31
Unique enum compliance detection ( #5226 )
...
* Added basic functionality for uniques enum
* Added unique type to Unique class for faster enum comparisons
* And Elvis operator for unknown parameter type
* Resolved #5162 - AI much less motivated to attack city-states
* Whoops, wrong branch
* New unique checks, with enum.
* Fixed Trog's comments
2021-09-17 09:35:01 +03:00