Commit Graph

4191 Commits

Author SHA1 Message Date
yairm210
a2f5941927 chore - Minor improvements to science and culture tutorial capitalization 2022-01-15 22:09:33 +02:00
Xander Lenstra
2986052397
Typed all tech uniques (#5967) 2022-01-14 17:44:53 +00:00
yairm210
8311e65120 Victory types capitalized 2022-01-14 12:21:53 +02:00
yairm210
e7042d24ea City state permutations normalized to "City-State"
#5963
2022-01-14 12:16:16 +02:00
yairm210
4dcb45408d Unique deprecation 2022-01-14 11:00:38 +02:00
Yair Morgenstern
6e95a07572
More unit unique typing (#5952)
* There are so many of these my gosh

* Fixed, good thing we have tests :)

* Fixed
2022-01-14 10:43:13 +02:00
Yair Morgenstern
398e7903ef
Resolved #5930 - removed extraneous stat icons + resolved sorting problem they caused in Civilopedia tutorials. (#5959) 2022-01-14 10:11:45 +02:00
Xander Lenstra
7cb58eb82d
Typed all policy uniques (#5955)
* Typed all policy uniques

* Reworded golden age length
2022-01-14 10:11:30 +02:00
Yair Morgenstern
826b8f4826
Handling for multiplayer download errors (#5958) 2022-01-14 10:09:10 +02:00
Yair Morgenstern
4cce74253d
Abstracted file storage from the multiplayer data retrieval - this should allow implementations of both #5866 and #2679 for other implementations of IFileStorage (#5960) 2022-01-13 16:33:21 +00:00
Xander Lenstra
74d3854e45
Very likely fixed a bug that occasionally placed hills on top of mountains (#5946) 2022-01-11 23:30:25 +00:00
Xander Lenstra
8b846f8087
Typed a few unit uniques (#5951)
* Typed a few unit uniques

* Fixed tests

* Actually implemented a unique type :)
2022-01-11 23:24:58 +00:00
Yair Morgenstern
4308ad44ed
Removed silly crash for unteneble mods, and a try/catch that due to changes no longer caught hat it should have. (#5950) 2022-01-11 23:17:41 +00:00
Xander Lenstra
d809f3a132
Made all the other constants determining the strength of cities moddable (#5940) 2022-01-10 13:55:22 -08:00
Xander Lenstra
93a109b082
Fixed a bug where citadels did not damage nearby units (#5941)
* Fixed a bug where citadels did not damage nearby units

* Fixed tests
2022-01-10 13:32:48 -08:00
Xander Lenstra
3e6a190ab4
Unit tests for uniques (#5945)
* Added a unit test file for uniques

* Added a few tests
2022-01-10 22:01:14 +02:00
yairm210
1999364b9e Chore - more typified unit uniques 2022-01-10 21:53:13 +02:00
yairm210
c6a9f6a857 Chore - typified unit uniques 2022-01-10 21:13:59 +02:00
Xander Lenstra
86f8dff39b
Fixed a crash when using conditionals in transient unit uniques (#5939) 2022-01-10 11:53:00 +02:00
Yair Morgenstern
598f39e567
Deprecation of requiredBuildingInAllCities (#5922)
* Deprecation of requiredBuildingInAllCities

* Should be a warning not an error
2022-01-09 21:40:47 +02:00
Xander Lenstra
fc287bd9f3
Added a way to add moddable constants (#5921)
* Added a way to add moddable constants to unciv

* Fixed xp from barbarians problem

* Maybe I should test my code before pushing
2022-01-09 21:40:41 +02:00
Yair Morgenstern
44b262ec52
Remove support for stat-named specialists (#5923) 2022-01-09 21:39:32 +02:00
Yair Morgenstern
513b37583f
Converted "Can construct [improvementName]" to a uniqueType (#5924) 2022-01-09 21:39:27 +02:00
Yair Morgenstern
5f5aca6780
Simplified conditional checks - where I felt it would make it more readable (#5927)
* Simplified conditional checks - where I felt it would make it more readable.

Also added checks to ensure that era exists when checking era.

* Now passes tests

* Simplified unit tile checks
2022-01-09 21:39:20 +02:00
Xander Lenstra
9639365fd8
Fixed 'cannot built on [strategic resource]' not working (#5933) 2022-01-09 21:39:07 +02:00
will-ca
24dfad696c
New crash handler screen Part 2: Threads, runnables, more informative reports. (#5810)
* Add crashHandlingThread.

* Replace all uses of `thread` with `crashHandlingThread`.

* Add `postCrashHandlingRunnable`.

* Replace all uses of `Gdx.app.postRunnable` with `postCrashHandlingRunnable`.

* Remove CrashController and CrashReport; Strip down CrashReportSender to CrashReportSysInfo; Fold their functionality into CrashScreen.

* Typo in comments, rename `SafeCrashStage` to `CrashHandlingStage`.

* Tweak docs.

* Tweak docs, comments, text. Undo an accidentally recursive Replace All change.

* Remove replaced translations.

* More readable indentation handling in report template.
2022-01-09 11:33:45 +02:00
Yair Morgenstern
5931853c37
Check parameter types of conditionals as well as the main unique (#5928) 2022-01-07 16:49:33 +00:00
Xander Lenstra
7f38118dd9
Expanded the buildingFilter to include options for national wonders (#5900)
* Expanded the buildingFilter to include options national wonders

* Also instruct the translation file writer on the changes

* Typo

* Non-national -> World
2022-01-07 13:41:53 +02:00
Xander Lenstra
c1a6e05da6
Disables '[cityState] is afraid of your military power' for spectators & other non-major civs (#5918)
* Disables '[cityState] is afraid of your military power' for spectators

* Do the same for a few other similar notifications

* And more, for patronage complete policy
2022-01-06 14:19:29 -08:00
Yair Morgenstern
45ee382fba
Resolved #5801 - detailed sources of battle modifiers (#5916) 2022-01-06 13:46:45 -08:00
Xander Lenstra
d6a99a7848
Fixed a bug where great improvements could not be repaired after being pillaged (#5913)
* Fixed a bug where great improvements could not be repaired

* Formatting
2022-01-06 13:29:59 -08:00
will-ca
a5bba8dfb0
Refactor pixel unit image resolving. (Includes ImageAttempter) (#5897)
* Add ImageAttempter for finding available from candidate images.

* Remove zero-arg ImageAttempter constructor.

* Refactor pixel unit image resolving.
2022-01-04 21:02:32 +01:00
will-ca
96beed4b3e
Add tileScale in TileSetConfig. (#5874)
* Add `tileScale` in `TileSetConfig`.

* Right, KDoc.
2022-01-04 10:18:13 -08:00
Yair Morgenstern
0e64ff5592
Performance improvements - inspired by ANR errors for this callstack (#5896) 2022-01-03 16:51:21 +00:00
Xander Lenstra
89d4c046d4
Added more yield icons to the city stats table (#5894)
* Added more yield icons to the city stats table

* Replaced icons with Font.icon
2022-01-02 17:50:27 +00:00
Xander Lenstra
cdbdda366b
Revamped nukes again to closer match the original (#5892) 2022-01-02 04:04:43 -08:00
Xander Lenstra
f06242ebe1
Allowed follower beliefs to have more uniques, merged a unique and globalized some uniques (#5882) 2021-12-31 13:47:52 +02:00
Xander Lenstra
687ecb83f1
Merged some uniques and added a new one for not allowing to build units (#5731)
* Print stacktraces in more cases when crashing, useful for debugging

* Conditionalized no oceans before astronomy unique

* Cannot be built on tile before tech conditionalized

* Added "Cannot build unitFilter units" unique

* Fixed tests failing

* Merge branch master into some-uniques

* Fixed typo

* Apparently I made the same mistake twice

* Globalized unique
2021-12-31 12:13:09 +02:00
Xander Lenstra
ee65adb5e4
Fixed a bug where all global unit discounts would always apply, despite only being for certain units (#5879) 2021-12-31 11:07:59 +02:00
Xander Lenstra
dcbb0df4f9
Typefied spaceship part unique (#5878)
* Typefied spaceship part unique

* Removed unused imports

* Ah right, spaceship parts are still buildings
2021-12-30 18:33:01 +02:00
will-ca
1a8a86cb2c
Unify and improve moddability of more tile-based images. (#5873) 2021-12-29 18:21:34 +02:00
yairm210
6b2778fd0a Merge remote-tracking branch 'origin/master' 2021-12-29 00:14:36 +02:00
yairm210
7a00ebe2ec Can no longer promote units with 0 movement by sneaking into the promotion screen from elsewhere 2021-12-29 00:13:09 +02:00
will-ca
0056eba408
Move BorderImages to tileset. Set origin in setHexagonImageSize(). (#5868) 2021-12-29 00:05:56 +02:00
yairm210
af22ede437 Better map-to-ruleset incompatibility checks 2021-12-28 23:42:06 +02:00
yairm210
2ea97edb92 Can now load maps with extra lines at the end, as found in some mods in the wild 2021-12-28 23:33:52 +02:00
yairm210
9266ddc5d0 Fixed rare bug where captured civilian disappears before you can return it 2021-12-28 23:16:54 +02:00
yairm210
bd70500685 Fixed bug in inquisitor automation 2021-12-28 23:10:44 +02:00
yairm210
f90b22ad60 Resolved #5188 - stat names also include the stat icon :) 2021-12-28 23:03:17 +02:00
yairm210
d418e572f8 Resolved #4354 - can no longer 'cheat' the unit overlay by e.g. automating a unit and then try and swap it with another unit 2021-12-28 22:49:46 +02:00