mirrors/riiablo
1
0
Fork 0
mirror of https://github.com/collinsmith/riiablo.git synced 2025-02-23 21:21:28 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

Added a couple documentation notes for plausible memory leak if asset manager does not work correctly

Browse Source
This commit is contained in:
Collin Smith 2023-08-17 23:10:30 -07:00
parent ec9ff67c80
commit 9d03f869ce
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/main/java/com/riiablo/file/Dc6.java
View File

@ -123,6 +123,7 @@ public class Dc6 extends Dc<Dc6.Dc6Direction> {
final Texture[] texture = direction.texture;
if (combineFrames == 0 || (combineFrames == -1 && frame[0].width < Dc6.PAGE_SIZE)) {
for (int f = 0; f < numFrames; f++) {
// FIXME: memory leak if called multiple times, asserted asset manger works correctly
Texture t = texture[f] = new Texture(pixmap[f]);
frame[f].texture.setRegion(t);
pixmap[f].dispose();
@ -145,6 +146,7 @@ public class Dc6 extends Dc<Dc6.Dc6Direction> {
numPages = numFrames / (rows * columns);
for (int p = 0, s = numPages, f = 0; p < s; p++) {
int x = 0, y = 0;
// FIXME: memory leak if called multiple times, asserted asset manger works correctly
Texture t = texture[p] = new Texture(width, height, INDEXED);
frame[p].texture.setRegion(t);
for (int r = 0; r < rows; r++, x = 0) {

1
core/src/main/java/com/riiablo/file/Dcc.java
View File

@ -120,6 +120,7 @@ public final class Dcc extends Dc<Dcc.DccDirection> {
final Pixmap[] pixmap = direction.pixmap;
final Texture[] texture = direction.texture;
for (int f = 0; f < numFrames; f++) {
// FIXME: memory leak if called multiple times, asserted asset manger works correctly
Texture t = texture[f] = new Texture(pixmap[f]);
frame[f].texture.setRegion(t);
pixmap[f].dispose();