mirrors/riiablo
1
0
Fork 0
mirror of https://github.com/collinsmith/riiablo.git synced 2025-01-29 00:50:12 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed CvarManager cleanup

Browse Source 
Fixed an issue where removing a Cvar from a CvarManager was not removing its state listener
This commit is contained in:
Collin Smith 2021-04-25 01:47:57 -07:00
parent bb5351646f
commit e550bdab55
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
core/src/main/java/com/riiablo/cvar/CvarManager.java
View File

@ -43,7 +43,10 @@ public class CvarManager implements Cvar.StateListener, Iterable<Cvar> {
if (cvar == null) return false;
String alias = cvar.ALIAS.toLowerCase();
Cvar queriedCvar = CVARS.get(alias);
return Objects.equals(queriedCvar, cvar) && CVARS.remove(alias) != null;
boolean removed = Objects.equals(queriedCvar, cvar)
&& CVARS.remove(alias) != null;
if (removed) queriedCvar.removeStateListener(this);
return removed;
}
@SuppressWarnings("unchecked")