Commit Graph

555 Commits

Author SHA1 Message Date
yairm210
1122195e14 Improvement Unique converted to trigger - "Gain control over [tileFilter] tiles in a [amount]-tile radius" 2024-07-29 11:57:20 +03:00
aaronjfeingold
34f614c54b
Correct spelling of 'Svannah' to 'Savannah' across project. (#12018) 2024-07-27 23:41:46 +03:00
Oskar Niesen
7d69945c57
Make AI difficulty changable (#11996)
* Added AIDifficultyLevel to the difficulty object

* Fixed difficulty levels not showing in the cyclopedia screen
2024-07-21 10:01:15 +03:00
SpacedOutChicken
81130a541e
Remove old "will be replaced by automated units" unique (#11932)
* Remove "will be replaced" old unique

* Update TileImprovements.json
2024-07-09 17:24:58 +03:00
SpacedOutChicken
aeea13bb71
Update uniques for withdrawing before melee combat (#11904)
* - Turn Privateer's unique ability into a promotion
- Add promotion to Privateer and Sea Beggar

* Update uniques for withdrawing before melee combat
2024-07-03 15:08:49 +03:00
yairm210
c42170a4b8 Fix base rulesets 2024-06-26 09:35:40 +03:00
yairm210
2093761e2d Resolved #11829 - "after [amount] turns" -> "after turn number [amount]" 2024-06-25 16:01:57 +03:00
Yair Morgenstern
79be14e291 Resolved #11082 - Added "Will not be replaced by automated units" unique 2024-06-17 23:12:50 +03:00
yairm210
c89b2666c9 Specific uniques to generic trigger: "upon expending a [mapUnitFilter] unit" 2024-06-10 17:35:23 +03:00
yairm210
5739afe173 Resolved #11643 - Mamalahoe Kawanai -> Kanawai Mamalahoe 2024-05-27 14:09:06 +03:00
SomeTroglodyte
c5df845611
Fix bug in ModConstants handling (#11645)
* Fix a few unhelpful mod checker warnings

* Fix a problems with ModConstants and unit tests for them

* Minor linting
2024-05-27 12:30:51 +03:00
yairm210
0aa70668cc Barbarian water units no longer pillage 2024-05-16 07:06:21 +03:00
Skekdog
50274a42ad
Corrected Coast yields to give 1 Food and 1 Gold (#11583)
* Coast also yields 1 Gold

* Coast also yields 1 Gold and 1 Food in Vanilla
2024-05-14 10:59:18 +03:00
yairm210
8bd8ed683f Fix deprecated conditionals, caught by new mod checker 2024-04-07 12:43:38 +03:00
PLynx
0caf0cb4fa
Add configurable natural wonder discovery stat bonuses (#11249)
* Added configurable natural wonder discovery stats

* Shortened the code

* Updated the base rulesets with new unique

* Updated the El Dorado unique

* Applied the suggestions

* Reintroduced the implementation for deprecated uniques

* Changed tile.naturalWonder to naturalWonder
2024-04-04 23:39:31 +03:00
Jeremy Woo
bd71ba683f
Fixed uniques of marble (#11353) 2024-03-25 23:20:22 +02:00
Caballero Arepa
b678f697a5
Remove comments of the terrain colors, and enhance tundra color (#11320)
* Vanilla Vanilla

* Remove terrain color comment

And improve tundra color
2024-03-17 23:12:50 +02:00
Jeremy Woo
928f0df01f
Added multi filter support for BuildingFilter !! (#11319)
* Fixed policies do not grant production bonus to wonders

* Added multi-filter and tech filter for buildingFilter

* Rectification of the uniques of monument to the gods and marbles

* Fixed mod checker issued warnings regarding the techFilter in Unit and Building Filters.

* Edit Unique-parameters.md

* Undo 'Fixed policies do not grant production bonus to Wonders
2024-03-17 23:12:40 +02:00
itanasi
e9c3350ec5
Expand CanOnlyBeBuiltInCertainCities to include Units and convert to use Conditionals (#11274)
* Remove Transform requirement checks

* Add back in requirement for OnlyAvailable
New BuildableOnly unique

* Instead of a new unique, expand CanOnlyBeBuiltInCertainCities to instead take conditionals

* Rename to notMetRejections and copy to BaseUnit
Add CanOnlyBeBuiltInSpecificCities to constructionRejectionReasonType

* Setup CanOnlyBeBuiltInCertainCities as depreciated (renamed CanOnlyBeBuiltInCertainCities_dep)

* Redirect Depreciation

* Quick Camel Case rename

* Function renaming and moving Unique to general Construction Uniques

* spelling

* Move Unique. Update Error message

* version
2024-03-13 23:12:10 +02:00
SeventhM
5730d1b80a
Conditional for building in amount of cities (#11101)
* Conditional for building in amount of cities

* fix order of operations

* Deprecate old require in amount cities uniques

* import

* Fix referring to the unique instead of the conditional

* Fix yield message

* I have no clue how this isn't imported, but I'mma assume this translates fine anyways

* Rename text for unique

* revert unique text

* Whoops

* Remove unnecessary puppet check

* Move additional description to it own function

* Split missing city text into its own function

* Move ToDo comment

* flip to be easier to read

* Move onlyAvailable rejections to its own function to be easier to work with

* Add in the word "of"
2024-02-17 21:41:05 +02:00
Yair Morgenstern
0be8fa8e39 Fixed unhappiness effect when at 0 happiness 2024-02-09 12:14:17 +02:00
SeventhM
cc8a0ab9eb
Fix build errors (#11000)
* Fix build errors

* [+30%]%

* Apparently I need to specify cities or units

* Screw it, add "vs [combatantFilter]"

* Accidental listing twice

* case
2024-01-25 09:05:08 +02:00
Ouaz
d69b458481
Add modified nation descriptions (#8261)
* Add modified nation descriptions

Original descriptions reworded and a bit shortened.

* Fix Greece description

* Add modified nation descriptions (vanilla)

* Improvements to Nation descriptions

Fixes and improvements by Yairm

* Improvements to Nations descriptions (vanilla)

Fixes and improvements by Yairm

* Improve startIntroPart2 for all nations

Also add fixes/improvements by Yairm.

* Improve startIntroPart2 for all nations (vanilla)

Also add fixes/improvements by Yairm.
2024-01-14 09:05:09 +02:00
SeventhM
665b5aa87c
Add unique to allow for generalized great generals (#10828)
* Add unique to allow for generalized great generals

* Don't add compatibility for rulesets with conditional generals

* Add to rulesets

* add in pre Kotlin 9 parenthesis

* whoops missed a parenthesis

* I guess pre Kotlin 9 parenthesis was unnecessary, whoops

* Add back old variables to clone function

* Move the list of all potential generals to Ruleset

* Move list of unit construction rejections to IConstruction

* flip !any{} to none{}

* Fix imports

* Typo
2024-01-04 09:03:14 +02:00
itanasi
ffd5fc62ed
Enable Domination to Capture All Capitals (#10769)
* Enable Domination to Capture All Capitals

* Update Text
2023-12-22 09:38:24 +02:00
Oskar Niesen
4282cdb626
Better Frigate and Ship of the Line sound (#10693)
* Added a frigate cannon fire volley sound with crashing

* Changed the frigate and ship of the line to use shipCannonVolley.mp3

* Added proper credits

* Renamed "Volly" to "Volley"
2023-12-10 22:59:12 +02:00
Caballero Arepa
88333a147e
Mention the Railroad production bonus in the Civilopedia (#10638)
* Mention Railroad production bonus in the Civilopedia

* Railroad production bonus mention in the Civilopedia - Vainilla

* Fix little style error

* Fix another mistake

omg

* Brackets

* Brackets
2023-12-03 22:13:04 +02:00
SeventhM
1744d1271f
Add gain stat modified by speed and improvement speed by filter uniques (#10443)
* Add gain stat modified by speed and improvement speed by filter uniques

* Fix rulesets

* Remove nonfunctional leftover resource text

* Reword improvement unqiue as suggested
2023-11-20 22:47:35 +02:00
Yair Morgenstern
dc6413d707 Modding: Added "non-[filter]" filtering for unit filters
Cleaned up unit filter validations to match actual filters
2023-11-18 22:16:43 +02:00
SomeTroglodyte
2847f7a8c1
Rivers... Moddable Stats and Civilopedia (#10424)
* River yields moddable and Civilopedia entry

* Improve text and better fresh water explanations

* Map editor exclusion as Unique, for River and previously hardcoded Improvements

* Map editor brush to Civilopedia link, starting locations cleaned

* Some SeventhM input applied

* Reword River/Lakes/Oasis civilopediaText and comments again
2023-11-13 22:18:25 +02:00
SomeTroglodyte
1f6e27421b
Remove obsolete filtering Unique declaration (#10435) 2023-11-05 20:15:45 +02:00
SomeTroglodyte
bd7db9b21a
Move Future Tech so Nanotechnology isn't covered by lines in Vanilla (not G&K) (#10359) 2023-10-26 08:47:16 +03:00
SomeTroglodyte
815df1bcc4
Some religion stuff (#10242)
* Enable HiddenWithoutReligion to work directly on a Tutorial

* Remove religious units from Vanilla

* Fix limited uses of Missionary and Prophet
2023-10-05 10:23:25 +03:00
Yair Morgenstern
ffc3a66707 Converted "May enhance a religion" unique to a UnitAction 2023-10-01 12:11:52 +03:00
Yair Morgenstern
6dbf240899 Converted "May found a religion" unique to a UnitAction 2023-10-01 12:01:54 +03:00
Yair Morgenstern
6d6dc51bea
Get rid of old religion style actions!!! (#10192)
* Giant refactoring - get rid of old religion style actions!!!

* Added special promotion to replace Great Mosque of Djenne ability

* removed double promotion added my mistake

* Added AI recognition of cities with bonus spread religion charges

* Added "disallowed for pantheon" filtering to new unit actions

* merge unit action changes with religion action changes

* Use new invokeUnitAction function for simplicity

* revert inquisitor unique change used for tests

* separate modifier side effects from old-style side effects

* Use canUSe shorthand for clarity
2023-10-01 09:43:26 +03:00
Yair Morgenstern
fc02ac8825 Added nations json schema 2023-09-24 11:55:54 +03:00
SpacedOutChicken
9e1ea2d4cb
Remove Faith bonus from Vanilla Siam (#10141)
* Destroy Arsenal when city is captured

* Remove unused Faith bonus from Siam unique
2023-09-18 08:21:27 +03:00
Yair Morgenstern
55809c9b22 Unique deprecation - "Receive free [unit] when you discover [tech]" replaced with trigger + condition, tested 2023-09-13 11:11:37 +03:00
Oskar Niesen
548b536818
Add Defensive pact (#9900)
* Defensive Pacts can now be offered.

* Signing a defensive pact now makes the Civs join all defensive wars. Any future defensive wars will force the other civ to join.

* Removed Popup Alert Defensive Pact.

* Defensive pact and Research pact now are only on the trade screen.

* AI now offers defensive pacts.

* Added AI evaluating sending and receiving Defensive Pact offers.

* Reverted some temporary changes

* Reduced the chance an AI offers a defensive pact

* Starting an offensive war now cancels all Defensive Pacts with other civilisations.

* Removed extra requirements before an AI will sign or offer a defensive pact.

* Added Defensive Pacts to the Civilopedia.

* Fixed the AI counter offering with treaties.

* Fixed a test using the old method of checking if a civ is at war.

* Fixed a previous refactor error.

* Deleted commented out Research Agreement button code.

* Fixed some spelling errors and remnant debugging code.

* Removed signing a defensive pact brings both Civ's into each others previous defensive wars.

* Refactored setFriendshipBasedModifier to look better

* Starting an offensive war now removes the defensive pact form both sides.

* Reverted changes to DiplomaticStatus

* Removed extra technology check to sign a defensive pact.

* Removed DiplomacyManager.isAtWar() completely.

* Moved setting defensivePact flags from  TradeLogic.transferTrade() to DiplomacyManager.signDefensivePact.

* Changed diplomatic modifiers related to Defensive Pacts to be less extreme.

* Fixed canceling Defensive Pacts when declaring war and notifying other Civs.

* Updated the Defensive Pact entry in the Civilopedia and fixed some spelling.

* Fixed Defensive Pact behavior while attacking and defending.

* Changed a variable to a more readable name.

* Improved readability of setFriendshipBasedModifier().

* Moved the important onWarDeclared functionality to their own functions.

* Added a notification for the attacking Civ when a Civ joins war through a Defensive Pact.

* Refactored setDefensivePactBasedModifier() to be more readable.

* Increased DeclinedDefensivePact time.

* Deleted old commented code that removed the research agreement button.

* Fixed having reverting changes errors in UnitMovementTests.

* Refactored breaking treaties when declaring war.

* Removed unnecessary semicolons.
2023-08-16 17:59:41 +03:00
Yair Morgenstern
34fbe9e9a2 AI: Better policy selection 2023-08-10 16:20:01 +03:00
SomeTroglodyte
bcb26b6d2a
Treat remaining untyped Uniques in default rulesets (#9763)
* Treat remaining untyped Uniques in default rulesets, make unit test catch them

* Change untyped filtering Uniques check to Validation by inclusion in GlobalUniques instead of UniqueType.AircraftMarker

* Wiki for untyped filtering Uniques

* Re-include the "Who knows" of Future Tech on the Tech picker
2023-08-03 11:38:50 +03:00
Lena Bullens
c3897fde07
Correct declaringWar key / English translation (#9838)
* Update Nations.json

* Update Nations.json
2023-07-24 10:42:44 +03:00
Yair Morgenstern
19bf15558d Fixed India's 'double unhappiness' unique 2023-07-05 21:10:22 +03:00
Yair Morgenstern
947a1001c4 Resolves #9703 - AI only buys tiles contiguous to the current city tiles (was: contiguous to civ tiles) 2023-06-30 15:13:14 +03:00
Xander Lenstra
aa0fb9ed8b
More unit unique tests (#9639) 2023-06-25 09:35:31 +03:00
SeventhM
bc3f1341e1
Tech column validation and removing crashes from undefined building costs (#9664)
* Add in tech column validation

* Negative Columns

* Forgot to add techColumns to the add and clear functiond

* Remove restrictive cokumn check

* bugfixing
2023-06-25 09:34:23 +03:00
Yair Morgenstern
a370117301 Resolved #9036 - New Kremlin quote 2023-05-04 10:47:00 +03:00
Yair Morgenstern
2f25ed3053 Replaced hardcoded embarked sight with configurable
"Normal vision when embarked" replaced by "[+1] Sight <for [Embarked] units>"
2023-04-19 11:12:21 +03:00
Yair Morgenstern
bc5e486b20 Resolves #9186
Atilla's Court -> Attila's Court, Guten tag -> Guten Tag
2023-04-15 21:00:17 +03:00