Commit Graph

9147 Commits

Author SHA1 Message Date
Yair Morgenstern
7b778f7535 Moved changeImprovement to TileInfoImprovementFunctions 2023-08-08 22:06:25 +03:00
Yair Morgenstern
3cbd447620 Removed HandleImprovementCompletion function, added test for citadel tile takeover 2023-08-08 22:00:18 +03:00
Yair Morgenstern
08c8bcf383 Removed double lines between handleImprovementCompletion and changeImprovement 2023-08-08 20:25:12 +03:00
Yair Morgenstern
417b6ff798 removeImprovement convenience function 2023-08-08 19:29:33 +03:00
Yair Morgenstern
55b4191be3 changeImprovement now contains 'terrain feature removal' logic 2023-08-08 19:25:51 +03:00
Yair Morgenstern
545ff0b944 Resolved #9887 - Improvement picker screen does not cause 'phantom' units to be assigned to civ 2023-08-04 13:35:41 +03:00
Yair Morgenstern
915238ed1a #9886 - Set initial screen color on Desktop so it's not black-to-blue 2023-08-04 09:52:08 +03:00
Yair Morgenstern
af49e8297f #9876 fix - Lock known city states before gaining influence to avoid altering the sequence we're iterating on 2023-08-04 09:29:34 +03:00
Yair Morgenstern
d9ceb9290d 4.7.12-patch1 2023-08-04 09:21:51 +03:00
Yair Morgenstern
6d65d08974 4.7.12 2023-08-03 14:08:01 +03:00
Yair Morgenstern
5956f0ceb6 4.7.12 2023-08-03 13:17:31 +03:00
Yair Morgenstern
e49fda3b97
Version rollout (#9880)
* Bump version and create initial changelog entry

* Update Simplified_Chinese (#9879)

* Update Spanish.properties (#9877)

* Update Polish.properties (#9875)

* Update Brazilian_Portuguese.properties (#9867)

* Update German.properties (#9864)

* Update German.properties

Fixed a few mistakes and added more translations

* Fixed a few mistakes in German translation

---------

Co-authored-by: Birk Birkner <birkner@bbirkner.de>

* Update French.properties (#9862)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: chr_56 <30681738+chr56@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Knirps1 <52383078+Knirps1@users.noreply.github.com>
Co-authored-by: Birk Birkner <birkner@bbirkner.de>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
2023-08-03 13:05:13 +03:00
Yair Morgenstern
c92afe0f04
Compare improvements by tile yield calculation (#9873)
* Compare improvements by tile yield calculation

* Docstring

* Explicit documentation for which functions in Stats are and are not mutating functions
2023-08-03 11:39:04 +03:00
SomeTroglodyte
bcb26b6d2a
Treat remaining untyped Uniques in default rulesets (#9763)
* Treat remaining untyped Uniques in default rulesets, make unit test catch them

* Change untyped filtering Uniques check to Validation by inclusion in GlobalUniques instead of UniqueType.AircraftMarker

* Wiki for untyped filtering Uniques

* Re-include the "Who knows" of Future Tech on the Tech picker
2023-08-03 11:38:50 +03:00
Yair Morgenstern
fc40da11d9
Added tests to ensure that resources from buildings behave as expected (#9860)
* Added tests to ensure that resources from buildings behave as expected

* More tests suggested by @SeventhM

* Caught an edge case - if you pillage your own tile improvement, your resources would not have updated!

* Actually every time an improvement changes you could have a resource change

* Update resources eon every improvement change because they could be providing resources via uniques
2023-08-03 11:38:36 +03:00
Oskar Niesen
15bfaa24a5
Transported units gifting fix (#9865)
* Gifting units containing transported units now gifts the transported units as well.

* Change transported units so that they can't be gifted.
2023-08-03 11:38:25 +03:00
SeventhM
0fe584700b
Allow free unit triggers for any location (#9870)
* Allow free unit triggers for any location

* Almost forgot this was broken

* Fix situation when tile is null, but therebis a city to place at
2023-08-03 11:38:14 +03:00
Yair Morgenstern
fdc891dada
Update README.md
Removed old download badges
2023-08-02 23:30:41 +03:00
Yair Morgenstern
5e7f49dac8 Resolved #9874 - free buildings are converted to civ-specific replacements 2023-08-02 16:01:21 +03:00
Yair Morgenstern
bbf2f2ff89 Resolve #9854 - update Windows JDK to Adoptium JDK 11 2023-08-02 15:50:55 +03:00
Yair Morgenstern
8de47b4a62 Resolved #9871
Workers now remove fallout and similar stat-hindering terrains
2023-08-02 11:47:12 +03:00
SomeTroglodyte
ad75ad916b
Move Mod Manager to prepare class splits (#9863) 2023-07-31 21:54:55 +03:00
Yair Morgenstern
15577cb3c5 double-click on worked tile icon locks tile, for worked tiles as well! 2023-07-31 11:17:23 +03:00
Yair Morgenstern
19f0cadb1e Steam deploy is failing, and it's not in use anyway, time to say goodbye 2023-07-30 23:31:48 +03:00
Yair Morgenstern
1b410278ab 4.7.11 2023-07-30 18:19:28 +03:00
Yair Morgenstern
b89611c953
Version rollout (#9859)
* Bump version and create initial changelog entry

* Update Dutch.properties (#9846)

* Update Dutch.properties

* Update Dutch.properties

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Lena Bullens <95299589+LenaBullens@users.noreply.github.com>
2023-07-30 18:12:16 +03:00
SomeTroglodyte
52e756e9fb
Key bindings CityScreen (#9828)
* CityScreen keyboard bindings - ExpanderTab update

* CityScreen keyboard bindings - Linting

* CityScreen keyboard bindings - Main Keys

* CityScreen keyboard bindings - Queue

* CityScreen keyboard bindings - Fix Expander scroll-to
2023-07-30 17:40:05 +03:00
SomeTroglodyte
a5e1f6d800
Local mod folder names preserved. (#9844)
* Reduce conversion of local mod folder names to treat only ending spaces/dashes

* Wiki entry for GlobalUniques

* Missing originRuleset coverage

* Nicer RulesetValidator messages when name or originRuleset are missing
2023-07-30 17:39:50 +03:00
SeventhM
203ee77c8b
Clean up some differences between units that can move on water and other units (#9841)
* Clean up some differences between units that can move on water, water units, and land units

* Strangely no evidence this actually comes up?

* refernce the cache in more places

* Decided to change this back to match expected results

* Remove unnecessary parenthesis
2023-07-30 17:39:41 +03:00
SomeTroglodyte
b838d8ec5a
Overhaul NUKE code to behave closer to original (#9797)
* Overhaul NUKE code to behave closer to original

* Separate garrison protection of Bomb Shelter to its own Unique

* Reduce code duplication: getNukeBlastRadius

* Disallow nuking unknown civs

* Don't show Nuke attack table when the Nuke has just been selected

* World map display of nuke blast radius and friendly fire
2023-07-30 17:39:28 +03:00
SomeTroglodyte
443bf3afdb
Local mod folder names preserved. (#9844)
* Reduce conversion of local mod folder names to treat only ending spaces/dashes

* Wiki entry for GlobalUniques

* Missing originRuleset coverage

* Nicer RulesetValidator messages when name or originRuleset are missing
2023-07-30 17:38:33 +03:00
SomeTroglodyte
b992144ecd
Fix a few now flagged but working Unique targets (#9845)
* Allow a few working UniqueType-UniqueTarget combos in RulesetValidator

* RulesetValidator checks GlobalUniques

* Alternate Settlers and Workers recognized via Unique - same rules in RulesetValidator and GameStarter, wiki clarification
2023-07-30 17:38:26 +03:00
SeventhM
ae7ac6a063
Fix resources subtracting in an incorrect manner when they have the same source (#9858) 2023-07-30 17:38:00 +03:00
SomeTroglodyte
bb7c75840e
Simple Originating-Mod display in Civilopedia (#9850)
* Simple Originating-Mod display in Civilopedia

* Simple Originating-Mod display in Civilopedia - patch
2023-07-30 17:37:50 +03:00
Oskar Niesen
df7fd27b94
Spectator can now see all invisible units including submarines without fog of war. (#9852) 2023-07-30 17:37:36 +03:00
SeventhM
283edd0875
Fix free buildings from other buildings not showing up correctly (#9857)
* Rearrange order of actions when adding buildings

* Turns out you need to updateCivResources after adding in uniques. Whoops

* Mirror change to remove buildings as well
2023-07-30 17:37:24 +03:00
itanasi
488ec9f82f
Fix logic in Fog Busting (#9855) 2023-07-30 17:36:38 +03:00
itanasi
73e06a114f
Update SDK Platforms text. Update photos (#9848)
* Update SDK Platforms text. Update photos

* Try to fix link for Markdown Screenshots

* Revert to docs link

* Try Unciv in file path
2023-07-29 23:12:16 +03:00
alexban011
5f8c675512
Fix linting warnings (#9701)
* fix: VariableNaming warnings

* fix: MatchingDeclarationName warnings

* fix: SwallowedException warnings

* fix: UseRequire warnings

* Revert "fix: MatchingDeclarationName warnings"

This reverts commit 9475af5052.
2023-07-26 07:30:14 +03:00
Yair Morgenstern
3c76e2bc64 4.7.10 2023-07-24 11:28:47 +03:00
Yair Morgenstern
b2d87c4a3e Replace fixed text in translations as well 2023-07-24 10:52:16 +03:00
Yair Morgenstern
48ad5780d9
Version rollout (#9843)
* Bump version and create initial changelog entry

* Update Simplified_Chinese.properties (#9835)

* more Persian UN Translation (#9832)

* Update Persian_(Pinglish-UN).properties

Added and fixed some of the translations till line 1039.

* Update Persian_(Pinglish-UN).properties

- Fixed a few till 1039.
- Added and fixed some from 1039 till 1254.

* Update Persian_(Pinglish-UN).properties

Added and fixed some till 5000

* Update Persian_(Pinglish-UN).properties

* Update Persian_(Pinglish-UN).properties

* Update Dutch.properties (#9816)

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

* Updated Brazilian_Portuguese.properties (#9813)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: AutumnPizazz <114050365+AutumnPizazz@users.noreply.github.com>
Co-authored-by: Ilia <81512402+ilia-abbasi@users.noreply.github.com>
Co-authored-by: Lena Bullens <95299589+LenaBullens@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
2023-07-24 10:51:13 +03:00
Lena Bullens
c3897fde07
Correct declaringWar key / English translation (#9838)
* Update Nations.json

* Update Nations.json
2023-07-24 10:42:44 +03:00
Oskar Niesen
6dcad3add5
Fixed automated workers not replacing forts for AI civ. (#9837)
* Fixed automated workers not replacing forts for AI civ.

* Fixed double parenthesis.

* Removed repeat removing fort in progress code.

* Improved evaluateFortPlacement
2023-07-24 10:42:18 +03:00
Tali Ondo
0ca4d3ef44
Fixed word typo in README.md (#9842)
"non-existant" -> "non-existent"
2023-07-24 10:41:46 +03:00
Yair Morgenstern
2d499703d7 Resolved #9840 - targetSdk set to 33
Due to the upcoming Google Play deadline (see https://support.google.com/googleplay/android-developer/answer/11926878)
We're upgrading the target SDK and build tools for Unciv.

What this means for you, is that you need to download BOTH the new Android SDK AND the new build tools to compile to Android
If you're only doing Desktop development, this will not affect you

In Android Studio:
- Double-click shift (for search)
- "SDK manager"
- Go to SDK platforms tab, select Android 13 (Tiramisu) - this will lead to an SDK download
- Go to the SDK Tools tab
- Click 'show package details' at bottom-right
- Click 33.0.2 - this will lead to a Build Tools download
2023-07-24 10:41:08 +03:00
SeventhM
eb17398d78
Modernize Connection Tests (#9831) 2023-07-23 08:18:39 +03:00
Yair Morgenstern
97b80973d1 More BaseUnit unique-finding including type uniques 2023-07-21 15:18:39 +03:00
Yair Morgenstern
bc9b5615eb BaseUnit unique-finding always takes Type uniques into account 2023-07-21 15:09:14 +03:00
Yair Morgenstern
33ae13479d 4.7.9-patch1 2023-07-20 09:24:41 +03:00