Commit Graph

9560 Commits

Author SHA1 Message Date
SomeTroglodyte
08c3f97f82
Support for Leader voices (#10395)
* Prepare Leader Voices: Framework

* Leader Voices: Hooks and corresponding text field comments

* Leader Voices: wiki

* Leader Voices: oops, comments

* Decouple voice play calls to make global modification easier

* Move voices to own folder and give them a separate volume setting

* Oops, template needed too

* Oops, wiki needed too
2023-11-20 22:21:30 +02:00
Yair Morgenstern
450813fa49 Settlers no longer stuck in endless loops wanting to found cities on tiles they can't reach @tuvus 2023-11-20 22:17:38 +02:00
SomeTroglodyte
987f67d9cd
[code quality] Reorg, clean up and comment a few things (#10527)
* UncivGame is a pure class file again, GUI split off

* Purify GameSettings step 1 - non-multiplayer nested classes

* Purify GameSettings step 2 - multiplayer nested classes

* Purify GameParameters - BaseRuleset to own file

* Rework WindowState to centralize minimum/maximum treatment

* Rename MultiplayerTurnNotifierDesktop to UncivWindowListener

* Clarifications on what the WindowListener actually does (and now the attention-getting does something on non-Windows too)
2023-11-19 23:52:15 +02:00
Yair Morgenstern
7f426a8b6f
Update feature-request.yml 2023-11-19 23:44:39 +02:00
Yair Morgenstern
53f424d7e7
Delete .github/ISSUE_TEMPLATE/feature_request.md 2023-11-19 23:43:46 +02:00
Yair Morgenstern
101ed5fd39
Update feature-request.yml 2023-11-19 23:43:25 +02:00
Yair Morgenstern
dea962a190
Update feature-request.yml 2023-11-19 23:43:09 +02:00
Yair Morgenstern
e12674db4c
Update feature-request.yml 2023-11-19 23:42:36 +02:00
Yair Morgenstern
436435d78e
Update feature-request.yml 2023-11-19 23:41:51 +02:00
Yair Morgenstern
8c0df2abe9
Update feature-request.yml 2023-11-19 23:41:21 +02:00
Yair Morgenstern
7f365a86e1
Update feature-request.yml 2023-11-19 23:39:28 +02:00
Yair Morgenstern
27ba5e05ec
Create feature-request.yml 2023-11-19 23:34:40 +02:00
Yair Morgenstern
d4db9f3c98
Update bug-report.yml 2023-11-19 23:32:27 +02:00
Yair Morgenstern
f1e91a717b
Update bug-report.yml 2023-11-19 23:31:31 +02:00
Yair Morgenstern
d25e3bec11
Delete .github/ISSUE_TEMPLATE/bug_report.md 2023-11-19 23:29:16 +02:00
Yair Morgenstern
2fe6ef33fa
Create bug-report.yml 2023-11-19 23:28:04 +02:00
Yair Morgenstern
2a9ec81523 Resolves #10512 resolves #10425 - Conditional tile checks pre-placement 2023-11-19 23:04:35 +02:00
Yair Morgenstern
f833918177 Resolved #10525 - AI clears inquisitors from city centers to make way for spaceship units 2023-11-19 22:16:54 +02:00
Yair Morgenstern
e6bb9d4d9a More simplification of motivationToAttack 2023-11-19 15:56:21 +02:00
Yair Morgenstern
13d0ea51d5 Separated hasAtLeastMotivationToAttack into separate class, split into subfunctions for main function readability 2023-11-19 15:52:16 +02:00
Yair Morgenstern
62687c2230 Unified errorSeverityForFilter checks into single function, we have a LOT of filters! 2023-11-19 00:10:08 +02:00
Yair Morgenstern
fb1e57668e Added tests for parameters for complex filters, fixed nested complex filter returning 'possible filtering' when it should have been known 2023-11-19 00:06:34 +02:00
Yair Morgenstern
92d181d282 Better formatting for general filter rules v2 2023-11-18 22:56:26 +02:00
Yair Morgenstern
b55c4497d0 Better formatting for general filter rules 2023-11-18 22:54:39 +02:00
Yair Morgenstern
2fd7779395 4.8.19 2023-11-18 22:48:39 +02:00
Yair Morgenstern
9488aa6415
Version rollout (#10519)
* Bump version and create initial changelog entry

* Update Dutch.properties (#10513)

* Update French.properties (#10506)

* Update Italian.properties (#10504)

* Update Polish.properties (#10502)

* Update Polish.properties

* Update Polish.properties

* Update Polish.properties

* Update Brazilian_Portuguese.properties (#10495)

* Update Catalan.properties (#10479)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Lena Bullens <95299589+LenaBullens@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Joan Josep <juanjo.ng.83@gmail.com>
2023-11-18 22:43:48 +02:00
SomeTroglodyte
98c3c446c5
Allow controlling Android fullscreen from options (#10518) 2023-11-18 22:38:36 +02:00
SomeTroglodyte
0d077ee099
(UX, minor) Change "took tile damage" notification to **select** the poor victim (#10471)
* Change "took tile damage" notification to select the poor victim

* Convenience constructor for NotificationAction:MapUnitAction

* More verbose Kdoc for MapUnitAction
2023-11-18 22:35:41 +02:00
SeventhM
accb62a0ed
Fix unit triggers not triggering/triggering off the wrong units (#10496) 2023-11-18 22:35:01 +02:00
Oskar Niesen
6fe9b7ea7f
AI diplomacy balancing (#10476)
* Merged Original AIDiplomacyBalancing changes to this branch

* Fixed being over supply resulting in the civ not attacking

* Fixed "War with allies" motivation not being added
2023-11-18 22:34:46 +02:00
The Bucketeer
371ec28a11
Add files via upload (#10507) 2023-11-18 22:34:35 +02:00
Framonti
8c9e6b07e0
Test/add tests for cityexpansionmanager (#10510)
* improve error message and add test for precondition checking

* add tests for CityExpansionManager
2023-11-18 22:34:26 +02:00
Yair Morgenstern
167f25cacd Modding: Added "non-[filter]" and multi-value filtering to Tile filter 2023-11-18 22:34:04 +02:00
Yair Morgenstern
ddf8b449b3 Modding: Added "non-[filter]" and multi-value filtering to Improvement filter 2023-11-18 22:30:07 +02:00
Yair Morgenstern
5484576640 Modding: Added "non-[filter]" and multi-value filtering to Terrain filter 2023-11-18 22:27:47 +02:00
Yair Morgenstern
2a862aa895 Modding: Added "non-[filter]" and multi-value filtering to Building filter 2023-11-18 22:23:22 +02:00
Yair Morgenstern
68fd3d74b3 Modding: Added "non-[filter]" and multi-value filtering to Nation and Civ filters 2023-11-18 22:20:47 +02:00
Yair Morgenstern
dc6413d707 Modding: Added "non-[filter]" filtering for unit filters
Cleaned up unit filter validations to match actual filters
2023-11-18 22:16:43 +02:00
Yair Morgenstern
2b0568f025 Modding: Added "[relativeAmount] Air Interception Range" unique 2023-11-18 19:16:33 +02:00
Yair Morgenstern
870c146e34 Resolved #10474 - Add/remove attack images on the tile, even if the attacked unit has meanwhile been killed 2023-11-14 12:52:47 +02:00
Yair Morgenstern
e8b9864287 Resolved #10478 - *internal* tilesets to load are now determined pre-loading, to minimize concurrent modification exceptions 2023-11-14 12:18:05 +02:00
Yair Morgenstern
dfcedb6267 Resolved #10494 - dim resources on tiles not immediately visible 2023-11-14 11:51:03 +02:00
Yair Morgenstern
7ccb19c28e 4.8.18 2023-11-13 22:39:06 +02:00
Yair Morgenstern
46e39d7d38
Bump version and create initial changelog entry (#10492)
Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
2023-11-13 22:34:21 +02:00
Yair Morgenstern
643f98b53f Resolves #10486 2023-11-13 22:33:29 +02:00
SomeTroglodyte
0029d08c5b
Patch for on-screen keyboard hiding pedia search results (#10469) 2023-11-13 22:26:49 +02:00
SomeTroglodyte
659a01c166
CrashScreen info improved, allow easier testing of CrashScreen (#10485)
* Drop AndroidTvLauncher - unused

* Additional memory info on Android CrashScreen

* Refactor getModsAndBaseRuleset - reduce clones and put base first

* Add Permanent audiovisual Mods to CrashScreen report

* Add a secret Debug option to intentionally crash Unciv

* Make "Secret" debug OptionsPopup page available on Android w/o physical keyboard

* Add AndroidTvLauncher back in

---------

Co-authored-by: Yair Morgenstern <yairm210@hotmail.com>
2023-11-13 22:26:38 +02:00
SomeTroglodyte
60e2af3bba
Fix "hidden from users" where Nation describes its unique Building (if it replaces an existing one) (#10467)
* Refactor: move UI functions from Building to BuildingDescriptions

* Move Nation "unique building" diff code to BuildingDescriptions, fix hidden ignore, equalize to how BaseUnitDescriptions.getDifferences works

* Fix translation errors for difference description "Lost ability"
2023-11-13 22:19:47 +02:00
SomeTroglodyte
2847f7a8c1
Rivers... Moddable Stats and Civilopedia (#10424)
* River yields moddable and Civilopedia entry

* Improve text and better fresh water explanations

* Map editor exclusion as Unique, for River and previously hardcoded Improvements

* Map editor brush to Civilopedia link, starting locations cleaned

* Some SeventhM input applied

* Reword River/Lakes/Oasis civilopediaText and comments again
2023-11-13 22:18:25 +02:00
Oskar Niesen
22a50c7d2d
Fixed land/sea nukes trying to act like air units (#10470) 2023-11-13 22:18:09 +02:00