* Redo
* New parameterized and actually used Road Unique
* Remove unneeded
* Update CURRENT_COMPATIBILITY_NUMBER since adding new serialization data
* Make neutralRoads for CivilizationInfo.kt Transient
* Reapply Changes
* Logic clean up
* Adding getImprovementToPillage() and getRepairableImprovement()
* Cleaning up Unit Actions
* getImprovementToPillage() needs to check for Unpillagable
* Remove redundant logic since canBuildImprovement() returns true if currently repairing
* More redundant logic
* Prevent City Center from being Pillage status
addRepairAction will not show a Repair Action
Adding the improvement to be repaired/pillaged in button text
Utilizing getImprovementToPillage() more
* Some import cleanup
Add Irremovable to blockers
More consolidation of code
* More translation files
* When improvements/roads are built/removed, pillaged flag set to False
* Better and more consistent logic
* Fix dumb logic bug
* Add slider
Align spawnIce latitude and offset code to applyHumidityAndTemperature
* A bunch of debug code
Make default Water Level -0.05 for Default
* Remove debug println
Fix Desert at 0.9-1.0 temp and <0.2 humidity
* Disable reseed for debug comparison
Reset Plains/Grassland for high temp. Adjust max humidity for safety of Grasslands
Humidity debugger
Better slider
* Remove all debug code
* Undo Desert temp setting
* Generalize Great Wall unique
* Update JSON entries
* And movement calculation too
* Rename other functions
* Cache movement penalty uniques
* Check destination tile instead of unit type
* Handfull of comment questions, small refactorings
* Code changes
* Reworded a unique, removed a file
* Added spy names for all nations, minor consistency change
* Removed debug output
* Added an empty constructor so gdx can reconstruct it
* Add Air Sweep Unique
Enable Dogfighting Promotion
Add Air Sweep mode button and crosshair overlay
* Adding Air Sweep Battle Table
* Add airSweep to Battle
Remove double XP
While in AirSweep can't select other units on tile
* initial airsweep code
* Implement airSweep
* BattleTable indicates tile you're AirSweeping
* some notifications
* Clean up notifications.
Add icons
* Revert game.atlas and game.png
* Fix selection properly
* Update Vanilla UnitPromotions.json
* Better handling of movement use
comment cleanup
* missing credit
* Proper code so that Seas units also deal no damage
Adding Tutorials!
* Remove Intercept Bonus Damage/Protection
* Remove chance of Interceptor missing
* Battle Table a bit more consistent
* Defender also gets Air Sweep Modifiers
* Defender doesn't get bonus
* Remove unused getInterceptBonus
Combine logic
* Show damage in notifications for Air Sweep
* Randomize intercepting Civ and prioritize Air Units
* Remove debug code
* Updated atlas
* Clean up Uniques
* Object-ify DamageDealt for ease of reference
* code clean up
Co-authored-by: itanasi <spellman23@gmail.com>
* added sounds to cityScreen
* changes? ..don't know how to name this commit
* removed try block
* improved era1 sound and added slider for city enter sounds
* added Information Era sound
* added Future Era sound
* better option name + translation
* added Atomic Era sound
* normalized sounds
* prevent spam + better era 0 and 1 sounds
* cleanup
* sound improvements to medieval and atomic
* volume now tied to sound effects
* improved information sound
* improved future sound
* sounds now stop if you exit the city screen
* improved Renaissance sound
* now in separate function
* now using the music controller
* better file names
* WLTK day sound + sounds are now configurable in Eras.json
* removed redundant setting and fixed comment
* added PlaySingle
* musicController no longer used
* Gdx.audio.newMusic is now used
* function name
* function are now in their own class
* CitySoundPlayer now has 1 instance in UncivGame and is hooked
* credits
* sounds loop
* loopable sounds
* updated credits
* fixed sound not stopping when changing city without leaving cityScreen
* changed WLTKNew sound
* added toggle for the sounds
* changed WLTK sound, removed music and made all tracks have the same volume
* addressed some of the issues
* addressed more issues
* increased sounds volume + volume slider
* made WLTK sound slightly quieter
* removed entry from Vanilla eras
* revert back to CitySoundPlayer.kt
* no more hooks
* removed unused stuff
* changees
* completly reverted MusicController
* and the MusicTrackChooserFlags
* fixed ESC not stopping sounds
* updated credits to mention the sounds are modified
* dispose()
* removed try block
* Civilopedia Files Split
* Central showReligionInCivilopedia function
* ConstructImprovementConsumingUnit with Conditional for Prophet
* Show Units capable of building an Improvement
* "Needs removal of terrain features to be built"
* Pillaging loots gold on certain improvements
* Add warning if improvement pillageGold > 0 and has UniqueType.Unpillagable
* Pillage yields as a UniqueType
* Forgot to undo demonstration
* Remove unused line
* Eliminate some redundancy
* Reword unique text
* Slight cleanup and add notification for pillage victim
* Reviews
* Made pillaging notifications more consistent with other hostile action notifications
* Missed a line
* Great General UniqueTyped and improved moddability - draft
* Great General UniqueTyped and improved moddability - reviews
* Great General UniqueTyped and improved moddability - no reason not to cache another
* Integration with JackRainy's solution
* Integration with JackRainy's solution - part 2
* Revert of maxGreatGeneralBonusRadius logic
* Minor refactoring
* Code review: minor refactoring
* Keep the warning for the modders about the obsolete unique
* Code review: Better wording for the unique
Co-authored-by: SomeTroglodyte <63000004+SomeTroglodyte@users.noreply.github.com>
* Great improvements can again be constructed on forest
This PR fixes a bug where great improvements couldn't be build on
forests/marshes/jungles/etc. It does so by creating a unique which
specifically allows for removing features, and checking for that.
Additionally, we only remove these features when we have the tech to
remove them. For example, you can no longer plonk an Academy down over a
forest without having researched mining.
* Missed the file for vanilla
* Reviews
* Fixed logic
* Renamed tile.hasUnique, deprecated `Indestructable`, unique for citadels
Also refactored the consumption of (great) people out of UnitActions.
* Reworked when improvements can be build somewhere for more clarity
* Made resources improvable by multiple improvements; Offshore Platform
* Fix compatability
* WIP
* Fixed the tests, but better
* I suppose I might as well update this now that we're a version later
* Implemented most easy things from comments on moddable victory PR
Also added religious victory condition
* Fixed tests
* Fixed compile problems & missing string
* Fixed typo
* Changed milestone build globally text to make it more understandable
* Actually this is probably just as clear, gramatically more correct and
more imperative like the other milestones
* Fixed tests
* Reworded again
* Added a moddable (but not yet functional) file for victories
* Spaceship parts are units now
* Fixed tests
* Added milestone objects
* Made 'our status' table in VictoryScreen dependend on file
* Updated VictoryManager to use the new Milestone system
* Fixed bug where in vanilla too many spaceship parts could beb uild
* Whoops
* Updated global victory table to use the jsons
* Updated the new game screen to show the new victory types
Also started with the deprecation of VictorType
* Did some translation stuff, also finally fixed the tests
* Removed VictoryType and reworked AI to use Milestones instead
* Add some checks for the victory file; tested that custom victories work
Also moves some code to a better spot and fixes compilation errors
* Fixed some things I thought about while falling asleep
Most notably: built -> build; fixed spaceship part construction
priority; removed more code for the old system
* Fixed translation issues on the victory screen
