mirrors/Unciv
1
0
Fork 0
mirror of https://github.com/yairm210/Unciv.git synced 2025-02-24 05:31:22 +07:00
Code Issues Packages Projects Releases Wiki Activity
9,177 Commits 6 Branches 1,054 Tags 1.1 GiB
0e664d943b
Commit Graph

6205 Commits

Author SHA1 Message Date
SomeTroglodyte
443bf3afdb
Local mod folder names preserved. (#9844) 
* Reduce conversion of local mod folder names to treat only ending spaces/dashes

* Wiki entry for GlobalUniques

* Missing originRuleset coverage

* Nicer RulesetValidator messages when name or originRuleset are missing
 2023-07-30 17:38:33 +03:00
SomeTroglodyte
b992144ecd
Fix a few now flagged but working Unique targets (#9845) 
* Allow a few working UniqueType-UniqueTarget combos in RulesetValidator

* RulesetValidator checks GlobalUniques

* Alternate Settlers and Workers recognized via Unique - same rules in RulesetValidator and GameStarter, wiki clarification
 2023-07-30 17:38:26 +03:00
SeventhM
ae7ac6a063
Fix resources subtracting in an incorrect manner when they have the same source (#9858) 2023-07-30 17:38:00 +03:00
SomeTroglodyte
bb7c75840e
Simple Originating-Mod display in Civilopedia (#9850) 
* Simple Originating-Mod display in Civilopedia

* Simple Originating-Mod display in Civilopedia - patch
 2023-07-30 17:37:50 +03:00
Oskar Niesen
df7fd27b94
Spectator can now see all invisible units including submarines without fog of war. (#9852) 2023-07-30 17:37:36 +03:00
SeventhM
283edd0875
Fix free buildings from other buildings not showing up correctly (#9857) 
* Rearrange order of actions when adding buildings

* Turns out you need to updateCivResources after adding in uniques. Whoops

* Mirror change to remove buildings as well
 2023-07-30 17:37:24 +03:00
itanasi
488ec9f82f
Fix logic in Fog Busting (#9855) 2023-07-30 17:36:38 +03:00
alexban011
5f8c675512
Fix linting warnings (#9701) 
* fix: VariableNaming warnings

* fix: MatchingDeclarationName warnings

* fix: SwallowedException warnings

* fix: UseRequire warnings

* Revert "fix: MatchingDeclarationName warnings"

This reverts commit 9475af5052.
 2023-07-26 07:30:14 +03:00
Yair Morgenstern
48ad5780d9
Version rollout (#9843) 
* Bump version and create initial changelog entry

* Update Simplified_Chinese.properties (#9835)

* more Persian UN Translation (#9832)

* Update Persian_(Pinglish-UN).properties

Added and fixed some of the translations till line 1039.

* Update Persian_(Pinglish-UN).properties

- Fixed a few till 1039.
- Added and fixed some from 1039 till 1254.

* Update Persian_(Pinglish-UN).properties

Added and fixed some till 5000

* Update Persian_(Pinglish-UN).properties

* Update Persian_(Pinglish-UN).properties

* Update Dutch.properties (#9816)

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

* Updated Brazilian_Portuguese.properties (#9813)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: AutumnPizazz <114050365+AutumnPizazz@users.noreply.github.com>
Co-authored-by: Ilia <81512402+ilia-abbasi@users.noreply.github.com>
Co-authored-by: Lena Bullens <95299589+LenaBullens@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
 2023-07-24 10:51:13 +03:00
Oskar Niesen
6dcad3add5
Fixed automated workers not replacing forts for AI civ. (#9837) 
* Fixed automated workers not replacing forts for AI civ.

* Fixed double parenthesis.

* Removed repeat removing fort in progress code.

* Improved evaluateFortPlacement
 2023-07-24 10:42:18 +03:00
Yair Morgenstern
97b80973d1 More BaseUnit unique-finding including type uniques 2023-07-21 15:18:39 +03:00
Yair Morgenstern
bc9b5615eb BaseUnit unique-finding always takes Type uniques into account 2023-07-21 15:09:14 +03:00
Yair Morgenstern
33ae13479d 4.7.9-patch1 2023-07-20 09:24:41 +03:00
SomeTroglodyte
383cb38c7d
NotificationAction compatibility patch (#9824) 
* NotificationAction compatibility patch

* NotificationAction compatibility patch
 2023-07-20 09:24:25 +03:00
SeventhM
4421a2a54e
Fix issues when adding/removing buildings (#9822) 2023-07-20 09:16:02 +03:00
Yair Morgenstern
d7b277b6b5 Memory performance improvement - don't create strings when you can instead hash the list! New ists are cheaper in-memory than new strings (only need to allocate "number of strings in list" pointers, and not "number of chars in all strings" chars) 2023-07-18 18:28:04 +03:00
Yair Morgenstern
ed74b03ff3
Version rollout (#9812) 
* Bump version and create initial changelog entry

* Update Catalan.properties (#9807)

* Update Hungarian.properties (#9798)

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Czech.properties (#9795)

* Update Czech.properties

* Update Czech.properties

* Missing brackets fix

* Update Spanish.properties (#9794)

* Update Simplified_Chinese (#9789)

* Update German translation (#9788)

* Update French.properties (#9786)

* Update Dutch.properties (#9785)

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

* Updated Brazilian_Portuguese.properties (#9784)

* Updated Brazilian_Portuguese.properties

* Update Brazilian_Portuguese.properties

* Update Polish.properties (#9783)

* Update Polish.properties

* Update Polish.properties

* Update Italian.properties (#9782)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Joan Josep <juanjo.ng.83@gmail.com>
Co-authored-by: balazsszalab <balazsszalab@freemail.hu>
Co-authored-by: jahodovykolac <79529669+jahodovykolac@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: chr_56 <30681738+chr56@users.noreply.github.com>
Co-authored-by: mape6 <mape6@posteo.de>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Lena Bullens <95299589+LenaBullens@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
 2023-07-18 18:16:06 +03:00
SeventhM
b37aaeb3c6
Fix issues from gaining free beliefs (#9764) 
* Fix issues from gaining free beliefs

* chooseBeliefs code I forgot

* Revert changes to next turn actions and allow for free beliefs while founding/expanding

* Missed a spot
 2023-07-18 18:08:59 +03:00
SeventhM
1ca9766811
Fix issues when transferring capitals (#9801) 
* Revert previous patches

* Fix the unit test, I guess
 2023-07-18 18:08:30 +03:00
SomeTroglodyte
37465b5032
Prevent deserialization problem with Espionage (#9809) 
* Prevent deserialization problem with Espionage

* Move comment and explain context a little better
 2023-07-18 18:08:18 +03:00
SomeTroglodyte
0e64b8230f
Little Promotion UX improvements (#9808) 
* Fix regression incorrectly allowing promotions from Unit Overview

* Autoclose PromotionPicker when all promotions chosen in one go

* Fix Unit Overview not showing new promotions when returning from PromotionPicker
 2023-07-18 07:25:00 +03:00
SeventhM
1e66c2e131
Avoid built buildings (#9806) 
* Removing most interactions with builtBuildings

* Might as well edit this too

* Fix issues and edit isBuilt

* Simplify isAllBuilt
 2023-07-16 23:01:17 +03:00
SomeTroglodyte
a29cdc91e8
Unique target compliance test v2 (#9802) 
* Split off some UniqueType helper classes, make regions work in Android Studio and linting

* Fix wrong UniqueType.Stats target

* Fix two Pantheon uniques

* BeliefType a little nicer to read

* More linting

* Implement UniqueTarget validation

* Validation of UniqueTypes allowed as conditionals
 2023-07-15 22:06:12 +03:00
Yair Morgenstern
00e008b656 4.7.8-patch1 
Resolves #9792 resolves #9791
 2023-07-11 16:47:24 +03:00
Yair Morgenstern
bcd5ad6c69
Version rollout (#9781) 
* Bump version and create initial changelog entry

* Update German translation (#9780)

* Update Catalan.properties (#9775)

* [Translation] Update Simplified Chinese (#9771)

* update Simplified_Chinese

* Update Simplified_Chinese

* Update Dutch.properties (#9769)

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

* Update Italian.properties (#9762)

* Update Polish.properties (#9759)

* Updated Brazilian_Portuguese.properties (#9758)

* Update French.properties (#9757)

* Update Dutch.properties (#9767)

* Update Dutch.properties

Completing Dutch translation part I

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

---------

Co-authored-by: Yair Morgenstern <yairm210@hotmail.com>

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: mape6 <mape6@posteo.de>
Co-authored-by: Joan Josep <juanjo.ng.83@gmail.com>
Co-authored-by: chr_56 <30681738+chr56@users.noreply.github.com>
Co-authored-by: Lena Bullens <95299589+LenaBullens@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: EmperorPinguin <99119424+EmperorPinguin@users.noreply.github.com>
 2023-07-10 17:01:47 +03:00
Yair Morgenstern
4c5db52a5c Change default fallback to HexaRealm instead - it's been ready for a while :) 2023-07-10 16:28:54 +03:00
Yair Morgenstern
ee092a5851
City-level resources (#9774) 
* City-level resources are...
- Not displayed in civ top bar
- Not considered civ-level resources (for trade, non-city conditionals, etc)
- Are explicitly treated in city conditionals
- ARE considered for constructing buildings requiring resource
- ARE NOT considered for construction units requiring resource

* getCityResources separates resources by origin so we need to sum them - kudos @SeventhM

* CR fixes

* Added new Civilization.getResourceAmount function

* More usages of civInfo.getResourceAmount()

* Don't add city resource table if it's empty
 2023-07-10 16:24:50 +03:00
SomeTroglodyte
a737747284
Little Diplomatic Victory makeover (#9756) 
* Linting and give two votes to UN owner

* Allow human player to abstain, show UN 2 votes

* More info on voting results

* AI won't vote for hated enemies

* Improve PopupAlert handling

* Translation templates

* One missing template
 2023-07-10 15:25:59 +03:00
random271
8f761642f6
Added notification for destruction of tile improvements [via unit ability] (#9754) 
* Added notification for desctruction of tile improvements [via unit ability]

* Modified template properties

* Update template.properties
 2023-07-09 23:24:38 +03:00
Yair Morgenstern
3c56319640 Display resource uniques in civilopedia 2023-07-09 11:51:25 +03:00
Yair Morgenstern
31f6a406c2 Resolved #9745 - memory improvement, cache uniquemap for tiles with identical terrain 2023-07-09 10:12:16 +03:00
Yair Morgenstern
d229d45298
Version rollout (#9755) 
* Bump version and create initial changelog entry

* Update Simplified_Chinese.properties (#9744)

* Update Italian.properties (#9737)

* Update Italian.properties

* Update Italian.properties

* Update French.properties (#9733)

* Updated Brazilian_Portuguese.properties (#9732)

* Update Dutch.properties (#9730)

* Update Dutch.properties

* Update Dutch.properties

* Update Dutch.properties

* Update Catalan.properties (#9728)

* Update German translation (#9723)

* Update Polish.properties (#9718)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: maxdu <d.darmax@gmail.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Lena Bullens <95299589+LenaBullens@users.noreply.github.com>
Co-authored-by: Joan Josep <juanjo.ng.83@gmail.com>
Co-authored-by: mape6 <mape6@posteo.de>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
 2023-07-06 00:42:39 +03:00
Yair Morgenstern
8042402c1c Fixed tile filter for civ-related conditions for "upon ending a turn in a [tileFilter] tile" trigger 2023-07-06 00:39:04 +03:00
SeventhM
5ea1d5722b
Fix buildings/units not triggering and golden age stat updates (#9731) 
* Fix buildings not triggering, golden age stat updates, and units not triggering

* Forgot import, whoops

* uodate resources and city connection when removing a building

* Move building triggers to function, added unit notification to translations

* Quick edits without android studio sucks

* Add unitActionModifier check back to hasTriggerConditional

---------

Co-authored-by: Yair Morgenstern <yairm210@hotmail.com>
 2023-07-06 00:36:43 +03:00
SeventhM
d2dac66f40
Avoid crashes with incorrect condtionals (#9753) 2023-07-05 22:57:06 +03:00
Yair Morgenstern
fdb07b06c1 Resolved #9740 - incorrect ruleset combos for 'buy building with stat' no longer crash 2023-07-05 21:59:01 +03:00
Yair Morgenstern
103234a6b8 Keep track of what mod each ruleset object comes from, for debug and civilopedia purposes 2023-07-05 21:55:57 +03:00
SomeTroglodyte
6a6a8a0c94
Minimal support for Alpha Frontier-like Workers (#9690) 
* Linting

* Cache hasUnique(UniqueType.CreateWaterImprovements)

* Move automateWorkBoats to WorkerAutomation - for readability and better chances to create synergies

* Add a chance for automated Alpha Frontier Workers to create Water improvements

* Reorg random271's Lemming code a little

* Tune Worker automation for buildable Water improvements
 2023-07-05 21:11:17 +03:00
Yair Morgenstern
19bf15558d Fixed India's 'double unhappiness' unique 2023-07-05 21:10:22 +03:00
SeventhM
08a280c29d
Scaling purchase costs for faith/culture/science/etc. with speed (#9721) 
* Scaling with speed

* Changing to float, and allowing a unique to set a gold price
 2023-07-04 20:16:48 +03:00
SomeTroglodyte
ad0af51020
Explain the invoke trick as well (#9739) 2023-07-04 15:12:30 +03:00
SomeTroglodyte
05f9d3cb36
Clearer NotificationActions code (#9738) 2023-07-04 13:59:35 +03:00
SomeTroglodyte
fb3064dd4b
Prevent activation of disabled actors via key shortcuts (#9736) 
Avoid activation concurrent modification problems
 2023-07-04 13:58:34 +03:00
Skekdog
8263d972ff
Fix civilopedia gold cost (#9729) 
* Fix exponent being applied wrong

* Format more consistent with rest of project

* Fix building gold cost in civilopedia and use slash instead of a comma

* Add INonPerpetualConstruction.getCivilopediaGoldCost()
 2023-07-03 23:52:47 +03:00
SeventhM
afb30fb1ca
Better support for lacking a capital (#9709) 
* more getCapital null checks

* Move first city if no capital check to getCapital
 2023-07-03 23:47:49 +03:00
Yair Morgenstern
86cde678b3 chore: Modernized TileImprovementConstructionTests 2023-07-03 23:43:03 +03:00
Yair Morgenstern
06377feaeb 4.7.6-patch2 
Resolved crash when moving cities between civs, added tests to ensure future changes do not break city moving functionality
 2023-07-03 14:13:31 +03:00
SomeTroglodyte
6726d2ce03
Keyboard bindings for Main Menu Screen (#9680) 
* Main Menu keyboard bindings

* Make keyboard binding tooltips dynamic so user changes need no UI rebuild
 2023-07-02 22:28:10 +03:00
Yair Morgenstern
6f0a51d6d8 4.7.6-patch1 
Captured 'last city' capitals do not retain capital status
 2023-07-02 17:36:38 +03:00
Yair Morgenstern
bfc2e3cd59
Version rollout (#9717) 
* Bump version and create initial changelog entry

* Various new lines added, some minor corrections. (Dutch.properties) (#9713)

* Various new lines added, some minor corrections.

* Minor correction in placeholder

* Update Spanish.properties (#9702)

* Updated Brazilian_Portuguese.properties (#9696)

* Update French.properties (#9692)

* Update Italian.properties (#9688)

* Update Italian.properties

* Update Italian.properties

* Update Simplified_Chinese.properties (#9687)

* Update Simplified_Chinese.properties

* Update Simplified_Chinese.properties

* Update Simplified_Chinese.properties

* Update Polish.properties (#9686)

* Update Polish.properties

* Update Polish.properties

* Update Polish.properties

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Lena Bullens <95299589+LenaBullens@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: CrispyXYZ <64761703+CrispyXYZ@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
 2023-07-02 15:18:50 +03:00
SeventhM
0e8c960867
Check for triggers conditions (#9699) 
* Check for triggers conditions

* removing shadowed names

* Move Conditional check to Uniques
 2023-07-02 14:53:34 +03:00
itanasi
753358c1f0
On City Raze, previous owner doesn't pay Road Maintenance (#9706) 2023-07-02 14:53:19 +03:00
SeventhM
589a9fa29f
Fix when units can be purchased (#9715) 2023-07-02 14:53:06 +03:00
Yair Morgenstern
0edfa4841e Better image documentation for modders 2023-07-02 02:42:36 +03:00
Yair Morgenstern
bb22b1de72 Actually generated unique type documentation 2023-07-02 01:36:28 +03:00
Yair Morgenstern
d0643efe6b Added unique type documentation in wiki 2023-07-02 01:28:27 +03:00
Yair Morgenstern
fd2bfbdc10 Resolves #9561 - "Requires a [buildingFilter] in at least [amount] cities" works correctly with filters that aren't building names 2023-06-30 15:47:45 +03:00
Yair Morgenstern
947a1001c4 Resolves #9703 - AI only buys tiles contiguous to the current city tiles (was: contiguous to civ tiles) 2023-06-30 15:13:14 +03:00
SomeTroglodyte
1694a59fd2
Defense against circular references in Promotions (#9694) 
* Promotion picker - working defense against circular references

* Mod checker - complain about circular references
 2023-06-29 09:18:07 +03:00
Yair Morgenstern
6eeb630b6c chore: 'cityInfo' purge (changed to 'city' everywhere) 2023-06-28 23:38:01 +03:00
Yair Morgenstern
83270ddf8f Resolved #9689 - no city window on citybutton click 2023-06-28 19:08:52 +03:00
Yair Morgenstern
4a7f484900 Revert "Solved strange concurrency crashes due to players keypress-activating disabled buttons" 
This reverts commit ee855b8d77.
 2023-06-28 19:01:37 +03:00
Yair Morgenstern
4c28905e2c Undo Move button moved to far right, so other buttons stay in place 2023-06-28 13:23:22 +03:00
SomeTroglodyte
a8ec8f84ec
Architectural update - Make animated menu reusable (#9685) 
* Extract AnimatedMenuPopup from UnitUpgradeMenu to make its basic idea reusable

* Rebase UnitUpgradeMenu onto AnimatedMenuPopup

* Add SoundPlayer.playRepeated for future reusability

* Move UnitUpgradeMenu to popups package

* Reuse playRepeated in PromotionPickerScreen

* Reuse playRepeated in PromotionPickerScreen - clean up imports
 2023-06-28 12:05:04 +03:00
Yair Morgenstern
f5d3f346b1
Version rollout (#9684) 
* Bump version and create initial changelog entry

* Update Spanish.properties (#9682)

* Updated Brazilian_Portuguese.properties (#9677)

* Updated Brazilian_Portuguese.properties

* Update Brazilian_Portuguese.properties

* Update German translation (#9675)

* Update French.properties (#9674)

* Update Russian.properties (#9672)

* Update Russian.properties

* Update Russian.properties

* Update Italian.properties (#9670)

* Update Polish.properties (#9668)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: mape6 <mape6@posteo.de>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: JOGANfruit <77359522+JOGANfruit@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
 2023-06-28 11:05:23 +03:00
SomeTroglodyte
c45d3ecb7c
Promotion picker allowing picking chains in one go (#9655) 
* Try to allow chained promotion picking

* Reorg PromotionPickerScreen into own package

* Draft for new PromotionTree

* Change PromotionPickerScreen to use new tree (picking still not done)

* Finish new PromotionPickerScreen - code

* Finish new PromotionPickerScreen - assets and linting

* Finish new PromotionPickerScreen - polish positioning and lines

* Finish new PromotionPickerScreen - fix sound

* Finish new PromotionPickerScreen - little optimization

* Finish new PromotionPickerScreen - emphasize line along path

* Finish new PromotionPickerScreen - merge fix

* Finish new PromotionPickerScreen - address comments

* Finish new PromotionPickerScreen - fix sort and update wiki
 2023-06-28 10:49:35 +03:00
random271
d298f85099
Fixing workers dying in mountains bug for Carthage (#9665) 
* Fixed workers dying in mountain tiles issue for Carthage

* Accounts for all damage dealing tiles

* Update WorkerAutomation.kt

* Update Tile.kt

* Update WorkerAutomation.kt

* Update WorkerAutomation.kt
 2023-06-28 10:48:44 +03:00
SeventhM
73fa87e6b4
Check for trigger uniques when starting and recaluating population (#9673) 
* Check for trigger uniques when starting and recaluating population

* Adding imports

* whoops

* Moved where starting techs are added, added a parameter, and fixed the check for GUI
 2023-06-28 10:48:33 +03:00
Yair Morgenstern
ee855b8d77 Solved strange concurrency crashes due to players keypress-activating disabled buttons 2023-06-28 10:45:36 +03:00
Yair Morgenstern
bef1843cd9 chore: Removed vestigal city.apply{} for CityInfoConquestFunctions, for clarity on what is actually for the city and what is not 
No logic changes
 2023-06-28 10:34:29 +03:00
Yair Morgenstern
42a9c3af57 Resolved #9679 - 'liberate city and resurrect civ' no longer crashes 
Kudos @SomeTroglodyte and @random271 for locating the problem :)
 2023-06-28 10:27:09 +03:00
Yair Morgenstern
a6e4b72cf4 AI no longer purchases non-contiguous tiles 2023-06-26 23:07:53 +03:00
Yair Morgenstern
0536c5f24b Resolved #9669 - city name translation for conquered popup does not get icon 2023-06-26 22:08:41 +03:00
SomeTroglodyte
6a8f4914b8
More defensive coding of speedupWonderConstruction (#9671) 2023-06-25 19:24:30 +03:00
Yair Morgenstern
330fa6593b 4.7.4 2023-06-25 10:07:17 +03:00
Yair Morgenstern
14e1683db2
Version rollout (#9667) 
* Bump version and create initial changelog entry

* Ukrainian translations (#9663)

* Update French.properties (#9662)

* Update French.properties

* Fix wrong key

* Update Spanish.properties (#9652)

* Update Spanish.properties

* Update Spanish.properties

* Brazilian_Portuguese.properties (#9649)

* Update Italian.properties (#9647)

* Update Italian.properties

* Update Italian.properties

* Update German.properties (#9646)

* Update German.properties

* Fixed missing [spyname]

---------

Co-authored-by: Birk Birkner <birkner@bbirkner.de>

* Update Polish.properties + question (#9644)

* Update Polish.properties

* Update Polish.properties

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Jack Rainy <JackRainy@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: Knirps1 <52383078+Knirps1@users.noreply.github.com>
Co-authored-by: Birk Birkner <birkner@bbirkner.de>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
 2023-06-25 09:58:03 +03:00
SomeTroglodyte
0aca3c307b
Notifications architectural update (#9605) 
* Improved Notifications architecture

* Revert NotificationIcon as class hierarchy

* Improved Notifications architecture - migration roadmap first step
 2023-06-25 09:47:50 +03:00
SomeTroglodyte
1a6d8d72bb
Fix ruleset error crash (#9666) 
* Harden NewGameScreen against exceptions from getComplexRuleset

* Miscellaneous tweaks to NewGameScreen - e.g. allow it to show last used custom map
 2023-06-25 09:46:00 +03:00
SomeTroglodyte
abb0dcbaae
Mod name defense attempt II (#9645) 
* Improve Load game error label readability

* Fix threading on load game screen

* Miscellaneous tweaks

* Compatibility with Mods using trailing dashes on Windows
 2023-06-25 09:38:18 +03:00
Jack Rainy
82ebb01a20
Zoom in/out of the history charts (#9660) 
* Do not recreate the Line Chart every time

* Simplifed the Line Chart creation

* Do not create objects in draw(): VictoryScreenCivGroup table

* Do not create objects in draw(): Labels

* Create labels without negative Y

* Lift the X axis if there is an negative number

* Arbitrary number of -Y labels

* Autoscale by Y axis

* Zoom in/out by click

* Autoscale by X axis

* Unit tests for LineChart

* Rework of the line chart rendering
 2023-06-25 09:37:08 +03:00
SeventhM
1285133884
Adding field for great person type (#9614) 
* Adding Field for great person types

* Switching from unit field to unique

* Simplification and adding back in the old field for backward compatibility

* Deprecate old field for checking great person

* Fix error

* Fixes part 2. I probably should've waited
 2023-06-25 09:36:33 +03:00
Xander Lenstra
aa0fb9ed8b
More unit unique tests (#9639) 2023-06-25 09:35:31 +03:00
SeventhM
bc3f1341e1
Tech column validation and removing crashes from undefined building costs (#9664) 
* Add in tech column validation

* Negative Columns

* Forgot to add techColumns to the add and clear functiond

* Remove restrictive cokumn check

* bugfixing
 2023-06-25 09:34:23 +03:00
SomeTroglodyte
650a43aa3b
Make UncivGame.isInitialized inaccessible outside of the class hierarchy (#9651) 
* Make UncivGame.isInitialized inaccessible outside of the class hierarchy

* Fix JvmName
 2023-06-25 09:03:44 +03:00
Yair Morgenstern
a246baa333 Resolved #9638 - Removing old buildings on enemy capital (when not last city) no longer crashes 2023-06-23 10:17:45 +03:00
Yair Morgenstern
ee668710e2 Resolved #9637 - Concurrent modification fix for liberated city with multiple units in it 2023-06-23 09:54:33 +03:00
Yair Morgenstern
b7e4ca358c Resolved #9641 - Removed static wrapper functions from WorkerAutomation 2023-06-23 09:51:04 +03:00
Yair Morgenstern
66eed083f2 Fixed broken build 2023-06-23 09:26:53 +03:00
Yair Morgenstern
970cb3cf3d
Version rollout (#9642) 
* Bump version and create initial changelog entry

* Update Traditional_Chinese.properties (#9634)

* Update Traditional_Chinese.properties

* Update Traditional_Chinese.properties

* Update Spanish.properties (#9628)

* Update French.properties (#9626)

* Update Italian.properties (#9624)

* Update German translation (#9623)

* Update Polish.properties (#9620)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Leslie Yu <32165704+leslieyu608@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: mape6 <mape6@posteo.de>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
 2023-06-23 09:08:38 +03:00
SeventhM
38cf71a7ab
Bug fix: Buildings not set to -1 by default correctly (#9635) 
* Change the default cost of buildings and the default time of tile improvements

* Bugfix: default building cost is now set to -1 as intended
 2023-06-23 08:52:47 +03:00
SeventhM
f78fd7e665
Move on water (#9622) 
* Add in Move on water unique

* Small fixes

* Remove redundant check
 2023-06-23 08:51:48 +03:00
Xander Lenstra
47e93a86bf
Spies now occasionally steal technologies (#9629) 
* Spies now occasionally steal technologies

* Updated the UI so it doesn't show a turn counter when that cannot be provided

* Implemented changes discussed in reveiw comments

* Renamed variable

---------

Co-authored-by: Yair Morgenstern <yairm210@hotmail.com>
 2023-06-23 08:51:34 +03:00
Xander Lenstra
3c1f0f7814
Spies in cities that are captured or destroyed now go to the hideout (#9632) 
* Spies in cities that are captured or destroyed now go home

* Turned spy flee reason string into enum
 2023-06-23 08:50:56 +03:00
Crsi
e1fb0e489d
Moved the default message to the ApiStatusCode enum (MPv2) (#9630) 2023-06-20 13:08:09 +03:00
SomeTroglodyte
ff54bcd493
Prevent mod conflicts better (#9586) 
* Tighten mod check severity and selectivity for unit-producing triggered Uniques

* Prettify display of mod check results by suppressing dupes and hiding conditionals from tr()

* Extra confirmation to play with errors, colors, improved handling of mod checkboxes

* Tweaks to improved mod checking in new game
 2023-06-19 19:02:09 +03:00
SeventhM
172fee9902
Change the default cost of buildings and the default time of tile improvements (#9621) 2023-06-19 19:01:40 +03:00
Yair Morgenstern
c0e5f9d736 Linked Unit Types and Promotions in Civilopedia 2023-06-19 16:04:35 +03:00
Yair Morgenstern
e987bbbaad Added new unique - "Automatically built in all cities where it is buildable" 2023-06-19 15:40:21 +03:00
Yair Morgenstern
4107e081bd 4.7.2 2023-06-18 18:29:55 +03:00
Yair Morgenstern
4579e37848
Version rollout (#9618) 
* Bump version and create initial changelog entry

* Ukrainian translations :flag-ua: (#9615)

* update Simplified_Chinese (#9613)

* Updated Brazilian_Portuguese.properties (#9599)

* Update French.properties (#9597)

* Update Italian.properties (#9595)

* Update Italian.properties

* Update Italian.properties

* Update Polish.properties (#9594)

replaced symbols with polish letters

* Update Polish.properties (#9593)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Jack Rainy <JackRainy@users.noreply.github.com>
Co-authored-by: chr_56 <30681738+chr56@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
 2023-06-18 18:26:18 +03:00