Commit Graph

6688 Commits

Author SHA1 Message Date
SomeTroglodyte
f529d969f0
Mod declarative compatibility - a little more (#10751)
* Mod compatibility - update declarations

* Mod compatibility - logic and UI changes

* Mod compatibility - flag some invalid use patterns

* RulesetValidator - lint until Studio shuts up

* Fix isBaseRuleset test in ModRequires validation

---------

Co-authored-by: Yair Morgenstern <yairm210@hotmail.com>
2023-12-22 09:59:38 +02:00
Yair Morgenstern
746918b1d3
Revert "New Citizen Focus Options (#10745)" (#10793)
This reverts commit 07c6728123.
2023-12-22 09:45:45 +02:00
itanasi
07c6728123
New Citizen Focus Options (#10745)
* Add Gold Growth and Production Growth Focus
New Manual Focus doesn't reallocate population

* Use Stat Names (and symbols) for focus

* Missing reassign code

* Clean up table for efficiency

* Table v2

* minor translation changes

* COMPATIBILITY

* v3 table

* Minor fixups
2023-12-22 09:38:43 +02:00
Oskar Niesen
d1bb563333
One player in each round will be processed even if all players are defeated. (#10788) 2023-12-22 09:38:14 +02:00
SomeTroglodyte
d3ac2c5ede
(UI) Politics overview diagram: Add legend popup (#10451)
* Refactor Battle damage shadowed Label into reusable WidgetGroup

* Make Politics Overview "Grid header" fixed and some linting

* Add a Legend popup explaining line colors in the Politics Overview Diagram: Click inside

* Missing translation template

* Final decision on background didn't make it in properly

* Remove unused png - those are now in the Construction atlas

* Smaller background image

* Color and shadow choices

* Redo atlas to include both 10505 and this
2023-12-22 09:37:47 +02:00
Yair Morgenstern
c08270362e Resolves #10792 - 'unique is requirement for tech' only looks at tech conditional 2023-12-22 09:35:12 +02:00
SomeTroglodyte
beced92a69
Linting of MapUnit class (#10785)
* Reorganize - restore meaning to existing regions, sort fields into regions, treat warnings

* Reorganize - double-check pure/side-effect regions and move inappropriate placements
2023-12-21 17:19:02 +02:00
Yair Morgenstern
851ab2e7b8 Separate higher-level autosave functions from lower-level file functions 2023-12-19 23:45:12 +02:00
Yair Morgenstern
7a28f15106 Revert "Great Person Points - Rounding changes, Breakdown UI (#10714)"
This reverts commit 64a455152a.
2023-12-19 23:10:36 +02:00
Yair Morgenstern
1cee3f722e Unit by default not selected on turn start 2023-12-19 23:05:35 +02:00
Yair Morgenstern
b04da39799 Added 'upon turn end' trigger 2023-12-19 22:34:34 +02:00
yairm210
93224f1491 4.9.10-patch1 2023-12-18 19:40:30 +00:00
SomeTroglodyte
77de68cfc5
Fix any tech researched clearing all units from queues (#10777) 2023-12-18 21:40:22 +02:00
Yair Morgenstern
08514cbd2e 4.9.10 2023-12-17 22:33:05 +02:00
Yair Morgenstern
c0f837628b Resolved #10674 - added mod checker warning that movement uniques do not always work with conditionals 2023-12-17 22:25:30 +02:00
Yair Morgenstern
805f008af5
Version rollout (#10766)
* Bump version and create initial changelog entry

* Update Latin.properties (#10765)

* Update Malay.properties (#10764)

It's gonna be a long time till I translate everything. Goddamn there's like 10k+ things to translate. Anyways, gonna sleep.

* Update Catalan.properties (#10762)

* Update French.properties (#10754)

* Update Afrikaans.properties (#10752)

Translation update

* Update Polish.properties (#10750)

* Update Brazilian_Portuguese.properties (#10749)

* Update Brazilian_Portuguese.properties

* Update Brazilian_Portuguese.properties

* fix tests

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: Mikhail <151419244+MetaFBMI@users.noreply.github.com>
Co-authored-by: Joan Josep <juanjo.ng.83@gmail.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: SielVlokkies <153941039+SielVlokkies@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
2023-12-17 22:20:00 +02:00
PLynx
cde26d325e
Add the remove unit promotion unique (#10759)
* Added the remove unit promotion unique

* Moved two lines of code inside if
2023-12-17 22:03:52 +02:00
SomeTroglodyte
3fd9bc2df3
Fix key bindings all reset to unbound on entering options and leaving without looking at the keys page (#10753) 2023-12-17 22:03:43 +02:00
Rémi Dufour
3797817291
Coast spread algorithm (#10741)
* new algo for coast placement

* optimization?

* change default max coast extension

* put spreadcoast in a function

* default change back, nextBoolean() and for loop
2023-12-17 22:03:31 +02:00
itanasi
af4dea60e0
Stop on Path Blocked (#10758)
* The change

* The change properly this time
2023-12-17 22:03:14 +02:00
Will Allen
51e444df6d
Units that can't build roads should not have connect roads automation. (#10760) 2023-12-17 22:02:59 +02:00
Rémi Dufour
1316271ac6
avoid initializing with terrain that shouldn't be naturally generated (#10756)
* avoid initializing with terrain that shouldn't be naturally generated

* add space

* fix partial generation freeze

* one-liner unique check
2023-12-17 22:02:45 +02:00
SeventhM
7ff38b2687
Fix Great Scientist science calculation (#10763)
* Linting

* Simplify adding science of last 8 turns
2023-12-17 22:02:33 +02:00
SeventhM
7bc3f22733
Show stat percent differences in replacement building differences (#10730) 2023-12-17 22:02:02 +02:00
dHannasch
4b5bb54b72
Add BaseUnit.automaticallyUpgradedInProductionToUnitByTech() (#10664)
* Update BaseUnit.kt

* Update RulesetValidator.kt

* Update BasicTests.kt

* Update BaseUnit.kt

* Update TechManager.kt

* Update BaseUnit.kt

* Update BaseUnit.kt
2023-12-17 22:00:45 +02:00
dHannasch
18c17e3a18
Don't list Unique requiring a tech in the Civilopedia for that tech (#10650)
* Update BuildingDescriptions.kt

* Update BaseUnitDescriptions.kt

* Update DescriptionHelpers.kt

* Update BuildingDescriptions.kt

* Update DescriptionHelpers.kt

* Update Technology.kt

* Update Technology.kt

* Update TechnologyDescriptions.kt

* Update BaseUnit.kt

* Update BaseUnit.kt

* Update Building.kt

* Update TechnologyDescriptions.kt

* Update Building.kt

* Update Building.kt

* Update Building.kt

* Update BaseUnit.kt

* Update BaseUnitDescriptions.kt

* Update BuildingDescriptions.kt

* Update TechnologyDescriptions.kt
2023-12-17 22:00:30 +02:00
Yair Morgenstern
d2d2e5b1ae
Version rollout (#10747)
* Bump version and create initial changelog entry

* Update Russian.properties (#10742)

* Update Polish.properties (#10735)

* Update Polish.properties

* Update Polish.properties

* Update Polish.properties

* Update Korean.properties (#10733)

* Update French.properties (#10732)

* Update Italian.properties (#10731)

* Update Brazilian_Portuguese.properties (#10729)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Anoant <143289571+Anoant@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: Yattong the Mackerel <saud2410@naver.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
2023-12-15 11:53:05 +02:00
SeventhM
297aa3e082
Avoid crash in mod checker for mods with undefined tech requirements (#10744) 2023-12-15 11:13:23 +02:00
soggerr
c60700193f
Show average damage in battle calculations (#10738)
Change BattleTable to calulate average damage and show alongside the min
and max for easier calculations when planning to attack with multiple
units such as when sieging a city

Unfortunately for min-maxers the randomness is still turn dependent
for a given defending unit, so the damage randomness will not average
out across multiple attacks on a given turn but they will all be more or
all be less depending on the luck that turn.
2023-12-15 11:13:12 +02:00
soggerr
bc1a428eeb
Allow battle calculations when not your turn (#10737)
Allow BattleTable display when it is not the viewing players turn.
This will allow for more planning while waiting for other players.
2023-12-15 11:12:45 +02:00
SeventhM
ad820b6a72
Fix stats from tileFilter unique not working on improvements (#10728) 2023-12-15 11:12:34 +02:00
SeventhM
93b89e1922
Add damage dealing unit trigger (#10720)
* Add damage dealing unit trigger

* Switch Heal/Damage uniques to only allow positive amounts
2023-12-15 11:12:21 +02:00
SeventhM
023b2959af
Fix not getting unique unit from tile based free unit trigger (For real this time) (#10746) 2023-12-15 11:12:05 +02:00
Yair Morgenstern
9a9559a20c Deprecate old religion uniques - finally!!! Months in the making! 2023-12-13 23:28:36 +02:00
Yair Morgenstern
be211d0cc4
Version rollout (#10727)
* Bump version and create initial changelog entry

* Update Italian.properties (#10719)

* update Turkish.properties (#10709)

* Update Turkish.properties

Added new translations

* Update Turkish.properties

* Update Turkish.properties

* Update Turkish.properties

* Update Turkish.properties

* Update Turkish.properties

Added fastline translate

* Update Turkish.properties

* Update Turkish.properties

* Update Simplified_Chinese.properties (#10708)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: komandotayfa <53448093+komandotayfa@users.noreply.github.com>
Co-authored-by: AutumnPizazz <114050365+AutumnPizazz@users.noreply.github.com>
2023-12-13 23:10:26 +02:00
Yair Morgenstern
358e12a54d Avoid ANRs when users select mods that take above 500ms to run checks on 2023-12-13 23:05:10 +02:00
Yair Morgenstern
626973bfb7 Resolved crash when returning to empire overview and a category is missing 2023-12-13 22:55:36 +02:00
WhoIsJohannes
62469daff6
Add another confirmation when buying a religious unit in a city that … (#9570)
* Add another confirmation when buying a religious unit in a city that doesn't follow a religion founded by the city's civ.

* There's other stuff that can be purchased with Faith. Better to use UniqueType.Religious unit I guess.

* Add string to template.properties

* One more space to make unit tests happy

* Better template.properties

* Reinsert trailing space

* Introduce Constants entry for "Cancel"

* Redo ConfirmBuyPopup

* Dev console command to tweak religion pressures

* Translation templates and one test

---------

Co-authored-by: SomeTroglodyte <63000004+SomeTroglodyte@users.noreply.github.com>
2023-12-13 22:45:46 +02:00
Rémi Dufour
153a90623c
Add new map types (#10695)
* fractal map type

* repeat create fractal until enough land

* small changes and add map types Lakes and Small Continents

* fix for removing land at edges of hexagonal maps

* readability
2023-12-13 22:37:27 +02:00
SeventhM
d2dde08824
Allow arbitrary victory types for the purposes of policies (#10716) 2023-12-13 22:36:37 +02:00
SomeTroglodyte
a24f9d7716
Civilopedia key bindings (#10723)
* Move CivilopediaImageGetters object to own file

* Keyboard bindings for Civilopedia

* Better default key choices

* Change default Key Binding Tab visibility to ON
2023-12-13 22:36:29 +02:00
soggerr
aba77b8350
Fix 'Sleep Until Healed' action missing (#10718)
Sleep until healed check unit injured logic fix
2023-12-13 22:36:20 +02:00
SomeTroglodyte
64a455152a
Great Person Points - Rounding changes, Breakdown UI (#10714)
* Change per-City GPP points math and separate breakdown (producer w/ source doc) from aggregates (consumer ignoring source)

* Change CityScreen GPP list to not do aggregation itself, but show a breakdown on click

* Change "birth" city for GPP to a ***weighted*** random - no Great Mufties from cities not generating any Mufty points!

* Nicer signature for getGreatPersonPointsBreakdown

* Minor warnings linting and template for Sweden's bonus in the breakdown Popup
2023-12-13 22:36:12 +02:00
MioBestWaifu
8b5c358904
Update TradeEvaluation.kt (#10713) 2023-12-13 22:36:02 +02:00
Why-not-now
16893ced68
Added check for belief.type (#10711)
* Added check for belief.type

* Removed check for BeliefType.None

Not needed if check beforehand checks for it

* Update RulesetValidator.kt

* Update Belief.kt

* Update Belief.kt
2023-12-13 22:35:51 +02:00
SomeTroglodyte
9c4ba059ca
(Tool) Tiny helper to load MP saves (from issues for debugging) as hotseat (#10610)
* Linting

* Another button on the "secret" debug tab: Load MP as hotseat

* Remove password wall from Debug Options (but not the Ctrl-Shift gate)
2023-12-13 22:35:38 +02:00
SomeTroglodyte
6d948e97ff
Fix ended Leader Voice not cleared and resumed on un-pause (#10724) 2023-12-13 22:35:17 +02:00
Yair Morgenstern
5f22172e70
Version rollout (#10704)
* Bump version and create initial changelog entry

* Update Latin.properties (#10700)

* Update Spanish.properties (#10692)

* Update Polish.properties (#10687)

* Update Polish.properties

* Fix a typo

* Update Russian (#10685)

* Update Russian.properties

Partial translation

* Update Russian.properties

* Update Turkish.properties (#10683)

* Update Turkish.properties

Added new translations

* Update Turkish.properties

* Update Turkish.properties

* Update Turkish.properties

* Update Turkish.properties

* Update Turkish.properties

Added fastline translate

* Update Turkish.properties

* Update French.properties (#10681)

* Update Italian.properties (#10680)

* Update Brazilian_Portuguese.properties (#10679)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: Anoant <143289571+Anoant@users.noreply.github.com>
Co-authored-by: komandotayfa <53448093+komandotayfa@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
2023-12-10 23:08:21 +02:00
SeventhM
06f46a44d8
Allow conditionals for unit actions (#10682) 2023-12-10 22:59:54 +02:00
Yair Morgenstern
69ce160ff9
Added 'relevant city' to conditionals, taking the city from the relevant tile where no city provided directly (#10684) 2023-12-10 22:59:45 +02:00
Will Allen
b3c7143e36
Fix connect road button for when auto unit cycle is turned on (#10696) 2023-12-10 22:59:35 +02:00
PLynx
87b02e49cd
Add resource support to stat gamespeed conditional (#10677)
* Tweaked the stat gamespeed conditional

Tweaked the stat gamespeed conditional to accept the resources

* Changed some names

* Fixed a double limit bug
2023-12-10 22:59:22 +02:00
Will Allen
e9752292eb
Add null check for connect road cross-version saves (#10699)
* Add null checks to fix #10691

* Issue reference unnecessary
2023-12-10 22:59:01 +02:00
Yair Morgenstern
49ddbe4982 Resolved #10703 - Captured military units trigger a notification for the captured unit's civ 2023-12-10 22:48:51 +02:00
Yair Morgenstern
200b764b05 Resolved #10676 - Citezenship policy grants worker even without having cities 2023-12-10 22:37:35 +02:00
Yair Morgenstern
d213c3d78f Resolved #10697 - default white color for city-state types 2023-12-10 22:21:31 +02:00
Yair Morgenstern
0625cb7087 Resolved #10698 - Fixed city-state type coloring 2023-12-10 22:19:54 +02:00
Yair Morgenstern
2ae5a018de Added initial pathfinding tests 2023-12-08 14:48:48 +02:00
Yair Morgenstern
cce678800f Fixed pillage tests 2023-12-08 14:10:56 +02:00
Yair Morgenstern
c483c4329a Console: Added 'unit setmovement' command 2023-12-08 13:45:57 +02:00
Yair Morgenstern
ee8f8a3c89 Fixed compilation error 2023-12-08 13:31:34 +02:00
Yair Morgenstern
aa1b5af19d standardized exploration actions 2023-12-08 13:30:10 +02:00
Yair Morgenstern
fad06b3aec standardized pillage, sleep actions 2023-12-08 13:24:21 +02:00
Yair Morgenstern
840f3c2093 standardized automate action 2023-12-08 12:23:00 +02:00
Yair Morgenstern
2ffec93ae8 invokeUnitAction will take the first *actionable* action, instead of the first one that exists, which may not be actionable 2023-12-08 12:17:07 +02:00
Yair Morgenstern
40283078d4 "Can instantly construct a [improvementFilter] improvement" works with improvementFilter 2023-12-07 23:09:05 +02:00
Yair Morgenstern
2fbe227285 Fixed work boat automation 2023-12-07 23:01:55 +02:00
Yair Morgenstern
1723cc36f1 chore: city settle action readability 2023-12-07 22:49:23 +02:00
Yair Morgenstern
d4f53bf813 Standardized 'add in capital' action 2023-12-07 22:41:27 +02:00
Yair Morgenstern
612545eec5 Standardized 'spread religion' / 'remove heresy' actions 2023-12-07 19:56:34 +02:00
Yair Morgenstern
c4310fb0f9 Standardized 'spread religion' / 'remove heresy' actions 2023-12-07 19:54:46 +02:00
Yair Morgenstern
8f049f45f1 Standardized 'create improvement' uniques - need to remember to deprecate the water improvements! 2023-12-07 19:47:45 +02:00
Yair Morgenstern
7211c04595
Version rollout (#10678)
* Bump version and create initial changelog entry

* Update Spanish.properties (#10675)

* Update Italian.properties (#10673)

* Update French.properties (#10669)

* Update Polish.properties (#10668)

* Update Dutch.properties (#10666)

* Update Dutch.properties

* Update Dutch.properties

* Update Italian.properties

* Update Russian.properties

* Update German.properties

* Update Swedish.properties

* Update Ukrainian.properties

* Update Brazilian_Portuguese.properties

* Update Catalan.properties

* Update Czech.properties

* Update Filipino.properties

* Update Catalan.properties (#10662)

* Update Brazilian_Portuguese.properties (#10661)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: Lena Bullens <95299589+LenaBullens@users.noreply.github.com>
Co-authored-by: Joan Josep <juanjo.ng.83@gmail.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
2023-12-07 10:13:59 +02:00
Why-not-now
530a537d46
Standardised and fixed deprecration warning (#10672)
* Standardised and fixed deprecration warning

* fixed typo

* standardiswd

* lower cased "as of"
2023-12-07 10:09:42 +02:00
SeventhM
d15c3da0e0
Fix not getting unique unit from tile based free unit trigger (#10665) 2023-12-07 10:09:11 +02:00
Will Allen
8363078371
Connect roads automation (#10631)
* Start on road connect feature.

* Rough UI and tile highlighting

- Highlight visible tiles for selected unit red
-- Maybe change this to all explored tiles
- Move action firing inside WorldMapHolder
- Set begin and end tiles

* Serialize Vector2 instead of Tile

* Add road icon

* Much better UI handling

- Tile highlights go away after choosing a tile
- Added restrictions to allowed tile destination choices.
    - Explored
    - Land
    - Passable
- Added two-tap button

* Refactor part of `onTileClicked` for readability

* Band-aid fix null pointer error

* Add RoadConnection icon

* Tentatively working connect road feature

* AStar search implementation

* AStar connect road automation

* Fix worker getting stuck in city tiles

* Heuristic should be between tiles

* Add heuristic to road connect, remove maxSize limit

* Fix predicates

* Cancel automation when worker is force moved off path

* Change valid/highlighted tiles to be friendly or neutral

* Put log back the way it was

* Fix behavior when kicked off path

* Worker no longer wastes movement points

* Workers will progress multiple tiles at a time towards the next build destination.

* Respect civs with certain tiles as roads

* Refractor ForceAutomateRoadConnection -> AutomateRoadConnection

* Connect road UI button only shows for units with UniqueType.BuildImprovements

* Connect road UI button only show when road tech is unlocked

* Add wagon sound

* Fix destination icon, add KeyboardBinding to 'c'

* UI highlight connect road path tiles orange

* Downsample wagon.mp3

* Apply migration patch, idiomatic sequence processing

* Add notifications on success and failure

* Extract movement cost function to be reusable

* Refactor road pathfinding into MapPathing.kt

* Make pathing calls more general for future extendability

* Add UI road connection tile path preview

* Keep road path highlighting when routing to a city tile

* Adjust road pathing cost function

* Path includes pillaged roads

* Repair pillaged roads along path

* Valid road path tiles now include all passable tiles (open borders)
2023-12-07 09:15:12 +02:00
dHannasch
be2cbbf133
Pass-through exclude and filterUniques, respectively (#10649)
* Update BuildingDescriptions.kt

* Update BaseUnitDescriptions.kt

* Update DescriptionHelpers.kt

* Update BuildingDescriptions.kt

* Update DescriptionHelpers.kt
2023-12-07 09:14:33 +02:00
dHannasch
47e6b788af
Add TechManager.isObsolete(unit) (#10659)
* Update TechManager.kt

* Update CityStateFunctions.kt
2023-12-04 20:26:39 +02:00
dHannasch
8a03f9df12
Rename BaseUnit.techsAtWhichNoLongerAvailable() (#10663)
* Update BaseUnit.kt

* Update BaseUnit.kt

* Update RulesetValidator.kt

* Update BaseUnit.kt
2023-12-04 20:26:15 +02:00
Yair Morgenstern
7e869a3616
Version rollout (#10658)
* Bump version and create initial changelog entry

* Update Simplified Chinese (#10652)

* Update Latin.properties (#10642)

* Update Latin.properties

* Update Latin.properties

* Update Brazilian_Portuguese.properties (#10641)

* Update Spanish.properties (#10639)

* Update Spanish.properties

* Update Spanish.properties

* Update Spanish.properties

* Update Polish.properties (#10636)

* Update Polish.properties

* Update Polish.properties

* Update French.properties (#10635)

* Update Italian.properties (#10634)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: chr_56 <30681738+chr56@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
2023-12-03 22:26:28 +02:00
dHannasch
155498dc43
Wrap BaseUnit.obsoleteTech into function (#10648)
* Update BaseUnit.kt

* Update BaseUnit.kt

* Update TechManager.kt

* Update BaseUnit.kt

* Update RulesetValidator.kt

* Update BasicTests.kt
2023-12-03 22:26:16 +02:00
SeventhM
f8315de414
Add trigger from building improvements and trigger conditional for building improvements (#10644)
* Add trigger from building improvements and trigger conditional for building improvements

* Classic case of the forgotten import

* Fix improvement triggerables saying they aren't allowed and move the trigger to its own function

* include the tile in the civ trigger

* Update core/src/com/unciv/models/ruleset/unique/UniqueType.kt

---------

Co-authored-by: Yair Morgenstern <yairm210@hotmail.com>
2023-12-03 22:16:31 +02:00
dHannasch
c142d1508c
Add iHasUniques.techColumn() (#10595)
* Update IHasUniques.kt

* Update IHasUniques.kt

* Update IConstruction.kt

* Update IHasUniques.kt

* Update CivInfoTransientCache.kt

* Update UnitUpgradeManager.kt

* Update WonderOverviewTab.kt

* Update IHasUniques.kt

* Update IHasUniques.kt

* Update Ruleset.kt

* Update IHasUniques.kt

* Update IHasUniques.kt

* Update IHasUniques.kt

* Update IHasUniques.kt
2023-12-03 22:14:28 +02:00
Oskar Niesen
b9dd32597d
Fixed trading with city-state through notifications (#10645)
* NotificationActions DiplomacyAction no longer allows trading with city-states

* Added a comment
2023-12-03 22:13:30 +02:00
SomeTroglodyte
96dcd584cf
Dev Console: Lint, crash fix, add Stat (#10656)
* Console: linting

* Console: Commands can control message Color

* Console: `civ add gold -1`

* Console: Typo
2023-12-03 22:12:44 +02:00
SomeTroglodyte
5061b29197
Notification for "Policy branch unlocked" clickable (#10655)
* Ruleset-validate some Unique amounts to be positive

* Add TechAction for tech gained from Ruins

* Allow PolicyPickerScreen to highlight a Policy

* Add the 'PolicyAction' NotificationAction

* Use the new PolicyAction
2023-12-03 22:12:26 +02:00
dHannasch
1f47fff05d
Add iHasUniques.requiredTechs (#10587)
* Update IHasUniques.kt

* Update IHasUniques.kt

* Update IConstruction.kt

* Update IHasUniques.kt
2023-12-02 22:56:00 +02:00
dHannasch
7fae32c595
Add iHasUniques.availableInEra() (#10594)
* Update IHasUniques.kt

* Update IHasUniques.kt

* Update IConstruction.kt

* Update IHasUniques.kt

* Update CivInfoTransientCache.kt

* Update UnitUpgradeManager.kt

* Update WonderOverviewTab.kt

* Update IHasUniques.kt

* Update IHasUniques.kt

* Update CityStateFunctions.kt

* Update CityStateFunctions.kt

* Update IHasUniques.kt

* Update CityStateFunctions.kt

* Update CityStateFunctions.kt

* Update CityStateFunctions.kt

* Update CityStateFunctions.kt
2023-12-02 22:54:52 +02:00
dHannasch
55a068d0a0
Add TechManager.isResearched(construction) (#10646)
* Update TechManager.kt

* Update CityStateFunctions.kt

* Update QuestManager.kt

* Update UnitUpgradeManager.kt

* Update Victory.kt

* Update TechManager.kt

* Update TechManager.kt
2023-12-02 22:53:11 +02:00
Yair Morgenstern
75a4f06d03 Converted create/enhance religion actions to new format 2023-12-02 22:45:18 +02:00
Yair Morgenstern
c48584868d Converted Great Person actions to new format 2023-12-02 22:33:54 +02:00
Yair Morgenstern
4c113a9aba
RFC: Direction for converting unit actions to map (#10632)
* Direction for converting unit actions, so that invokeUnitAction() doesn't try to generate *all* possible unit actions just to choose one

* Mapped many unit actions
2023-12-01 11:32:04 +02:00
Yair Morgenstern
37586370ea Resolved #10640 - start turn with unit selected 2023-12-01 10:25:59 +02:00
Yair Morgenstern
f36b05f6c0 Revert "Resolved #10630 - "[relativeAmount]% [stat] from every follower, up to [relativeAmount]%" works off of majority religion, not our religion"
This reverts commit 199b3ada93.
2023-12-01 10:23:17 +02:00
Yair Morgenstern
4b8bef5def
Version rollout (#10633)
* Bump version and create initial changelog entry

* Update Spanish.properties (#10627)

* Update Brazilian_Portuguese.properties (#10616)

* Update French.properties (#10615)

* Update French.properties

* Update French.properties

- Improve translation of leader lines

* Update Italian.properties (#10612)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
2023-11-30 19:44:30 +02:00
SomeTroglodyte
30f3a8f712
Fix crash for trade notifications as Spectator or during waiting for player (#10614)
* Fix crash when tapping a Diplomacy notification for trades as Spectator or during waiting for player

* Fix no tech showing as researched when tapping a Tech researched notification as Spectator
2023-11-30 19:35:18 +02:00
Will Allen
70bbfe14d6
Mitigate #10619 (#10629)
- Clear all unit movement caches upon a road being pillaged
- Log when this happens
- Minor whitespace fixes
2023-11-30 19:13:39 +02:00
SeventhM
01636c27f0
Add "Unable to pillage tiles" unique (#10623) 2023-11-30 19:13:24 +02:00
SomeTroglodyte
4be14d77f4
Fix Unit rename popup offering up the icon's virtual codepoint (#10620)
* Fix Unit rename popup offering up the icon's virtual codepoint

* Fix City rename popup offering up the icon's virtual codepoint
2023-11-30 19:13:11 +02:00
SeventhM
58e5139f35
Fix objects being purchable with a blocking conditional (#10618) 2023-11-30 19:12:58 +02:00