* UniqueParameterType getErrorSeverity/isKnownValue simplification
* Minor changes to a few UniqueType documentations
* Allow UnitsGainPromotion e.g. "[Melee] units gain the [Morale] promotion"
* Reverted spy button to show the spy white icon
* Changed the docs credits
* Espionage button now uses a separate path
* Reverted changing Icons.png
* Changed Espionage.png to the new sprite
* Added behaviours
* Added the behaviours to the docs
* Fixed spelling
* Fixed references to PersonalityValue.Military
* Commented out Personality Behaviours docs and added a message
* Changed the names of some of the new personality behaviours
* Fix Concurrency being zombified but still tasked to run stuff
* Do not tie Android logcat output to whether Gdx was built for debugging
* Simplify GameStartScreen
* Add wiki page on Debugging/Building for Android
* Some linting and region reorder
* Make MultiFilter accept a negated "and" list plus more unit tests
* MultiFilter gets 'or' capability
* Revert "MultiFilter gets 'or' capability"
This reverts commit 9f6e7c794a.
* Expand Events to allow civilopediaText, fixing hidden uniques as side effect
* Fix ConditionalChance save scumming
* Fix ExtraImages not working within mods
* Missing documentation of the changes to Events
* Kdoc to clarify why helper returns nullable
* Lint getJavaClassByName: fix compiler warning and re-sort when
* FormattedLine now throws on problems with extraImage loading
* Fix Tutorial extraImage by removing auto and making it explicit
* Revert "FormattedLine now throws on problems with extraImage loading"
This reverts commit b5ab4084ee.
* Partially revert the revert, so bad extraImage fields are console-logged
* Replace and credit "Link" icon
* UnitActionIcons/Escort is a black version of "Link"
* Reprioritize UnitGroup "action" badge to prefer showing what Workers build over escorting
* Added OneTimeSpiesLevelUp, OneTimeGainSpy, SpyEffectiveness, EnemySpyEffectiveness and HiddenWithoutEspionage Uniques
* Spy effectiveness affects stealing tech and rigging elections
* Fixed HiddenWithoutEspionage
* Added Constabulary and Police Station
* Added cityFilter to SpyEffectiveness
* Added national Intelligence agency
* Added Great Firewall
* Fixed great firewall having a float value
* EspionageManager addSpy now returns Spy instead of name
* Added some simple espionage tests
* Fixed OneTimeSpiesLevelUp still wanting parameter
* Spy efficiency occurs after skill modifier
* Added another test
* Added Police State spy efficiency reduction unique
* Fixed "Hidden when espionage is disabled" wording
* Fixed "effectiveness" wording
* Changed "enemy spy effectiveness" unique to use negative matters
* Spy effectiveness only affect tech steal rate
* Changed "Gain an extra spy" and "Promotes all spies" uniques
* Removed Police State comment that is no longer accurate
* Changed spy effectiveness to be multiplicative
* Minor lint and optimize addWorkBoatChoice
* Moddable findTileWorthImproving search distance
* Don't count bonus resources outside any city work range as worth improving
* Look for existing work boat in a fixed radius instead of city-owned tiles, depending on work boat speed
* Some UnitMovement readability
* Work boat construction and automation code synergies
* Allow for replacement improvements
* imports
* Forgot the most important change, lol
* Docs
* Replacement description, validation, and filter
* Move more into ImprovementDescriptions
* Whoops, forgot to yield
* Fix some copy-paste artifacts
* New translations
* Fix double see also
* Add space for translation engine
* Added configurable natural wonder discovery stats
* Shortened the code
* Updated the base rulesets with new unique
* Updated the El Dorado unique
* Applied the suggestions
* Reintroduced the implementation for deprecated uniques
* Changed tile.naturalWonder to naturalWonder
* Fixed policies do not grant production bonus to wonders
* Added multi-filter and tech filter for buildingFilter
* Rectification of the uniques of monument to the gods and marbles
* Fixed mod checker issued warnings regarding the techFilter in Unit and Building Filters.
* Edit Unique-parameters.md
* Undo 'Fixed policies do not grant production bonus to Wonders
* Add variable Movement Cost
* Add new unique and support code
Modification invalidates the CanTransform
Still has debug
* Make UnitActionStatCost unique syntax
Remove debug code
Improve documentation
* Change text so we can add stockpiles later
* Rework into UnitActionModifier
* Clarifying comments
* rename
* remove bad imports
block if no City for Unit
* Add validation check to other UnitAction Uniques
* add requires and all movement
rework requirement check
* Simplify Transform code
* More efficiency. Add to TriggerUnique
* Allow by default Transform to use all movement
* Add variable Movement Cost
* Add new unique and support code
Modification invalidates the CanTransform
Still has debug
* Make UnitActionStatCost unique syntax
Remove debug code
Improve documentation
* Change text so we can add stockpiles later
* Rework into UnitActionModifier
* Clarifying comments
* rename
* remove bad imports
block if no City for Unit
* Add validation check to other UnitAction Uniques
* add requires and all movement
rework requirement check
* Simplify Transform code
* More efficiency. Add to TriggerUnique
* Allow by default Transform to use all movement
* Code cleanup
* Add variable Movement Cost
* Add new unique and support code
Modification invalidates the CanTransform
Still has debug
* Make UnitActionStatCost unique syntax
Remove debug code
Improve documentation
* Change text so we can add stockpiles later
* Rework into UnitActionModifier
* Clarifying comments
* rename
* remove bad imports
block if no City for Unit
* Add validation check to other UnitAction Uniques
* add requires and all movement
rework requirement check
* Simplify Transform code
* More efficiency. Add to TriggerUnique
* Allow by default Transform to use all movement
* Rework into UnitActionModifier
* remove bad imports
block if no City for Unit
* Code cleanup
* Added ConditionalWhenBetweenStatResource unique
* Currently the ConditionalBetweenHappiness function only applies to Happiness. Wouldn't it be more better if it could also be extended to other stats and resources. 😊
* Resolved the issue with ConditionalWhenAboveStatResource, ConditionalWhenBelowStatResource, and their modified speed versions not functioning properly on city-level stats (food & production).
This new unique has been tested using the following examples:
1. In GlobalUniques.json:
- "[+12]% [Gold] [in all cities] <when between [1] to [100] [Gold]>",
- "[+24]% [Gold] [in all cities] <when between [1] to [100] [Gold] (modified by game speed)>",
2. In Buildings.json:
- "[+12]% [Production] [in this city] <when between [1] to [5] [Production]>",
- "[+12]% [Food] [in this city] <when between [1] to [5] [Food]>",
* Update uniques.md
* Correct english mistake of the new unique
* Refactor checkResourceOrStatAmount function
* Unified all related functions into one
* Make source object available to RulesetErrorList.add
* Make ruleset available to RulesetErrorList
* Introduce UniqueTarget.MetaModifier - ModifierHiddenFromUsers won't stay alone
* There was no use of prefix without the unique name - fold
* Introduce UniqueTarget.MetaModifier - doc
* Pass context down even inside UniqueValidator, convenience factory for limited RulesetErrorList's
* Clean up RulesetErrorList.of factory
* Reorder parameters of RulesetErrorList.add
* Suppression Unique and implementation
* Remove logging
* Terraforming!
* comment
* whoops
* And better tests, that actually output text.
* SomeTrog caught this doc error :)
* Fix natural wonder placement, it better belongs with base terrain
Also, normalize tiles to ruleset after plonking a new terrain
* Out Of Cheese Error, Redo From Start
- Only terrains, no improvements - one problem at a time
- Fit new functional trigger format
- Respect occursOn
- Teleport units out of tiles if they can't pass through (nat wonders for example)
- No need for terrainFeature unique parameter
- Tested with "Turn this tile into a [Grand Mesa] tile <for [0] movement>", "Turn this tile into a [Forest] tile <for [0] movement>" uniques
* Don't allow city tiles to turn into water/wonders etc kudos @SomeTrog
* Documentation for Personality json
* whoops, bad link
* Fix inaccurate "double focus" comment
* Fix accidental copy-paste error
* Edit priority text to maybe be clearer
* Make source object available to RulesetErrorList.add
* Make ruleset available to RulesetErrorList
* Introduce UniqueTarget.MetaModifier - ModifierHiddenFromUsers won't stay alone
* There was no use of prefix without the unique name - fold
* Introduce UniqueTarget.MetaModifier - doc
* Pass context down even inside UniqueValidator, convenience factory for limited RulesetErrorList's
* Clean up RulesetErrorList.of factory
* Reorder parameters of RulesetErrorList.add
* Add additional cityFilters
* Maybe viewingCiv shouldn't be null
* Studio complains it is unnecessary now
* I'm doomed to forget imports
* Ignore this
* typo
* ModOptions reorder into regions, and bring back "internal" fields into the wiki
* Fix two cases of Mod Manager displaying out-of-sync states
* ModConstants and ModConstants.UnitUpgradeCost get equality contracts and a reflection-based shorter merge
* GithubAPI.kt more documentation
* Fix problems with stats from tiles and improvements
* Hold on, we can get the ruleset from the tile. And I was about to complain about that
* Update docs
* Funky null fix
* if else chain doesn't make sense for percent changes on second thought
* Incorporate suggestions
* Use getUnpillagedImprovement functions in matchesFilter
* We don't actually need the whole improvement here, just the name
* Move Golden Age to after all other stats
* Simplify percent stat adds
* Avoid Civilopedia stumbling over missing Grassland
* A few wiki comments on Terrain
* Minor linting of my own crud
* Pedia linking PromotionPickerScreen
* Change actionTypeToFunctions signature to use Sequence
* Uniques: added MayBuyConstructionsInPupets unique for a civ
Gives an ability to buy items (units and buildings) in puppet cities
* Uniques: clear unnecessary whitespaces
* Uniques: typo in a `puppet` word
* Uniques: use city's `getMatchingUniques` instead of civ's `hasUnique` during checking the unique
* Wiki: Remove texture atlas info from the Introduction, minor formatting changes
* Wiki: Add texture atlas info back in under Images-and-Audio, expanded (external tools, settings, encoding warning).
* On second thought...
* Double-check wording for 'game.png is no longer a special boy', ensure game atlas is merged into textureRegions only once
