* Documentation for Personality json
* whoops, bad link
* Fix inaccurate "double focus" comment
* Fix accidental copy-paste error
* Edit priority text to maybe be clearer
* Properly Calculate Population based on Food Conversion to Prod
Trigger properly when Queue is changed
* Remove triggers
* Missed a trigger
* Add triggers in CityConstructionsTable so we can call cityScreen.update()
* Properly Calculate Population based on Food Conversion to Prod
Trigger properly when Queue is changed
* Remove triggers
* Missed a trigger
* Add triggers in CityConstructionsTable so we can call cityScreen.update()
* Make source object available to RulesetErrorList.add
* Make ruleset available to RulesetErrorList
* Introduce UniqueTarget.MetaModifier - ModifierHiddenFromUsers won't stay alone
* There was no use of prefix without the unique name - fold
* Introduce UniqueTarget.MetaModifier - doc
* Pass context down even inside UniqueValidator, convenience factory for limited RulesetErrorList's
* Clean up RulesetErrorList.of factory
* Reorder parameters of RulesetErrorList.add
* Conditional for building in amount of cities
* fix order of operations
* Deprecate old require in amount cities uniques
* import
* Fix referring to the unique instead of the conditional
* Fix yield message
* I have no clue how this isn't imported, but I'mma assume this translates fine anyways
* Rename text for unique
* revert unique text
* Whoops
* Remove unnecessary puppet check
* Move additional description to it own function
* Split missing city text into its own function
* Move ToDo comment
* flip to be easier to read
* Move onlyAvailable rejections to its own function to be easier to work with
* Add in the word "of"
* Barebones implementation
* Personality Policy branch
* Initial addtions to Victory.Focus based changes
* Have no focus or personality if human
* Add getter/setter for easier access to focuses
* Add scaled value to various areas
* Make getPersonality non null to simplify checks
* Forgot to add in changes to the base class
* Ugly code to add in Personality preferred victory type. Not sure how to make it cleaner
* Fix typo
* Early return Faith building choice
* Change set concatination to listOf
* fix missing equal sign
* vals for getPersonality
* Remove unnecessary parenthesis
* Early return the other buildings as well
* Some linting and renames
* Minor linting and fix folder-package mismatch
* Actually make AnimatedMenuPopup stay inside the stage in all directions (was done for bottom left only before)
* Proper keyboard bindings for AutoPlay and -menu
* Testing translations
* AutoPlay as widely used term
* Added getSpiesInCity method in EspionageManager
* Expanded stealing technology code
* Spies can now die and revive
* Added basic rigging elections
* Spies rigging elections can now be caught
* Added spy rank
* Players can now move spies to city-states
* Spies at a higher rank steal tech quicker
* EspionageAutomation now sends spies to city-states and to do counter intelligence
* Fixed some EspionageAutomation logic
* Fixed EspionageAutomation error
* Spy.location is now stored as a vector2
* Accounted for the only able to be one spy of a civ in each city
* Spies level up when successfully stealing tech.
* Increased tech steal rate by spy rank
* Increased influence gained by rigging elections
* Added a spy level cap
* Spies no longer get stuck on counter-intelligence action
* Spy automation no longer tries to rig elections in city states that it is at war with
* canMoveTo now checks if the city tile is visible
* Added espionage translations
* Changed automateSpySteal/Rig/Counter intelligence return types
* Simplifies automateSpies in EspionageAutomation
* Added blank lines before titles
* Improved spy being found and killed message phrasing
* Adapt Overview Politics diagram view to show a defeated player a little more intuitively
* Fix lines to defeated civ - each is drawn twice, one for each direction
* Defeated civ has no relations on the table view as well
* Fix captured civilian liberation in the had-to-be-teleported case
* Refactor captureOrConvertToWorker to return where the unit ended up, if at all - and harden the captureCivilianUnit else branch a bit
* Minor lint
* Reworked ThreatManager to be optimised for getTilesWithEnemyUnitsInDistance
* Refactored and added an exception
* doesTileHaveMilitaryEnemy now searches all military units on the tile and not just the unit in the military slot
* Fixed some errors
* Refactored getTilesWithEnemyUnitsInDistance to use a mutableIterator
* Added some more comments
* Players can't move spies when it is not their turn
* Inversed the statement to have the proper behavior.
* Update core/src/com/unciv/ui/screens/overviewscreen/EspionageOverviewScreen.kt
---------
Co-authored-by: Yair Morgenstern <yairm210@hotmail.com>
* Add additional cityFilters
* Maybe viewingCiv shouldn't be null
* Studio complains it is unnecessary now
* I'm doomed to forget imports
* Ignore this
* typo
* Fix gain stat modifier by speed unique action text
* Whoops, should be toInt toString
* I can't escape forgetting imports
* OneTimeGainStatRange also uses modifiers
* As discussed - we currently update on every happiness change, we can limit this to only update all cities if we pass a happiness threshold that is relevant to *some* unique
* Forgot a conditional, and uniqueified results
* Linting
* Dynamic redistribution of buttons on cramped displays
* Merge the default two pages if they're near empty
* Keyboard bindings independent of button visibility
* Remove caching todo - impossible unless we can guarantee no state change caused outside this class goes undetected - even full equality contract on MapUnit may not be enough
* Workers now build forts
* Workers prioritise other tiles over removing forts
* Units don't pillage forts
* Increased how close a city has to be to be viable for fort building
* Decreased fort value, especially for allied city-states
* Units no longer prioritise pillaging forts instead of not pillaging them at all
* Unify unit and civ triggers
* Update conditionalsApply check
* add tile in the city override
* Add StateForConditionals for unit uniques when founding a city
* Accidentally removed unit triggers from uponBuildingImprovement
* Accidentally removed parenthesis
* add "tile = tile" to improvement trigger's StateForContitionals
* Add unit's tile to default tile
Co-authored-by: Yair Morgenstern <yairm210@hotmail.com>
* Accidentally did getMatchingUniques instead of getTriggeredUniqued
* Merge triggerUnitWideUniques into TrigerUniques
* checkOnGameInfo Helper to shorten line length
* StateForConditionals secondary constructors
* accidentally deleted
* also accidentally deleted
---------
Co-authored-by: Yair Morgenstern <yairm210@hotmail.com>
* ModOptions reorder into regions, and bring back "internal" fields into the wiki
* Fix two cases of Mod Manager displaying out-of-sync states
* ModConstants and ModConstants.UnitUpgradeCost get equality contracts and a reflection-based shorter merge
* GithubAPI.kt more documentation
* Refactor and rewrite raiseMountainsAndHills to allow hill and mountain uniques on land+feature terrain types
* Optimize chooseSpreadOutLocations
* Optimize MapLandmassGenerator's retries for water proportion / large continent count
* Improved AirUnitAutomation
* UnitPriority now has special cases for air units
* Fighters now Air-sweep
* Added extra air sweep logic
* Moved airSweepDamagePercentBonus to AirUnitAutomation.kt
* Civilizations now send their spies out
* Idle spies move to a city even if there is no tech to steal
* Fixed moving spies
* Game doesn't crash when the city the spy was at is taken over
* Fixed crash when no other city is viewable
* Spies no longer go to city states again
* Added a new line for the test
* Spies are now removed from a city when it is captured
* Split FreeGreatPerson and MayanGainGreatPerson
* Add null check to mayan great person
* Move to NextTurnAutomation to be easier to edit
* Move code fromUniqueTriggerActivation to GreatPersonManager
* Remove unnecessary civInfo.greatPeople
* Linting (and prioritize addGiftAction efficiency over the get used only by unit test)
* Move "paging" out of MapUnit, drop Normal/Additional getter split, "page" preference via UnitActionType
* Optimize UnitActions API a little - fallback does not enumerate actionTypeToFunctions again
* Cleaner access to GiftUnit action from unit test
* Allow freely switching from Sleep to Sleep-until-healed and back
* Allow units to upgrade to more than one unit
* Actaully add changes to Base Unit
* And actually add the unique
* Kdocs fixes
* upgradeUnits to getUpgradeUnits and add missing state for condititonalss
* unique.params[0] shouldn't be empty..., right?
* Make old var first in the list, in case it matters
* wait... We're never yielding a null result
* Remove unnecessary function call
* Remove some indentation in RulesetValidation
* isEmpty instead none
* min cost instead of first
* Ruleset helper functions
* Imports
* helper functions part 2
* sanity check in case the unit actually isn't upgradable here
* I missed a spot
* This is NOT using a filter, itis looking for a unitName. Also, why do we use "unit" instead of "unitName"?
* Avoid crash in Scene2dExtentions, part 1
* Avoid crash in Scene2dExtentions, part 2
* inevitable request to move it to its own function
* Upgrade to the correct unit when upgrading all units
* Kdocs I overlooked
* Whoops
* Revert kdocs changes
* Should probably make sure action isn't null
* Fix loop in checkUnitRulesetInvariant
* Minor irrelevant fix
* No response, Removing getUpgradePath part 1 as it's redundant if we upgrade one at a time
* Move to UnitAutomation
* Imports
* Irrelevant fix: ignore consturctionRejections for upgrades
* Irrelevant fix: We should be able to upgrade to obsolete units, just not build new ones
* Simplify for clarity
* Irrelevant fix: unit is not destroyed is it doesn't upgrade
* Whoops
* Imports
* Remove getUpgradePath part 2: simplify UnitAutomation
* Remove now unnecessary circular reference check. We already check if it upgrades to itself
* Whoops, if we use a special upgrade, we should go back to a normal upgrade if we find no special upgrade unique
* Basic tests for last commit
* Forgot special to normal upgrade test
* whoops, forgot to change comment
* Not at computer: List.isEmpty to Sequence.none
* Not at computer: List.size to Sequence.count()
* Spectators now use the colors of the selected civ instead of the viewing civ
* Spectator now sees all city construction, growth bars and nation icons
* Fix problems with stats from tiles and improvements
* Hold on, we can get the ruleset from the tile. And I was about to complain about that
* Update docs
* Funky null fix
* if else chain doesn't make sense for percent changes on second thought
* Incorporate suggestions
* Use getUnpillagedImprovement functions in matchesFilter
* We don't actually need the whole improvement here, just the name
* Move Golden Age to after all other stats
* Simplify percent stat adds
* Console: History remembers only _changed_ command lines
* Console: New command sethealth, allow setmovement without argument to set max movement
* Console: All object name comparisons on the "CliInput" level so multiword or varying-case input is recognized properly
* Console: Autocomplete change so continuation is easier: Don't add space if there were alternatives, output CliInput-style
* Console: Autocomplete religions - only from the actually founded ones (but we could easily add ruleset.religions - a '+' would be distinct already)
* Console: Intelligent autocomplete promotions in `unit addpromotion`
* Console: Treat all warnings
* Console: Split off a few classes
* Console: Forgot to treat a reminder - fix crash on `unit addp<tab><tab>`
* Console: setterrain, setresource, consequences of tile changes
* Console: Revert normalizeToRuleset 'safety net' calls
* WorkerAutomation now caches the roads to use
* Workers now build roads differently
* Fixed error if unit movement is zero
* Fixed civ researching an unwanted tech in a test
* Fixed spelling
* Increased road building priority
* getRoadConnectionBetweenCities no longer does unnecessary sorting
* roadsToConnectCitiesCache no longer stores roads that are already built
* ChooseImprovement now builds roads on resource tiles!
* Fixed tryConnectingCities error related to using minByOrNull instead of firstOrNull
* Roads can't have a negative value if they are bigger
* Avoid Civilopedia stumbling over missing Grassland
* A few wiki comments on Terrain
* Minor linting of my own crud
* Pedia linking PromotionPickerScreen
* Change actionTypeToFunctions signature to use Sequence
* Uniques: added MayBuyConstructionsInPupets unique for a civ
Gives an ability to buy items (units and buildings) in puppet cities
* Uniques: clear unnecessary whitespaces
* Uniques: typo in a `puppet` word
* Uniques: use city's `getMatchingUniques` instead of civ's `hasUnique` during checking the unique
* Experimental pathfinding - still not good enough for main branch
* Fixed strange pathfinding and impassible tiles
* Fixed weirdest bug in the history of weird bugs - remove() on an object did not remove the object
* Avoid damaging and enemy tiles for new pathfinding
* Add option for activating experimental movement
* Allow almost any mod zip download source
* Linting
* Add basic "Release page section" link capability, more linting
* Refactor: Move Github to logic
* Refactor: Split Github into files
* Refactor: centralizing all API knowledge
* Try bumping detekt version to fix false complaint
* Attempt to trick detekt to not complain about `it`
* Better overload-ambiguity-solving + detekt-compatible SAM use
Without this, when you get a mid-turn free tech like Oxford University,
the units in city queues are updated but the hammers aren't carried
over from the obsolete unit until the end of turn. This means that to
the player it shows 0 progress for all the new units in queue and
appears like the progress from obsolete units was lost which can be
disconcerting and makes strategizing during that turn difficult.
* Wiki: Remove texture atlas info from the Introduction, minor formatting changes
* Wiki: Add texture atlas info back in under Images-and-Audio, expanded (external tools, settings, encoding warning).
* On second thought...
* Double-check wording for 'game.png is no longer a special boy', ensure game atlas is merged into textureRegions only once
* Add unique to allow for generalized great generals
* Don't add compatibility for rulesets with conditional generals
* Add to rulesets
* add in pre Kotlin 9 parenthesis
* whoops missed a parenthesis
* I guess pre Kotlin 9 parenthesis was unnecessary, whoops
* Add back old variables to clone function
* Move the list of all potential generals to Ruleset
* Move list of unit construction rejections to IConstruction
* flip !any{} to none{}
* Fix imports
* Typo
* Add Gold Growth and Production Growth Focus
New Manual Focus doesn't reallocate population
* Use Stat Names (and symbols) for focus
* Missing reassign code
* Clean up table for efficiency
* Table v2
* minor translation changes
* COMPATIBILITY
* v3 table
* Minor fixups
* Add Gold Growth and Production Growth Focus
New Manual Focus doesn't reallocate population
* Use Stat Names (and symbols) for focus
* Missing reassign code
* Clean up table for efficiency
* Table v2
* minor translation changes
* COMPATIBILITY
* v3 table
* Minor fixups
* Update to master code
Remove duplicating Food yield multiply
* Revert Compatibility Version
---------
Co-authored-by: itanasi <44038014+itanasi@users.noreply.github.com>
* AI prioritises gifting gold to city-states with more influence invested
* AI only gives smaller city-state gold gifts if it already has influence
* AI prioritises gifting gold to city-states with the investment quest
* Only UseGoldAutomation includes valuing if the city-state has a quest
* WorkerAutomation now uses UnitAutomations's getDangerous tiles
* getPriority now values the current unit tile
* getPriority now values if the tile is worked instead of if it provides a yield
* getPriority prioritises clearing fallout
* getPriority prioritises new resources
* Fixed error in WorkerAutomationTest
* FindTileToWork now uses tilesToAvoid instead of checking for enemies itself
* Workers prioritise their own tile first
* Began reworking tile priority
* Changed getBasePriority() to account for tile damage
* findTileToWork now groups tiles and finds the best tile from the top group
* Fixed method calling findTileToWork()
* Workers don't build roads if their GPT is below 20
* Workers have multiple stages of wanting to connect cities
* Workers prioritise best tiles based on closeness
* Changed stuff
* Fixed a situation where a worker would be on a tile without improving it
* Reduced city connection priority
* Worker prioritises improving closer tiles more
* Worker prioritises improvements that are closer to being finished
* Reverted changes that broke tryConnectingCities more (it is already a little broken)
* Improved repair priority
* Added cityDistanceWant to tryConnectingCities
* Created a partial Test
* Finished first test
* Fixed a merge issue
* Fixed tileHasWorkToDo not accounting for base improvement values
* Added a failing test
* CityPopulationManager now assigns population to tiles in a predictable way for the Worker BasePriority tileProvidesYield
* Added an extra test with two cities and no roads
* Fixed Test creating new workers which ends up failing the test
* Test no longer research and have unnecessary research
* Test no longer include city center tiles as improvements built
* Added a failing test and removed a tryConnectCity filter
* Workers now improve tiles with unseeable resources on them
* Added a resource test
* Fixed should build roads in turns test
* Added an extra test
* tryConnectingCities takes into account the improvement priority
* Separated the improvement stat bonus from the base priority for tryConnectCities
* getBasePriority() now ranks a tile based on its base stats
* replaced mostUnderdevelopedCity with closestUnderDevelopedCity
* changed build road distances wanted
* getImprovementRanking now accounts for resources
* tilePriority now uses a float instead of an int
* Fixed float to int conversion in SpecificUnitAutomation
* Added a test for pillaging
* AI now does not offer a defensive pact/open border/research agreement if there is a pending counter offer with it
* Moved searching for a pending trade offer to a new function
* Bump version and create initial changelog entry
* Update Spanish.properties (#10780)
* Even more translations of Malay.properties (#10778)
I plan to finish the UI section this week. Honestly, going through and skimming a bit I've seen things I've never seen in game.
* Update Brazilian_Portuguese.properties (#10775)
* Some German translations (#10772)
* Update French.properties (#10768)
* Update Italian.properties (#10767)
---------
Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: Mikhail <151419244+MetaFBMI@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: SomeTroglodyte <63000004+SomeTroglodyte@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
* Added a new AutoPlay until end button
* Added the new AutoPlay until victory setting to translation
* Reverted some comment fixes to hopefully not have a merge conflict
* Mod compatibility - update declarations
* Mod compatibility - logic and UI changes
* Mod compatibility - flag some invalid use patterns
* RulesetValidator - lint until Studio shuts up
* Fix isBaseRuleset test in ModRequires validation
---------
Co-authored-by: Yair Morgenstern <yairm210@hotmail.com>
* Add Gold Growth and Production Growth Focus
New Manual Focus doesn't reallocate population
* Use Stat Names (and symbols) for focus
* Missing reassign code
* Clean up table for efficiency
* Table v2
* minor translation changes
* COMPATIBILITY
* v3 table
* Minor fixups
* Refactor Battle damage shadowed Label into reusable WidgetGroup
* Make Politics Overview "Grid header" fixed and some linting
* Add a Legend popup explaining line colors in the Politics Overview Diagram: Click inside
* Missing translation template
* Final decision on background didn't make it in properly
* Remove unused png - those are now in the Construction atlas
* Smaller background image
* Color and shadow choices
* Redo atlas to include both 10505 and this
* Reorganize - restore meaning to existing regions, sort fields into regions, treat warnings
* Reorganize - double-check pure/side-effect regions and move inappropriate placements
* new algo for coast placement
* optimization?
* change default max coast extension
* put spreadcoast in a function
* default change back, nextBoolean() and for loop
Change BattleTable to calulate average damage and show alongside the min
and max for easier calculations when planning to attack with multiple
units such as when sieging a city
Unfortunately for min-maxers the randomness is still turn dependent
for a given defending unit, so the damage randomness will not average
out across multiple attacks on a given turn but they will all be more or
all be less depending on the luck that turn.
* Add another confirmation when buying a religious unit in a city that doesn't follow a religion founded by the city's civ.
* There's other stuff that can be purchased with Faith. Better to use UniqueType.Religious unit I guess.
* Add string to template.properties
* One more space to make unit tests happy
* Better template.properties
* Reinsert trailing space
* Introduce Constants entry for "Cancel"
* Redo ConfirmBuyPopup
* Dev console command to tweak religion pressures
* Translation templates and one test
---------
Co-authored-by: SomeTroglodyte <63000004+SomeTroglodyte@users.noreply.github.com>
* fractal map type
* repeat create fractal until enough land
* small changes and add map types Lakes and Small Continents
* fix for removing land at edges of hexagonal maps
* readability
* Change per-City GPP points math and separate breakdown (producer w/ source doc) from aggregates (consumer ignoring source)
* Change CityScreen GPP list to not do aggregation itself, but show a breakdown on click
* Change "birth" city for GPP to a ***weighted*** random - no Great Mufties from cities not generating any Mufty points!
* Nicer signature for getGreatPersonPointsBreakdown
* Minor warnings linting and template for Sweden's bonus in the breakdown Popup
