mirrors/Unciv
1
0
Fork 0
mirror of https://github.com/yairm210/Unciv.git synced 2025-02-09 10:29:02 +07:00
Code Issues Packages Projects Releases Wiki Activity
9,142 Commits 6 Branches 1,050 Tags 1.1 GiB
545ff0b944
Commit Graph

6173 Commits

Author SHA1 Message Date
SomeTroglodyte
fcd309781d
Upgrading from Unit overview improved (#9485) 
* Unit upgrade tooltip in overview

* Unit upgrade tooltip in action table

* Unit upgrade tooltip in action table - colored Key

* Unit upgrade in Overview - reselect

* Fix merge problems and FormattedLine color markup ability

* Relax MarkupRenderer.render lines parameter type

* Skin has a getColor shortcut - use it

* Unit overview upgrade icons now open a menu instead of upgrading immediately

* Unit Overview upgrade - "Mid" buttons

* Unit Overview upgrade - reorg
 2023-05-31 18:41:57 +03:00
Yair Morgenstern
b851abc7fd Guard against '><' causing translation recursion 2023-05-31 15:21:49 +03:00
Yair Morgenstern
90da09e924
Version rollout (#9491) 
* Bump version and create initial changelog entry

* Update German translation (#9489)

* Update Polish.properties (#9480)

* Update Polish.properties

* Update Polish.properties

* Update French.properties (#9479)

* Update Japanese.properties (#9478)

* Update Japanese.properties
Testament of Faith

* Update Japanese.properties
Enhancer of Faith

* Update Japanese.properties
Religions

* Update Japanese.properties
some Faith Description

* Update Japanese.properties
add Faith Description

* Update Japanese.properties
delete comment

* Update Spanish.properties (#9474)

* Updated Brazilian_Portuguese.properties (#9473)

* Update Italian.properties (#9470)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: mape6 <mape6@posteo.de>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: undo <3245867+undoroid@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
 2023-05-31 14:58:28 +03:00
Yair Morgenstern
ce6d3394bc
Added checksum to be added to uploaded multiplayer games (#9483) 
* Added checksum to be added to uploaded multiplayer games

* Policy adoption triggers resource recalculation
 2023-05-31 14:58:00 +03:00
SomeTroglodyte
de09eda043
Politics overview no longer discloses random number of players (#9466) 
* Linting

* Hide player count in politics overview diagram legend if randomized

* Comment on getKnownCivs
 2023-05-31 14:52:05 +03:00
SomeTroglodyte
2c1d413b6c
Unit Overview: Improving a tile is also "what the unit is doing" (#9482) 
* Unit Overview: Improving a tile is also "what the unit is doing"

* Unit Overview automated worker actions
 2023-05-31 14:50:42 +03:00
SomeTroglodyte
9302036311
Replacement PlatformSaverLoader for Linux X11 systems (#9490) 2023-05-31 14:43:31 +03:00
janarvid
ff9d5ff9c1
Fix bug worker will not replace improvement to enable strategy resour… (#9449) 
* Fix bug worker will not replace improvement to enable strategy resources #9328

* Make test logic more clear and add some comments
 2023-05-28 17:52:37 +03:00
SomeTroglodyte
73aeabec2c
All notifications from Overview are now temporary (#9455) 
* Refactor notification history re-show functionality

* Refactor explored resources notification generator

* Refactor "Unimproved" to use existing providesResource

* Make overview resource "links" into temporary notifications

* Added link to overview resource "Unimproved" column

* Minor linting
 2023-05-28 17:51:33 +03:00
Yair Morgenstern
d7b6fea2d4 Spectators do not get natural wonder discovery notifications 2023-05-28 09:24:33 +03:00
Yair Morgenstern
ae4719c552
Version rollout (#9469) 
* Bump version and create initial changelog entry

* Update Polish.properties (#9465)

* Update Polish.properties

* Update Polish.properties

* Update Polish.properties

* Update Italian.properties (#9464)

* Update Italian.properties

* Update Italian.properties

* [Translation] Update Simplified Chinese translation (#9452)

* update Simplified Chinese

* update Simplified Chinese

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: chr_56 <30681738+chr56@users.noreply.github.com>
 2023-05-28 09:00:01 +03:00
SomeTroglodyte
9739374e17
Update civ resources when a researched tech reveals a resource (#9467) 2023-05-28 08:39:36 +03:00
SomeTroglodyte
ef193babee
Map editor update - concurrency, resource amounts, file double-click (#9461) 2023-05-27 21:44:23 +03:00
SomeTroglodyte
1c124c9ddf
Fix UniqueType.RoadMaintenance being ignored (#9456) 2023-05-27 21:44:03 +03:00
SomeTroglodyte
c73d5d74d0
Fix mouse wheel on NotificationsScroll (#9451) 
* Fix mouse wheel on NotificationsScroll

* Explain why getMouseWheelX is overridden to zero
 2023-05-27 21:32:51 +03:00
SomeTroglodyte
268d27d1ed
Unit overview remembers scroll position after promoting (#9454) 2023-05-27 21:32:23 +03:00
Yair Morgenstern
8be9cd6a76 Modding: units can transform without limit on destination unit 2023-05-24 11:46:31 +03:00
Yair Morgenstern
6f830a33a9 Merge branch 'temp' 2023-05-24 11:46:05 +03:00
Yair Morgenstern
d9b62fbf3e 4.6.14-patch1 2023-05-24 11:45:55 +03:00
Yair Morgenstern
133704282c Merge branch 'temp' 2023-05-24 11:43:39 +03:00
Yair Morgenstern
4ef33b84e5 4.6.14-patch1 
Fix AI automation preventing settlers from moving
 2023-05-24 11:42:42 +03:00
Yair Morgenstern
00b52851f3 Unpurchaseable units are properly unpurchaseable 2023-05-24 00:16:49 +03:00
alexban011
0d76ae1e3c
feat: allow loading of games if there are no saved games (#9441) 2023-05-23 23:15:37 +03:00
Yair Morgenstern
5fcfa6ac2d Resolved #9444 - Crop yield chart no longer displays score data 2023-05-23 23:12:04 +03:00
Yair Morgenstern
e75742d3d6 Fixed policy branch finishers overriding branches - oops! 2023-05-23 22:37:10 +03:00
Yair Morgenstern
35718c00e7 Fixed softlock for mod policies overriding existing policy locations 2023-05-23 22:15:31 +03:00
Yair Morgenstern
b94321f535 4.6.14 2023-05-23 20:37:51 +03:00
Yair Morgenstern
5857301732
Version rollout (#9440) 
* Bump version and create initial changelog entry

* Update German translation (#9437)

* Update Spanish.properties (#9434)

* Update Brazilian_Portuguese.properties (#9433)

* Update French.properties (#9426)

* Update Italian.properties (#9422)

* Update Japanese.properties (#9346)

* Update Japanese.properties

* Update Japanese.properties

* Update Japanese.properties

* Update Japanese.properties

*Add translations
*Add city names

* Update Japanese.properties

*Add new translations
*Fixed some translations regarding tile improvements that I have translated previously

* Update Japanese.properties

*Add translation for City-Nations messages, ruin-regarding messages, and more.

* Update Japanese.properties

Add translations for 
*Sweden, Austria, and some city-states
*Multiplayer Game notifications
*Tile Improvements
*Civilopedia explanations

* Update Japanese.properties

Add translations for
*Religion beliefs
*Civilopedia descriptions
*Victory status
*and more

* Update Japanese.properties

* Edit details

* Update Japanese.properties

*add new branches

* Update Japanese.properties

Fix wrong placeholders

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: mape6 <mape6@posteo.de>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: namazulake <130637228+namazulake@users.noreply.github.com>
 2023-05-23 20:33:10 +03:00
Yair Morgenstern
7aea703fcc Resolve #9432 - city-state-owned great merchants can no longer 'conduct trade mission' on their own tiles 2023-05-23 19:41:41 +03:00
Yair Morgenstern
472bb55b40 Resolve #9435 - don't crash for ByteBuffer byte errors 2023-05-23 19:29:06 +03:00
SomeTroglodyte
b3166c4922
Fix ConcurrentModificationException when puppeting a city (#9430) 2023-05-22 20:12:31 +03:00
SomeTroglodyte
5f60c887f7
Next-Turn Progressbar (#9409) 
* Next-Turn Progressbar

* Next-Turn Progressbar - doc

* NextTurnProgress: Rethink max on first turn
 2023-05-22 17:59:28 +03:00
Yair Morgenstern
575983578a
Game saves are regular json, not minimalized json (#9427) 2023-05-22 17:57:56 +03:00
Yair Morgenstern
edd09910a1 AI civilian improvement: Don't freeze when enemy is near, keep working in tiles where he can't reach 2023-05-22 14:31:49 +03:00
Yair Morgenstern
fc81d7dda3 Units that can enter foreign lands without open borders are not expelled on open borders end 2023-05-22 14:31:43 +03:00
SomeTroglodyte
ae8d69b5b3
Resolve To-do in Unit upgrade resource requirements (#9420) 
* Update Counter get() nullability

* Counter upgrade

* Use Counter for unit resource requirements

* Linting
 2023-05-22 14:28:36 +03:00
Yair Morgenstern
e2b3432d84
Population icon gets locked with doubleclick, clicks cycle between assigned and unassigned (#9428) 2023-05-22 14:27:00 +03:00
Yair Morgenstern
95ffbd6a6e 4.6.13 2023-05-21 14:16:50 +03:00
Yair Morgenstern
9c2a9975a6
Version rollout (#9418) 
* Bump version and create initial changelog entry

* Update Greek.properties (#9407)

* Update Spanish.properties (#9397)

* Update Indonesian.properties (#9393)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: marek06072 <133993044+marek06072@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: t <73392607+tsaqibfs@users.noreply.github.com>
 2023-05-21 14:08:49 +03:00
Yair Morgenstern
280025fa10 Resolved #9416 - failure to get preview image no longer causes crash 2023-05-21 12:35:57 +03:00
SomeTroglodyte
a91dca0930
Fix off-by-one error in autoAssignPopulation (#9411) 
* Fix off-by-one error in autoAssignPopulation

* Fix more off-by-one errors from for-repeat conversions

* Linting: Use Actions.forever shortcut where appropriate
 2023-05-21 12:08:03 +03:00
SomeTroglodyte
ec4586af6c
Fix Ensure Minimum Stats (#9408) 2023-05-21 00:13:50 +03:00
Yair Morgenstern
728afab1db Modding: Added 'upon adopting [belief]' trigger, allowed belief adoption to trigger uniques 2023-05-19 00:22:34 +03:00
Yair Morgenstern
6841a7f214 Added turn number to victory replay 2023-05-19 00:06:03 +03:00
alexban011
6603c6cfd0
refactor: break large functions into smaller ones (#9406) 2023-05-18 22:02:26 +03:00
alexban011
54f651c2fb
fix: fixed translation text (#9404) 
* fix: fixed translation text

* fix: fixed Romanian.properties
 2023-05-18 18:30:17 +03:00
alexban011
91116f8df3
Fixed more warnings (#9401) 
* fix: fix FunctionParameterNaming warnings

* fix: fix InvalidPackageDeclaration warnings

* fix: fix MatchingDeclarationName warnings

* fix: fix WrongEqualsTypeParameter warnings

* fix: fix UnusedPrivateProperty warnings

* fix: fix UseCheckOrError warningsU

* fix: fix UseRequire warningsU

* detekt: disabled SpreadOperator rule

* fix: resolve MemberNameEqualsClassName rule

* detekt: disabled ForbiddenComment rule

* fix: resolved SwallowedException warning

* fix: resolved ThrowingExceptionsWithoutMessageOrCause warning

* fix: resolved EmptyFunctionBlock warning

* fix: resolved EmptyFunctionBlock warning

* fix: resolved InstanceOfCheckForError warning

* detekt: disable TooGenericExceptionCaught warning

* detekt: disable TooGenericExceptionThrown warning

* fix: resolve part of NestedBlockDepth warnings
 2023-05-18 10:12:33 +03:00
SomeTroglodyte
d31a2d83ba
Happiness change from bought buildings can reapply citizen focus (#9395) 
* Happiness change from bought buildings can reapply citizen focus

* Fix compilation error
 2023-05-18 00:37:38 +03:00
SomeTroglodyte
1de866c7ed
Local and/or jpg mod previews (#9394) 
* Allow mod preview image to be a jpg

* Allow preview images from WIP mods lacking github url

* Wiki preview.jpg

* Allow mod preview image to be a jpg - review
 2023-05-16 13:00:44 +03:00
Yair Morgenstern
7f4b7bbd21 Resolved #9391 - clicking locally-added mods no longer crashes 2023-05-15 09:22:21 +03:00
SomeTroglodyte
6d185ea5a5
Fix UnitTable layout (#9392) 2023-05-15 09:09:39 +03:00
Yair Morgenstern
fc222ca4cf 4.6.12-patch1 2023-05-14 23:37:42 +03:00
Yair Morgenstern
5fe8fbf99a Mod preview images: Dispose of Pixmap, cache images for later use 
Based on CR by @SomeTroglodyte
 2023-05-14 23:33:58 +03:00
Yair Morgenstern
4a7f65f281 4.6.12 2023-05-14 22:03:40 +03:00
Yair Morgenstern
3879f18288
Version rollout (#9388) 
* Bump version and create initial changelog entry

* Update Italian.properties (#9381)

* Update Italian.properties

* Update Italian.properties

* Update French.properties (#9378)

* Update Polish.properties (#9377)

* Updated Brazilian_Portuguese.properties (#9376)

* Update German translation (#9373)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: mape6 <mape6@posteo.de>
 2023-05-14 21:55:54 +03:00
alexban011
841a1aa564
ci: improved detekt configuration and ci (#9380) 
* ci: improved detekt configuration

it still needs some work but it's getting there

* detekt: separated errors from warnings

Detekt doesn't currently have a mechanism for failing only on specific issues

workaround suggested by the maintainer of Detekt

* rebased on master

* fix: resolve ExplicitItLambdaParameter

* fix: fix last star import
 2023-05-14 21:55:36 +03:00
SomeTroglodyte
ae13f32f72
Animate battle damage numbers (#9387) 
* Animated battle damage numbers 001

* Animated battle damage numbers 002

* Animated battle damage numbers 003

* Animated battle damage numbers 004
 2023-05-14 21:52:15 +03:00
Yair Morgenstern
e6135fa486 Display map ruleset when picking map, don't show unloadable maps 2023-05-14 21:51:19 +03:00
Yair Morgenstern
5bbd8bce53 Allow mods to contain a "preview.png" file for visual indication 2023-05-14 14:36:46 +03:00
Yair Morgenstern
48bd416347
Multi-server preparations: Save server info in game, save server functionality in specific class (#9379) 
* Save server info in game

* Moved server functionality into server class

* Fix Android multiplayer update
 2023-05-13 21:51:44 +03:00
SomeTroglodyte
97769b89b6
Combat java.util.star-import (#9382) 2023-05-13 21:50:55 +03:00
Yair Morgenstern
d2eaae0922
4.6.11-patch1 (#9375) 
* Convert 'camps' vectorhashmap to 'encampments' arraylist

* Solve camps For Real This Time
Previous solution was only taking the first item of the class, not all of it

* 4.6.11-patch1
 2023-05-11 16:54:37 +03:00
Yair Morgenstern
dde3732383
Convert 'camps' vectorhashmap to 'encampments' arraylist (#9374) 2023-05-11 16:51:29 +03:00
Yair Morgenstern
9a0ba7dcd8 4.6.11 2023-05-11 13:53:12 +03:00
Yair Morgenstern
3f2dd3614f
Version rollout (#9372) 
* Bump version and create initial changelog entry

* Update Indonesian.properties (#9371)

* Update Brazilian_Portuguese.properties (#9352)

* Update Russian.properties (#9351)

There was a letter missing in the word

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: t <73392607+tsaqibfs@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: iliademid21 <132929464+iliademid21@users.noreply.github.com>
 2023-05-11 13:50:21 +03:00
SomeTroglodyte
2ef5ed14e1
Fix 4.6.10 no longer loading older games (#9370) 
* Fix 4.6.10 no longer loading older games

* Save games with correct current version info
 2023-05-11 13:01:00 +03:00
Crsi
3e4ba83bcc
Added a fix for #7380 to complete a game turn and set upToDate for last human player (#9366) 2023-05-10 22:18:26 +03:00
SomeTroglodyte
d4af4e1053
Policy images in red text, policy branch icons in pedia (#9365) 2023-05-10 14:36:50 +03:00
alexban011
f3e80a4021
Fixed a couple warnings reported by code analysis (#9364) 
* fix: resolve EmptyCatchBlock warnings

* fix: resolve PrintStackTrace warnings

* fix: resolve SwallowedException warnings

* fix: resolve ThrowingExceptionsWithoutMessageOrCause warnings

* fix: resolve ConstructorParameterNaming warnings

* fix: resolve FunctionParameterNaming warnings

* fix: resolve InvalidPackageDeclaration warnings

* fix: resolve ForEachOnRange warnings

* fix: resolve ImplicitDefaultLocale warnings

* fix: resolve MayBeConst warnings

* fix: resolve NewLineAtEndOfFile warnings

* fix: resolve UnusedParameter warnings

* fix: resolve UtilityClassWithPublicConstructor warnings

* fix: resolve WildcardImport warnings
 2023-05-10 11:43:53 +03:00
SomeTroglodyte
1df7ee46ac
Prevent some state changing actions during next-turn (#9327) 
* Prevent some state changing actions during next-turn

* Direct canChangeState
 2023-05-10 11:39:48 +03:00
Yair Morgenstern
341c290ce4 Resolved #9357 - update UI after founding city when breaking promise 2023-05-10 10:34:44 +03:00
Yair Morgenstern
be20c917cc 4.6.10-patch2 
Resolved #9363 #9356 - solved font crash exception
 2023-05-10 10:28:44 +03:00
Skekdog
a3ef6fa314
Add May not annex cities unique (#9314) 
* Add `May not annex cities` unique, following same behaviour as Civ5 Venice. Hopefully this time I won't need to re-install windows.

* Add `May not annex cities` unique, following same behaviour as Civ5 Venice. Hopefully this time I won't need to re-install windows.

* Fix raze button being unavailable in city screen

* Fixed raze button being available in city screen, as per civ5

* Corrected indentation

* mayAnnex instead of canAnnex, hasUnique rather than getMatchingUniques

* AI will follow rules

* Replaced getMatchingUniques with hasUnique, for real this time
 2023-05-09 23:02:19 +03:00
Yair Morgenstern
203477eca1 4.6.10-patch1 2023-05-08 21:01:23 +03:00
Yair Morgenstern
ed2c294c6f
Version rollout (#9350) 
* Bump version and create initial changelog entry

* Update Italian.properties (#9347)

* Update Italian.properties

* Update Italian.properties

* Update German translation (#9345)

* Update German translation

* Update German translation

* Update Spanish.properties (#9344)

* update Simplified_Chinese (#9339)

* Update French.properties (#9336)

* Update French.properties

* Update French.properties

Better translation for the Kremlin quote.

* Update Polish.properties (#9335)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: mape6 <mape6@posteo.de>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: chr_56 <30681738+chr56@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
 2023-05-08 18:45:27 +03:00
Yair Morgenstern
02e6785969 Resolved #9332 - Solved rare concurrency bug for explored tiles 2023-05-08 18:37:44 +03:00
Yair Morgenstern
f8b4b202e7 Automated workers no longer stay on unimprovable tile if another tile is improvable 2023-05-08 18:29:34 +03:00
Yair Morgenstern
ea64f941a6 Resolved #9340 - fixed 'enhance religion' crash 2023-05-08 18:02:11 +03:00
Yair Morgenstern
ade3af7729 4.6.9-patch2 2023-05-07 09:57:19 +03:00
Yair Morgenstern
7b5ed07805 Resolved #9333 - Improperly configured mod conditionals do not cause crash 2023-05-07 09:52:59 +03:00
Yair Morgenstern
32041d5b49 4.6.9-patch1 2023-05-07 09:43:25 +03:00
Yair Morgenstern
cf4419912d 4.6.9 2023-05-06 21:25:13 +03:00
Yair Morgenstern
c895771b3a
Bump version and create initial changelog entry (#9334) 
Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
 2023-05-06 21:21:50 +03:00
Crsi
299aa06d94
Close the friend selection popup in NewGameScreen by click outside or ESC/BACK key (#9329) 2023-05-06 21:13:19 +03:00
SomeTroglodyte
100f4ede64
Fix memory leak from repeatedly resetting the font (#9326) 
* Fix memory leak from repeatedly resetting the font

* Reduce ruleset recompilation by MainMenuScreen background changes
 2023-05-05 15:20:30 +03:00
Yair Morgenstern
4b9c7171d3 Resolved #9242 - Hide buildings requiring multiple cities in one city challenge 2023-05-04 11:22:03 +03:00
Yair Morgenstern
fab32e8c8a Resolved #9304 - Added Policy icons and solved 'icons from Image' reflection :) 2023-05-04 11:07:54 +03:00
Yair Morgenstern
ec65b7e189 Resolved #9211 - Show Strategic resources you have by trade even if you have not researched tech for it yet 2023-05-04 10:49:40 +03:00
Yair Morgenstern
13a530ba11 Resolved #9294 - solved "get vanilla ruleset" errors after downloading mods 2023-05-04 10:39:42 +03:00
Yair Morgenstern
f6f0c7a050 Resolve #9262 - scale down unit overlays on zoom in to allow selecting bombard target above city 2023-05-04 10:28:30 +03:00
SomeTroglodyte
b0876935f5
Show a preview of custom maps on new game screen (#9234) 
* Show a preview of custom maps on new game screen

* Show a preview of custom maps on new game screen - step 2

* Show a preview of custom maps on new game screen V2
 2023-05-04 09:31:43 +03:00
SomeTroglodyte
43b044740c
Allow closing a Popup by clicking outside its area (#9306) 
* Allow closing a Popup by clicking outside its area

* Allow closing a Popup by clicking outside its area - upd1
 2023-05-04 09:25:14 +03:00
Yair Morgenstern
817764ec38 Probably resolved #9320 - AI 'found religion' crash 2023-05-04 09:20:00 +03:00
Yair Morgenstern
0252416e23
Version rollout (#9313) 
* Bump version and create initial changelog entry

* Update Ukrainian.properties (#9311)

* Update Polish.properties (#9309)

* Update Indonesian.properties (#9307)

Improve some translations

* Update French.properties (#9303)

* Update Catalan.properties (#9299)

* Update German.properties (#9297)

Fixed mistakes from the last pull request and made a few corrections.

Co-authored-by: Birk Birkner <birkner@bbirkner.de>

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Gualdimar <Gualdimar@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: kensvin <kensvin28@gmail.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: Joan Josep <juanjo.ng.83@gmail.com>
Co-authored-by: Knirps1 <52383078+Knirps1@users.noreply.github.com>
Co-authored-by: Birk Birkner <birkner@bbirkner.de>
 2023-05-03 00:06:53 +03:00
SomeTroglodyte
159ae86960
Reduce a few memory allocations (#9312) 2023-05-02 23:26:39 +03:00
WhoIsJohannes
fadeaafc75
Various performance improvements (#9296) 
* Move caches for passThrough and movementCost into the parent method.

* Reuse path calculated for reaching enemy city if still far away instead of recalculating it for the "landing tile".

* Cache getDistanceToTilesWithinTurn by removing tilesToIgnore from the call and doing that filtering later. Also simplify caller side with some transformations around differences for the first iteration and subsequent iterations.

* Check whether a player is spectator by comparing their civName directly with the Constant rather than going through the lazily initialized property of the nation. This is significantly faster (10x ?) and we're calling this method a lot (tens of millions of times).

Also check whether a tile is explored directly on the tile, not the other way round.

* Revert "Cache getDistanceToTilesWithinTurn by removing tilesToIgnore from the call and doing that filtering later. Also simplify caller side with some transformations around differences for the first iteration and subsequent iterations."

This reverts commit f75ce00d83.

* Simplify UnitMovement.getShortestPath
 2023-05-01 07:35:41 +03:00
Yair Morgenstern
271e88ad03
Version rollout (#9292) 
* Bump version and create initial changelog entry

* update Simplified_Chinese translation (#9289)

Co-authored-by: chr_56 <_>

* update Japanese.properties (#9286)

* Update Japanese.properties

* Update Japanese.properties

* Update Spanish.properties (#9285)

* Update Indonesian.properties (#9283)

* Update Brazilian_Portuguese.properties (#9277)

* Update Polish.properties (#9276)

* Update French.properties (#9274)

Small translation improvements:
- Remove a few past tenses which are unnecessary in French (in the context, past participle alone is enough, especially in notifications)
- More precise translation for "the defence of [cityName]", to refer to the unit garrisoned in the attacked city ("la défense" doesn't sound well)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: chr_56 <30681738+chr56@users.noreply.github.com>
Co-authored-by: namazulake <130637228+namazulake@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: t <73392607+tsaqibfs@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
 2023-04-26 22:08:34 +03:00
WhoIsJohannes
b8bd1fc2c2
Performance improvements (#9271) 
* Speed up WorkerAutomation.findTileToWork - apparently tileCanBeImproved is quite expensive

* Add cache for rankTileForCityWork in CityPopulationManager.autoAssignPopulation

* Optimize NextTurnAutomation.declareWar by moving expensive BFSs to the end and potentially short-circuiting evaluation if result won't be promising anyways.

* No need to throw if atLeast is negative.

* Revert changes to CityPopulationManager.kt

* Revert changes to CityPopulationManager.kt

* Speed up WorkerAutomation.findTileToWork - apparently tileCanBeImproved is quite expensive

* Add cache for rankTileForCityWork in CityPopulationManager.autoAssignPopulation

* Optimize NextTurnAutomation.declareWar by moving expensive BFSs to the end and potentially short-circuiting evaluation if result won't be promising anyways.

* No need to throw if atLeast is negative.

* Revert changes to CityPopulationManager.kt

* Revert changes to CityPopulationManager.kt
 2023-04-26 18:47:07 +03:00
chr_56
03ffa84bd3
Allow to reveal explored resources from a city's demanding resources in CityOverviewTab (#9287) 
* allow to locate explored resources from a city's demanding resources in `CityOverviewTab`

* better code of `updateCities` in `CityOverviewTab`
 2023-04-26 15:43:13 +03:00
WhoIsJohannes
cccaa88456
Cache civ uniques while refreshing world map tiles. (#9284) 
* Cache civ uniques while refreshing world map tiles.

This should have a pretty significant performance improvement of about 10% next rount time.

* Forgot to add stateForConditionals to cache key.

* Make cache keys depend on function

* Restrict LocalUniqueCache API to avoid using it the wrong way.

* Use default values instead of two methods
 2023-04-26 10:17:58 +03:00
Yair Morgenstern
cb626861df docs: better unique parameter documentation 2023-04-25 17:45:40 +03:00
Yair Morgenstern
079c237547 terrainFilter now accommodates nationFilter for owner 2023-04-25 17:45:40 +03:00
SomeTroglodyte
2b57bd44ab
Visual clue a load game from clipboard is underway (#9278) 2023-04-25 17:24:05 +03:00
SomeTroglodyte
a507da9a4a
Fix border case crash with lone AI winning on turn 0 (#9280) 2023-04-25 17:22:29 +03:00
Yair Morgenstern
e427d91850 Remove double icons from airsweep/nuke battle table 2023-04-25 17:20:35 +03:00
Yair Morgenstern
eecccd4542 Fade unit icon in overview if not idle 2023-04-25 17:18:07 +03:00
SomeTroglodyte
42dff5584e
"can be promoted" notification only when it's actually new (#9230) 
* "can be promoted" notification only when it's actually new

* Reviews - sumOf instead of fold
 2023-04-24 22:27:28 +03:00
SomeTroglodyte
dc5cc6d601
Fix wrapping for promotions in unit overview (#9239) 2023-04-24 22:11:39 +03:00
Yair Morgenstern
c7dde1bc41
Version rollout (#9273) 
* Bump version and create initial changelog entry

* Completed German translation and fixed a few mistakes (#9266)

Co-authored-by: Birk Birkner <birkner@bbirkner.de>

* Update Polish.properties (#9264)

* Update Italian.properties (#9260)

* Update French.properties (#9258)

* Update Indonesian.properties (#9257)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Knirps1 <52383078+Knirps1@users.noreply.github.com>
Co-authored-by: Birk Birkner <birkner@bbirkner.de>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: Newexae <96820363+Newexae@users.noreply.github.com>
Co-authored-by: kensvin <kensvin28@gmail.com>
 2023-04-24 17:37:40 +03:00
Yair Morgenstern
c9067df642 Remove 'reset to Dropbox' button since it's deprecated 2023-04-24 17:33:28 +03:00
Yair Morgenstern
0b3614d1df Remove experimental rendering (experiment unsuccessful) 2023-04-24 17:31:42 +03:00
WhoIsJohannes
033957c738
Performance improvements (#9265) 
* UnitMovement#getDistanceToTilesWithinTurn hotspots

* Make fog busting less expensive

* Speed up tryHeadTowardsEncampment

* Reorder conditions in isGoodTileToExplore

* Reorder conditions in isGoodTileToExplore

* Revert "Speed up tryHeadTowardsEncampment"

This reverts commit d3841a233b.

* Don't lookup twice.
 2023-04-24 17:16:43 +03:00
Yair Morgenstern
95ee35d301 Testing: Damage animations on damaged units 2023-04-24 17:07:55 +03:00
WhoIsJohannes
2f7fa6ba5c
Civs should not go all-out war if they're weaker than barbs (#9267) 2023-04-24 14:58:01 +03:00
SomeTroglodyte
a6f8f57860
Avoid first contact alerts for dead City-States (#9269) 
* Avoid first contact alerts for dead City-States

* Clearer simpler (hopefully) updateOurTiles
 2023-04-24 14:56:10 +03:00
Yair Morgenstern
e6b3640181 chore: Battle animation readability 2023-04-24 09:35:53 +03:00
WhoIsJohannes
19920ffbae
Don't leak other civs in the game through LineChart colors. (#9263) 2023-04-23 23:26:41 +03:00
Yair Morgenstern
ed3e6f2587 Slightly faster animation 2023-04-23 22:58:25 +03:00
Yair Morgenstern
782863f709 Units sprites move towards the enemy they're attacking 2023-04-23 22:29:02 +03:00
Yair Morgenstern
717e4befac
Version rollout (#9256) 
* Bump version and create initial changelog entry

* Update Indonesian.properties (#9255)

Now, Indonesian translation is complete

* Fixing some typos in the German translation (#9236)

* Fixing some typos in the German translation

* Fixed another typo

* Fixed a huge amount of typos

Ran over it with a hunspell. Found a few other mistakes in the process.

* Fixed mistranslations in quotes

Fixed one translation that seemed to be made with a software translator.
Replaced a translation of a translation with the original quote.

---------

Co-authored-by: Birk Birkner <birkner@bbirkner.de>

* Fix typo in Polish.properties (#9233)

* Update Turkish.properties (#9227)

* Update Turkish.properties

* Add files via upload

* Update Spanish.properties (#9206)

* Update Spanish.properties

* Update Spanish.properties

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: t <73392607+tsaqibfs@users.noreply.github.com>
Co-authored-by: Knirps1 <52383078+Knirps1@users.noreply.github.com>
Co-authored-by: Birk Birkner <birkner@bbirkner.de>
Co-authored-by: bread <77245194+breadtard@users.noreply.github.com>
Co-authored-by: Enesb852 <130827350+Enesb852@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
 2023-04-23 10:05:35 +03:00
Yair Morgenstern
226bd85c84 Resolved #9249 - Solved AI Great Scientist crash 2023-04-23 09:40:33 +03:00
Yair Morgenstern
2b4dbe2ad2 Resolved #9247 #9246 #9248 #9252 #9237 - Great Merchant doesn't try to go to unreachable tiles 2023-04-23 09:31:35 +03:00
SomeTroglodyte
cafcbbad4b
Make AI diplomatic marriage safe from concurrent modification issues (#9244) 2023-04-21 17:16:52 +03:00
SomeTroglodyte
e265e9a71f
Fix Main Menu BG map cycle not stopping on user action (#9229) 2023-04-20 00:21:02 +03:00
Yair Morgenstern
e9296842b6 4.6.4-patch2 
Use the same framebuffer / spritebatch for all icon renders
 2023-04-19 22:31:29 +03:00
Yair Morgenstern
a79fe06df3 4.6.4-patch1 
Dispose used objects immediately to avoid OutOfMemory
 2023-04-19 15:39:22 +03:00
Yair Morgenstern
32191bd57d 4.6.4 2023-04-19 11:52:57 +03:00
Yair Morgenstern
2184c494fc
Version rollout (#9224) 
* Bump version and create initial changelog entry

* Updated Brazilian_Portuguese.properties (#9223)

* Updated Brazilian_Portuguese.properties

* Updated Brazilian_Portuguese.properties

* Update Russian localization (#9222)

* Update Russian localization

Just in case, for the "X attacked our unit Y", I have chosen to make it a bit less precise (not directly stating that "Y" is player's unit) because due to language's specifics it's practically impossible with this translation scheme to not make grammar error.

* fix

should have used copy-paste

* Update Polish.properties (#9215)

* Update Italian.properties (#9209)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Alex <64156241+Alex-1000@users.noreply.github.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
 2023-04-19 11:42:09 +03:00
Yair Morgenstern
a10cf3bff2 Use label for chart dropdown - #6131 2023-04-19 11:41:08 +03:00
SomeTroglodyte
52f26ed9d3
Reassign workers when resistance ends or improvement created (#9212) 2023-04-19 11:34:31 +03:00
Yair Morgenstern
85c0f71f2a Removed more double icons 2023-04-19 11:32:00 +03:00
Yair Morgenstern
4d63f0542f Avoid font-related crash 2023-04-19 11:26:11 +03:00
Yair Morgenstern
2f25ed3053 Replaced hardcoded embarked sight with configurable 
"Normal vision when embarked" replaced by "[+1] Sight <for [Embarked] units>"
 2023-04-19 11:12:21 +03:00
Yair Morgenstern
26a155351e UnitFilter accepts NationFilter of the civ (e.g. "vs [England] units") 
chore: Constants for "Embarked" and "Wounded"
 2023-04-19 10:51:01 +03:00
SomeTroglodyte
2b1f2513fc
Fix "religions to be founded" expanders accumulating (#9214) 
* Fix my own dumb blunder re "Religions to be founded" expander

* Faith required for next Prophet should be visible
 2023-04-19 08:19:22 +03:00
Yair Morgenstern
4da4d35a28 Resolved #9194 - Clear frameBuffer before we use it to draw images 2023-04-18 23:09:33 +03:00
Yair Morgenstern
35fbb5f9f3 Resolved #9221 - removed icons from selectboxes 2023-04-18 23:00:16 +03:00
WhoIsJohannes
9ba5497ce4
Show replay after 5 rounds and don't reveal where player is on the map. (#9216) 2023-04-18 01:11:31 +03:00
SomeTroglodyte
92ad0495f2
I'm pretty sure annexed cities in resistance shouldn't be allowed to buy tiles (#9213) 2023-04-17 21:42:37 +03:00
Yair Morgenstern
dbc9b0d0bd 4.6.3-patch1 2023-04-17 21:04:20 +03:00
Yair Morgenstern
958318e53b Patch fix for crash, from Discord - @WhoIsJohannes 2023-04-17 21:04:20 +03:00
WhoIsJohannes
4eea7984f7
LineChart improvements (Highlight & DP) (#9210) 
* LineChart improvements (Highlight & DP)

* Fix civ icon at end of line not showing.
 2023-04-17 18:56:22 +03:00
Yair Morgenstern
0eda518bf9 Whoops a movement change got in when it shouldn't have 2023-04-17 13:50:44 +03:00
Yair Morgenstern
844b0a15d1 4.6.3 2023-04-17 09:36:45 +03:00
Yair Morgenstern
699a6bf12a Removed double icons 2023-04-17 09:33:31 +03:00
Yair Morgenstern
0bf5cae401 Solved RAM crashes hopefully :) 2023-04-17 09:33:31 +03:00
Yair Morgenstern
e313f00f6d
Version rollout (#9208) 
* Bump version and create initial changelog entry

* Update French.properties (#9201)

* Translate Simplified_Chinese.properties (#9200)

4.6.2 Basic Translate

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: YaoSiQian <2229561981@qq.com>
 2023-04-17 09:33:26 +03:00
Yair Morgenstern
eabb91b0d8 Aircraft attack/move range colors entire tile 2023-04-17 08:37:02 +03:00
WhoIsJohannes
ccf37af468
Show garrison in city screen, so that it's easier to decide whether one should produce a military unit. (#9202) 2023-04-17 08:20:18 +03:00
WhoIsJohannes
d25804ffb5
Great people automation (#9125) 
* Add automation for great scientist & merchant

* Automate great people (great merchant, great engineer & great scientist).

* Address comments

* Rename method for consistency

* Resolve comments
 2023-04-17 08:19:55 +03:00
WhoIsJohannes
b9a7925285
Order defeated civs after alive civs even if the alive civs score is negative (e.g. for happiness) (#9203) 2023-04-17 07:38:43 +03:00
WhoIsJohannes
dbb46545f5
Fix golden age length action text (#9204) 
Thanks SomeTroglodyte (https://github.com/yairm210/Unciv/issues/9166#issuecomment-1503593954)
 2023-04-17 07:37:56 +03:00
SomeTroglodyte
4f30d27d0b
Notifications can be "selected" (#9182) 
* Allow "selecting" notifications

* NotificationsScroll remembers position relative to topRight

* NotificationsScroll tries to scroll selection into view

* Fix notification selection and scroll-into-view

* User option to control enlarging selected notifications

* Post-merge missed changes

* Move, flip and reword "Enlarge" option
 2023-04-16 21:20:56 +03:00
Yair Morgenstern
ab1d823477 4.6.2 2023-04-16 15:01:43 +03:00
Yair Morgenstern
4c6c6e91fd
Version rollout (#9199) 
* Bump version and create initial changelog entry

* Update Simplified_Chinese.properties (#9195)

* Update Turkish.properties (#9193)

* Update Spanish.properties (#9192)

* Update French.properties (#9190)

* Update Hungarian.properties (#9187)

* Update Polish.properties (#9180)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: CrispyXYZ <64761703+CrispyXYZ@users.noreply.github.com>
Co-authored-by: Enesb852 <130827350+Enesb852@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: balazsszalab <balazsszalab@freemail.hu>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
 2023-04-16 14:52:41 +03:00
Yair Morgenstern
2586e59638 Hide icons in game file names - see #9194 2023-04-16 14:48:58 +03:00
Yair Morgenstern
eb79e77a26 Removed icons from city names, removed icons from notifications for performance reasons 2023-04-16 14:43:34 +03:00
Yair Morgenstern
a81dd03fcf Added "in this city", "in other cities" conditionals for city-based uniques 2023-04-16 14:43:34 +03:00
SomeTroglodyte
dea3256c93
Unhappiness effects (#9188) 
* Block growth if Unique says so - even with full stores

* Display unhappiness rejection reason for Settlers

* Display unhappiness effects in Overview Stats

* Display unhappiness effects in Overview Stats - simplify
 2023-04-16 14:21:58 +03:00
SomeTroglodyte
90cac15c7f
Fix more leaks of the actual Player count in random mode (#9196) 2023-04-16 14:20:08 +03:00
Yair Morgenstern
bc5e486b20 Resolves #9186 
Atilla's Court -> Attila's Court, Guten tag -> Guten Tag
 2023-04-15 21:00:17 +03:00
SomeTroglodyte
3b3db71fd8
Allow city- or tile- related conditionals on PerpetualStatConversion enabling unique (#9183) 2023-04-14 08:28:07 +03:00
Yair Morgenstern
26d16fc1cc 4.6.1-patch2 
Fixed multiplayer games not starting because player ID was being lost on the way @SomeTroglodyte
 2023-04-13 23:58:41 +03:00
Yair Morgenstern
fd9284f8a3 4.6.1-patch1 2023-04-13 23:21:42 +03:00
Yair Morgenstern
5232984bd9 More UI cleanup 2023-04-13 23:19:57 +03:00
Yair Morgenstern
d542fbc0af Removed more double icons 2023-04-13 23:01:48 +03:00
Yair Morgenstern
0d6aa82540 Resolved #9169 - Return error when cannot upload game to Dropbox 2023-04-13 18:17:21 +03:00
Yair Morgenstern
e7653bd53d Resolved #9163 - Can again spectate games where not an original participant 2023-04-13 17:51:11 +03:00
Yair Morgenstern
2fbd24231f Resolved #9177 - Tileset no longer reverts to default on Android after restarting game 2023-04-13 17:41:59 +03:00
Yair Morgenstern
f98f4e8c9b Retreat chance is savescum-safe - #9178 2023-04-13 16:55:16 +03:00
Yair Morgenstern
ebfda6ffc0 Resolved #9178 - 'unit gain from defeating unit' takes attacking/defending units into account for randomness 2023-04-13 16:50:24 +03:00
Yair Morgenstern
28f5043fcb 4.6.1 2023-04-13 16:26:43 +03:00
Yair Morgenstern
2ce145be1e
Version rollout (#9179) 
* Bump version and create initial changelog entry

* Updated Brazilian_Portuguese.properties (#9170)

* Updated Brazilian_Portuguese.properties

* Update Brazilian_Portuguese.properties

* Update Brazilian_Portuguese.properties

* Update Hungarian.properties (#9161)

* Update Hungarian.properties

* Update Hungarian.properties

* Update Italian.properties (#9160)

* update Simplified_Chinese translation (#9159)

Co-authored-by: chr_56 <_>

* Update Ukrainian.properties (#9153)

* Update French.properties (#9152)

* Update Czech.properties (#9151)

translated some of the yet untranslated texts

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: balazsszalab <balazsszalab@freemail.hu>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: chr_56 <30681738+chr56@users.noreply.github.com>
Co-authored-by: Gualdimar <Gualdimar@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: brmaku <46785630+brmaku@users.noreply.github.com>
 2023-04-13 16:20:25 +03:00
Yair Morgenstern
e05c561f68 Added parameter type for stockpiled resources specifically 2023-04-13 16:07:11 +03:00
Yair Morgenstern
4d3b2845fd Fix "Instantly consumes [amount] [resource]" 2023-04-13 16:02:46 +03:00
Yair Morgenstern
36a8b368c8
Arbitrary images in font!!! (#9167) 
* Arbitrary images in font!!!

* Added unit, promotion, and improvement icons to text

* Fixed icons in notifications

* Removed icons from formatted lines to avoid double-icons

* Removed nation icon from next to menu to not have double-icons

* Removed nation icon from next to menu to not have double-icons

* Icons do not appear in Civilopedia twice

* Better Nation texts
 2023-04-13 16:00:50 +03:00
WhoIsJohannes
193114078b
Show a highlight for the tile that seems most suitable to found a cit… (#9099) 
* Show a highlight for the tile that seems most suitable to found a city (can be turned off in settings)

* Don't allow players to cheat through highlighting suggested map tiles for city founding.

* Don't pass whether cheating is allowed, but just decide based on whether civ is AI or not. That way it will also work correctly for automated settlers (by human players). Also show it in the first round, because why not. If the map generator puts us on a shitty starting tile, why not tell the player?

* Address comments

* Address comments
 2023-04-13 15:43:46 +03:00
WhoIsJohannes
b0f4e42e99
Show replay after 50 turns, but only the discovered part of it. (#9172) 2023-04-13 15:39:26 +03:00
SomeTroglodyte
e0533e994f
Fix startBias regional assignments (#9171) 2023-04-13 15:38:19 +03:00
WhoIsJohannes
9ea135fba8
Charts improvements (#9168) 
* Let spectator see civ groups in VictoryScreen

* Display defeated players normally for charts. Otherwise it's difficult to see which line belongs to them.

* Don't show a 0 for defeated civs.

* Delete dead code.

* Show the civ icon on the last data point within the chart, not next to it and simplify some computations with now obsolete paddings.

* Support negative values in the chart

* Remove TODO for negative values
 2023-04-13 11:55:59 +03:00
WhoIsJohannes
e72591e470
Highlight non-available wonders in tech picker (#9173) 
* Show wonders in tech tree with a blue color and also show which wonders have already been built for technologies not yet researched with a red circle around them.

* Only show red circle.
 2023-04-13 11:54:35 +03:00
SomeTroglodyte
0500f73770
Victory screen and victory detection use VictoryData (#9175) 
* VictoryScreen uses VictoryData

* Victory detection no longer circumvents VictoryData
 2023-04-13 11:54:11 +03:00
SomeTroglodyte
2e61023248
Close immediate win loophole (playing alone) (#9176) 2023-04-13 11:52:16 +03:00
Yair Morgenstern
19b243abfe 'Display' options organized into subcatagories - kudos @Ouaz 2023-04-11 11:28:24 +03:00
SomeTroglodyte
46a9a7251e
Fix incorrect relationship level comparison (#9156) 2023-04-11 11:04:31 +03:00
SomeTroglodyte
6efb4926af
Fix map editor resource label wrapped to about 1 char width (#9162) 
* Fix potential problems with making ColorMarkupLabel wrappable

* Fix map editor resource label wrapped to about 1 char width
 2023-04-11 09:09:07 +03:00
MioBestWaifu
e7d091197f
Fix issue #7792 (#9164) 
The issue was caused by Latin-Civs Mixed Militias being considered workers in ConstructionAutomation.addWorkerChoice() but not beign counted as one in ConstructionAutomation.workers. Now, any unit that can build improvements counts as a worker in it. In addition, the AI simulates military units that can found city, build improvements or are religious as civilians in peacetime and as soldiers in wartime.
 2023-04-11 07:55:15 +03:00
Yair Morgenstern
a363edaa6a 4.6.0 2023-04-09 18:15:53 +03:00
Yair Morgenstern
52f288be05
Version rollout (#9149) 
* Bump version and create initial changelog entry

* Update Simplified_Chinese.properties (#9145)

* Update Italian.properties (#9143)

* Update Spanish.properties (#9142)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: qw142536 <123065131+qw142536@users.noreply.github.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
 2023-04-09 18:07:03 +03:00
Yair Morgenstern
adb51d9264
Resource stockpiles! (#9147) 
* Resource stockpiles!

* toString extension including sign (+/-)

* Trigger uniques to provide/consume stockpiled resources

* Fixed build

* Display 'per turn' for stockpiled resources that are consumed per turn

* "Costs [amount] [resource]" works!

* Stockpile unique costs are displayed in construction button

* Added unique to prevert certain resources from being traded
 2023-04-09 18:01:26 +03:00
SomeTroglodyte
0c60f87b27
User option to control NotificationScroll behaviour (#9148) 2023-04-09 17:58:39 +03:00
Yair Morgenstern
32a76fd359 4.5.17-patch1 
Solved "cannot start single player game"
 2023-04-09 17:27:17 +03:00
Yair Morgenstern
a691066b05 Resolved #9146 - crash screen ' 
copy to clipboard' no longer causes crashes itself
 2023-04-09 17:23:22 +03:00
Yair Morgenstern
338c4bd7e4 toString extension including sign (+/-) 2023-04-09 14:11:42 +03:00
Yair Morgenstern
29c647e0f7 Actually implemented nation filter conditional 2023-04-09 10:27:34 +03:00
SomeTroglodyte
065f434fb6
Code Reorg AlertPopup (#9140) 2023-04-09 01:47:38 +03:00
Yair Morgenstern
711655c786 Better wrapping for long construction item names 2023-04-09 01:20:17 +03:00
Yair Morgenstern
0d9cff0922 "<for [nationFilter]>" conditional added 2023-04-08 22:46:49 +03:00
Yair Morgenstern
d339de1929
Version rollout (#9139) 
* Bump version and create initial changelog entry

* Added 112 dutch translations (#9131)

* Update Polish.properties (#9129)

* Update Polish.properties

* Update Polish.properties

* Update Polish.properties

* Update Hungarian.properties (#9107)

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Italian.properties (#9102)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Abe van der Wielen <abevanderwielen@gmail.com>
Co-authored-by: Lesiakower <125187776+Lesiakower@users.noreply.github.com>
Co-authored-by: balazsszalab <balazsszalab@freemail.hu>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
 2023-04-08 22:09:54 +03:00
Yair Morgenstern
77f230ff1a Fixed json loading errors in latest version due to tab names changing 2023-04-08 22:03:22 +03:00
SomeTroglodyte
04d4def24f
Notifications can be hidden (#9108) 
* Some linting around Notification UI

* Hide-able NotificationsScroll with restore button
 2023-04-08 21:40:48 +03:00
SomeTroglodyte
6b084f0e6b
Victory screen score charts (#9121) 
* VictoryScreen with Charts by WhoIsJohannes

* VictoryScreen with Charts by WhoIsJohannes - atlas

* VictoryScreen with Charts by WhoIsJohannes - lost icon attribution
 2023-04-08 21:38:27 +03:00
SomeTroglodyte
93d2ba2af5
Carrier right-click attack fix (#9130) 2023-04-08 21:36:19 +03:00
Yair Morgenstern
cb20d91822 Battle table displays bonuses according to tile that unit will attack from, not the current tile it's on 2023-04-08 21:34:55 +03:00
SomeTroglodyte
ca06d7e54a
Main menu background map changes infrequently (#9133) 2023-04-07 16:22:46 +03:00
SomeTroglodyte
36667d9d18
Random Nations game starter - reactive UI (#9127) 
* Random Nations game starter - reactive UI

* Random Nations game starter - reactive UI continued

* Random Nations game starter - reactive UI - patch
 2023-04-07 09:53:04 +03:00
WhoIsJohannes
21510a8455
Show city size in CityScreenCityPickerTable.kt (#9120) 
I need this quite often when deciding whether to build something such as "Library" (get 1 research for each 2 population -> "Oh, wait, what's the population of this city?")

Longer term I want to check how hard it would be to show the effects of something more directly e.g. for the social policy picker screen. E.g. "Gain one happiness for each city with a garrison" or "Empire produces double the amount of resources" or "1 extra happiness for each walls, castle, arsenal etc.", would be nice to see directly to how much happiness, resources that translates to make a better decision.
 2023-04-05 12:25:30 +03:00
WhoIsJohannes
6b4003311b
Don't buy tiles in the very early game. (#9117) 2023-04-04 23:42:18 +03:00
SomeTroglodyte
2150fc2244
Random nation count (#9118) 
* Fix game starter problems with random number of players

* Some cleanup to use new Player constructor signature
 2023-04-04 23:41:45 +03:00
WhoIsJohannes
0e87be8487
Prevent offering zero gold. (#9119) 
This happened to me in a game, unfortunately I don't have the save since it's one round ago in a multiplayer game, but I'm pretty sure this is the part of the code causing the problem.
 2023-04-04 23:40:36 +03:00
SomeTroglodyte
910778418a
Victory screen replay gets a Slider (#9116) 
* VictoryScreen tweaks for narrow portrait, UncivSlider update

* VictoryScreen Replay Slider
 2023-04-04 22:06:22 +03:00
Yair Morgenstern
7cfbc9b7fa Fixed bug where AI could buy tiles not contiguous to city - @WhoIsJohannes 2023-04-04 10:58:08 +03:00
SomeTroglodyte
4c88fbb996
Change map resource controls presentation (#9104) 2023-04-04 10:52:42 +03:00
WhoIsJohannes
bc341a6fcb
Don't do anything crazy if military is inferior and never give away m… (#9096) 
* Don't do anything crazy if military is inferior and never give away more than 10% (ceil) of your cities in any case.

* Don't coerce types implicitly.

* Comment weird distance to capital logic and invert -- => +

* Maximum give away 20% of cities instead of 10%
 2023-04-04 10:50:33 +03:00
SomeTroglodyte
cd4e25a4f1
Victory screen reorg/cleanup (#9111) 
* VictoryScreen reorg

* VictoryScreen reorg - use TabbedPager

* VictoryScreen reorg - make helpers reusable

* VictoryScreen reorg - fixed headers

* VictoryScreen reorg - debug access to Replay

* Victories reorg - more cleanup

* VictoryScreen reorg - icons and keys

* VictoryScreen reorg - RankingType

* VictoryScreen reorg - RecreateOnResize

* VictoryScreen reorg - Avoid floating text overlapping buttons

* VictoryScreen reorg - remove obsolete todo
 2023-04-04 10:49:58 +03:00
WhoIsJohannes
8b01498227
Get going with producing military if your ass is about to get kicked. (#9109) 2023-04-03 23:38:04 +03:00
Yair Morgenstern
9e239de6ce Resolved #9103 - invalid conditionals on building uniques no longer lead to crashes 2023-04-03 21:54:52 +03:00
Yair Morgenstern
6953e0341b 4.5.16-patch 
Fixed 'construct improvement' crash
 2023-04-03 21:34:39 +03:00
SomeTroglodyte
ca36c0e6e6
Prevent MapEditor 'pinch zoom' painting tiles (#9101) 2023-04-03 17:06:11 +03:00
Yair Morgenstern
35d5b8c43c
Version rollout (#9100) 
* Bump version and create initial changelog entry

* Updated Brazilian_Portuguese.properties (#9094)

* Update Ukrainian.properties (#9093)

* Update Catalan.properties (#9090)

* Update Spanish.properties (#9088)

All tutorial page text

* Update Hungarian.properties (#9084)

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Hungarian.properties

* Update Simplified_Chinese.properties (#9083)

- add more translation

* Update French.properties (#9082)

* Update Turkish.properties (#9081)

Add and revise translations

* Update Bulgarian.properties (#9080)

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Gualdimar <Gualdimar@users.noreply.github.com>
Co-authored-by: Joan Josep <juanjo.ng.83@gmail.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: balazsszalab <balazsszalab@freemail.hu>
Co-authored-by: Tim <2884320+tim-hub@users.noreply.github.com>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
Co-authored-by: omerfaruk-cakmak <32402595+omerfaruk-cakmak@users.noreply.github.com>
Co-authored-by: Bogomil Stefanov <101423783+vynaaa@users.noreply.github.com>
 2023-04-03 14:53:35 +03:00
Yair Morgenstern
67482f0ebe #9098 - rankStatsForCityWork also uses local unique cache 2023-04-03 14:36:24 +03:00
Yair Morgenstern
d6f5e0badb #9098 - getKnownCivs returns sequence 2023-04-03 14:09:56 +03:00
Yair Morgenstern
f387de9506 performance: Don't update visible tiles if we've moved within our border 2023-04-03 11:13:29 +03:00
Yair Morgenstern
ad299a8a62 performance: Cache uniques for calculating specialist stats 2023-04-03 11:03:59 +03:00
Yair Morgenstern
9c121086ea Performance: Removed map lookup for getLastTerrain 
This was used in isImpassible which was used in canPassThrough, which means it was called A LOT
 2023-04-03 10:55:52 +03:00
Yair Morgenstern
f0ee25dcac Performance: Removed map lookup every time we want to get a unit's type 2023-04-03 10:49:50 +03:00
Yair Morgenstern
bfb869f64f Performance: nation type booleans are all lazy vals, to avoid unnecessary string comparisons 
These were so numerous that they were popping up in the CPU profiler which is just unacceptable
 2023-04-03 10:45:19 +03:00
Yair Morgenstern
f50b88c9a5 Performance: Save civ tiles and neighbors in cache to update visible tiles faster 2023-04-03 10:32:09 +03:00
Yair Morgenstern
3db03a78d2 Performance: Use unique cache for tile percentage stats and auto-assigning population to tiles 2023-04-03 09:27:05 +03:00
SomeTroglodyte
d3ac7c24bd
Declare Era.citySound not TranslationFileWriter-worthy (#9095) 2023-04-03 07:22:58 +03:00
SomeTroglodyte
a4c4c5f93e
Music player controls (#9087) 
* Music controls cleanup

* Music controls cleanup - assets

* Music controls cleanup - fix incorrect attribution
 2023-04-01 22:06:46 +03:00
Yair Morgenstern
36b90075da 4.5.15 2023-03-31 16:17:52 +03:00
Yair Morgenstern
9f521895aa
Version rollout (#9079) 
* Bump version and create initial changelog entry

* Update Simplified_Chinese.properties (#9078)

- for screen orientation part translation
- and a few due-to missed translation
- and borderless

* Update Ukrainian.properties (#9076)

* Update Hungarian.properties (#9074)

* Update Indonesian.properties (#9071)

* Update Indonesian.properties

* Update Indonesian.properties

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Tim <2884320+tim-hub@users.noreply.github.com>
Co-authored-by: Gualdimar <Gualdimar@users.noreply.github.com>
Co-authored-by: balazsszalab <balazsszalab@freemail.hu>
Co-authored-by: kensvin <kensvin28@gmail.com>
 2023-03-31 15:52:29 +03:00
SomeTroglodyte
45d66f0580
Civilopedia Welcome, moddable (#8940) 2023-03-31 14:58:07 +03:00
WhoIsJohannes
de7177692f
Make AI buy city tiles. (#9065) 
* Make AI buy city tiles.

* Address comments
 2023-03-31 14:54:03 +03:00
SomeTroglodyte
ce495d4ff2
Fix ColorMarkupLabel prefSize (#9077) 2023-03-31 14:48:30 +03:00
Yair Morgenstern
2d184655c7 Automated units don't try and conquer the same city twice 2023-03-30 20:51:56 +03:00
SomeTroglodyte
aea988a6bb
Untinted embedded symbols - Notifications and Citystate diplomacy (#9051) 2023-03-30 16:32:43 +03:00
SomeTroglodyte
3d56c1ba5d
Fix disbanding units a civ cannot afford (#9073) 
* Fix disbanding units a civ cannot afford

* Avoid performance impact of CityState Afraid evaluation where possible
 2023-03-30 10:22:52 +03:00
SomeTroglodyte
c5d0de8144
Main menu cancels background map creation when obsolete (#9072) 2023-03-30 10:22:37 +03:00
Yair Morgenstern
6fa1d61f4f Constructed units that can't be placed are put on hold till the next turn 2023-03-29 23:19:55 +03:00
Yair Morgenstern
223494fa52
Version rollout (#9069) 
* Bump version and create initial changelog entry

* Update for Russian localization (#9068)

Translation for most of lines of text. There are some left as it's impossible to translate those correctly without context, which is not provided in a nice way, so only way to understand their meaning is finding them in-game (Which I couldn't do, unfortunately.)

* Update Spanish.properties (#9066)

* Update Filipino.properties (#9062)

* Update Filipino.properties

* Update Filipino.properties

* Update Filipino.properties

* Update Filipino.properties

* Update Filipino.properties

* Update Italian.properties (#9061)

* Update Brazilian_Portuguese.properties (#9060)

* Update Bulgarian.properties (#9053)

* Update German translation (#9049)

* Update French.properties (#9046)

* Fixed russian translation errors

---------

Co-authored-by: yairm210 <yairm210@users.noreply.github.com>
Co-authored-by: Alex <64156241+Alex-1000@users.noreply.github.com>
Co-authored-by: Caballero Arepa <78449553+Caballero-Arepa@users.noreply.github.com>
Co-authored-by: Shann Aurelle Ripalda <shannaurelleg@gmail.com>
Co-authored-by: Giuseppe D'Addio <41149920+Smashfanful@users.noreply.github.com>
Co-authored-by: Vitor Gabriel <59321138+Ranbut@users.noreply.github.com>
Co-authored-by: Bogomil Stefanov <101423783+vynaaa@users.noreply.github.com>
Co-authored-by: mape6 <mape6@posteo.de>
Co-authored-by: Ouaz <Ouaz@users.noreply.github.com>
 2023-03-29 12:19:57 +03:00
SomeTroglodyte
be69f8b52d
Fix TileSet mods can lock user out (#9023) 2023-03-29 11:42:34 +03:00
SomeTroglodyte
13f4dd0756
Fix obsoleted units replace in construction queues for Nation-unique upgrades (#9044) 2023-03-29 11:34:40 +03:00
Yair Morgenstern
d3305e680a Resolved #9058 - Mods that remove 'repair' improvement no longer cause crashes down the line 2023-03-29 10:17:20 +03:00
Yair Morgenstern
6000232eac Resolved #9054 - Archipelago creates water again 2023-03-29 09:57:37 +03:00
SomeTroglodyte
bb332637d1
Fix exploit allowing promotion with 0 movement (#9055) 
* Close exploit allowing promotion with 0 movement

* PromotionPickerScreen linting
 2023-03-28 07:35:56 +03:00
SomeTroglodyte
76705f98e9
Fix notifications for pillage loot (#9047) 2023-03-27 09:17:51 +03:00
SomeTroglodyte
dc4e78f073
A renamed unit shows that new name in can promote notifications (#9043) 2023-03-26 22:29:45 +03:00
Yair Morgenstern
837833e450 4.5.13 2023-03-26 21:55:23 +03:00